New issue
Advanced search Search tips

Issue 841631 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 851823

Blocking:
issue 840435



Sign in to add a comment

Make Chrome builds with a 10.10 deployment target

Project Member Reported by spqc...@chromium.org, May 10 2018

Issue description

We no longer support Mac OSX 10.9 so we should bump the deployment target to 10.9

We will need to make sure that things build with a newer deployment target (Similar to what we did for  Issue 547071 )
 
 
Blocking: 840435
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ee2f679d3705ab7812aa166795eebd2a2618d2a

commit 5ee2f679d3705ab7812aa166795eebd2a2618d2a
Author: Robert Sesek <rsesek@chromium.org>
Date: Fri Jun 01 23:51:56 2018

[Mac] Bump the LSMinimumSystemVersion to 10.10.0

Chromium dropped support for macOS 10.9 but did not bump the
LSMinimumSystemVersion. The Info.plist key was tied to the
MACOSX_DEPLOYMENT_TARGET, but because there is still outstanding work to
update that, the value does not reflect the real requirement.

This introduces a new GN variable mac_min_system_version that is used
for the LSMinimumSystemVersion, so that it can be controlled
independently of the GN variable mac_deployment_target.

Bug: 806071, 841631, 848769
Test: Chromium.app/Contents/Info.plist has a LSMinimumSystemVersion of 10.10.0
Change-Id: I90f5393aeb411dca0ae4d53f03c882cc969f6912
Reviewed-on: https://chromium-review.googlesource.com/1082757
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563868}
[modify] https://crrev.com/5ee2f679d3705ab7812aa166795eebd2a2618d2a/build/config/mac/base_rules.gni
[modify] https://crrev.com/5ee2f679d3705ab7812aa166795eebd2a2618d2a/build/config/mac/mac_sdk.gni
[modify] https://crrev.com/5ee2f679d3705ab7812aa166795eebd2a2618d2a/chrome/app/app-Info.plist
[modify] https://crrev.com/5ee2f679d3705ab7812aa166795eebd2a2618d2a/chrome/app/helper-Info.plist
[modify] https://crrev.com/5ee2f679d3705ab7812aa166795eebd2a2618d2a/chrome/app_shim/app_mode-Info.plist
[modify] https://crrev.com/5ee2f679d3705ab7812aa166795eebd2a2618d2a/chrome/installer/mac/app/Info.plist
[modify] https://crrev.com/5ee2f679d3705ab7812aa166795eebd2a2618d2a/extensions/shell/app/app-Info.plist
[modify] https://crrev.com/5ee2f679d3705ab7812aa166795eebd2a2618d2a/extensions/shell/app/helper-Info.plist

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 4 2018

Labels: merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6611d14092ca56667c82ac07e92b0f060d3a4901

commit 6611d14092ca56667c82ac07e92b0f060d3a4901
Author: Robert Sesek <rsesek@chromium.org>
Date: Mon Jun 04 18:14:42 2018

[Mac] Bump the LSMinimumSystemVersion to 10.10.0

Chromium dropped support for macOS 10.9 but did not bump the
LSMinimumSystemVersion. The Info.plist key was tied to the
MACOSX_DEPLOYMENT_TARGET, but because there is still outstanding work to
update that, the value does not reflect the real requirement.

This introduces a new GN variable mac_min_system_version that is used
for the LSMinimumSystemVersion, so that it can be controlled
independently of the GN variable mac_deployment_target.

(cherry picked from commit 5ee2f679d3705ab7812aa166795eebd2a2618d2a)

Bug: 806071, 841631, 848769
Test: Chromium.app/Contents/Info.plist has a LSMinimumSystemVersion of 10.10.0
Change-Id: I90f5393aeb411dca0ae4d53f03c882cc969f6912
Reviewed-on: https://chromium-review.googlesource.com/1082757
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563868}
Reviewed-on: https://chromium-review.googlesource.com/1085428
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#144}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/6611d14092ca56667c82ac07e92b0f060d3a4901/build/config/mac/base_rules.gni
[modify] https://crrev.com/6611d14092ca56667c82ac07e92b0f060d3a4901/build/config/mac/mac_sdk.gni
[modify] https://crrev.com/6611d14092ca56667c82ac07e92b0f060d3a4901/chrome/app/app-Info.plist
[modify] https://crrev.com/6611d14092ca56667c82ac07e92b0f060d3a4901/chrome/app/helper-Info.plist
[modify] https://crrev.com/6611d14092ca56667c82ac07e92b0f060d3a4901/chrome/app_shim/app_mode-Info.plist
[modify] https://crrev.com/6611d14092ca56667c82ac07e92b0f060d3a4901/chrome/installer/mac/app/Info.plist
[modify] https://crrev.com/6611d14092ca56667c82ac07e92b0f060d3a4901/extensions/shell/app/app-Info.plist
[modify] https://crrev.com/6611d14092ca56667c82ac07e92b0f060d3a4901/extensions/shell/app/helper-Info.plist

Comment 4 by tapted@chromium.org, Jun 12 2018

Blockedon: 851823
Labels: Target-71 M-71
Deprecated things so far in 10.10:

launch_data_t functions
old NSObject accessibility API
LSFindApplicationForInfo and some related functions
LSSharedFileListItemResolve
[CWInterface interface]

Sign in to add a comment