New issue
Advanced search Search tips

Issue 841627 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Google Chrome OS Terms screen appeared twice during the OOBE. Heard start up sound at this point.

Project Member Reported by mkarkada@chromium.org, May 10 2018

Issue description

Chrome OS: 10575.32.0, 67.0.3396.41 beta build on coral bruce, eve devices

What steps will reproduce the problem?
1. Powerwash the device and Welcome screen appears
2. Perform OOBE
3. At Google Chrome OS Terms screen, click 'Accept and Continue' button.
4. Provide user credentials and reach 'You're signed in!' screen

What happens ?
Step 1. Start up sound was not heard at the Welcome screen.
Step 3. After the button click, desktop screen went black and then Google Chrome OS Terms screen appeared again. Start up sound was heard at this screen which is not intended.
Step 4. Sometimes, a blank white screen is shown to the user until 'You're signed in!' screen is loaded. This should not happen.

Expected Behavior:
Start up sound must be heard at the Welcome screen.
Google Chrome OS Terms screen should not appear twice.

This issue is reproduced 1/3 times

Attached debug logs and issue video.
 
Cc: mkarkada@chromium.org
 Issue 843699  has been merged into this issue.
Components: -UI>Shell>StartScreen UI>Shell>OOBE

Comment 4 by cindyb@chromium.org, May 22 2018

Need owner and updated status for this fix.

Comment 5 by r...@chromium.org, May 22 2018

Owner: alemate@chromium.org
Status: Assigned (was: Untriaged)
Cc: apronin@chromium.org
+apronin

Black screen usually means Chrome crash.
The is also a line in /var/log/messages:

crash_reporter[2816]: [ARC] Received crash notification for chrome[1317] sig 5, user 1000 (ignoring - crash origin is not ARC)

Signal 5 is "debug break", so it is likely CHECK(). Unfortunately CHECKs in release build do not log any message.

The last message from this process was:

ui/ui.LATEST:[1317:1317:0509/165226.022342:ERROR:object_proxy.cc(617)] Failed to call method: org.chromium.CryptohomeInterface.RemoveFirmwareManagementParameters: object_path= /org/chromium/Cryptohome: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.Cryptohome was not provided by any .service files

And cryptohomed was up and running at that time:

$ grep cryptohome messages 
2018-05-09T23:52:25.889362+00:00 WARNING cryptohomed[2134]: Canceled creating cryptohome key - TPM is not ready.
2018-05-09T23:52:25.889596+00:00 WARNING cryptohomed[2134]: Could not load the device policy file.
2018-05-09T23:52:25.902058+00:00 ERR cryptohomed[2134]: Creating new salt at /home/.shadow/salt (0, 0)
2018-05-09T23:52:26.361766+00:00 INFO cryptohomed[2134]: Cannot read boot lockbox files.
2018-05-09T23:52:28.207186+00:00 ERR cryptohomed[2134]: IsEndorsementKeyAvailable: Not Implemented.
2018-05-09T23:52:28.207216+00:00 ERR cryptohomed[2134]: IsEndorsementKeyAvailable: Not Implemented.
2018-05-09T23:52:29.683999+00:00 ERR cryptohomed[2134]: SetIsOwned: Not Implemented.
2018-05-09T23:52:29.684027+00:00 ERR cryptohomed[2134]: TestTpmAuth: Not Implemented.
2018-05-09T23:52:29.686775+00:00 ERR cryptohomed[2134]: Taking TPM ownership took 1640ms
2018-05-09T23:52:29.687010+00:00 INFO cryptohomed[2134]: Configuring TPM, ownership taken: 1.
2018-05-09T23:52:43.863427+00:00 INFO cryptohomed[2134]: Lockbox created.
2018-05-09T23:52:59.277598+00:00 WARNING cryptohomed[2134]: Could not load the device policy file.
2018-05-09T23:53:48.782181+00:00 WARNING cryptohomed[2134]: Could not load the device policy file.
2018-05-09T23:53:48.819745+00:00 INFO cryptohomed[2134]: Skipping random salt generation.
2018-05-09T23:53:50.649801+00:00 INFO cryptohomed[2134]: Encrypted partition finalized.
2018-05-09T23:53:50.666745+00:00 INFO cryptohomed[2134]: InstallAttributes have been finalized.
...


So I would suspect that cryprohomed has not yet created listening socket, and then crashed.

CC'ing Andrew to verify that.
Yes, it is possible that cryptohomed hasn't yet registered on dbus at this point. Note that cryptohomed depends on a chain of other daemons and tasks (cr50-update, trunks, tpm_manager, attestation), the whole chain starts only after login-prompt-visible, and on the 1st boot there's a lot to be done

As a part of this start, (a) on 1st boot tpm_managerd performs lengthy tpm pre-initialization (was added to lower the chance to hit this operation while the user logs in - issue 772187), (b) as a part of its start, cryptohomed needs to request the TPM state from tpm_managerd, and for that needs to wait for tpm_managerd to complete that long operation if it is still ongoing (to be improved in issue 777679, issue 777688, b/68167013, and further addressed with EC keys).

So, yes, Chrome can't assume that cryptohomed is registered on dbus already when the user logs in. Also, note that even if the cryptohomed is on dbus, it maybe slow to respond if it has to wait for a long background operation.
I looked at code, and it should not crash on this error state...
We need to reproduce this locally.
Cc: alemate@chromium.org
Owner: ----
Status: Available (was: Assigned)
Rahul, could you assign this to someone with EVE? I cannot reproduce it right now.

Comment 10 by cindyb@google.com, May 24 2018

Has the scope of the issue narrowed? Should it still be labeled as RBS?

Comment 11 by r...@chromium.org, May 24 2018

Cc: zalcorn@chromium.org
Owner: wzang@chromium.org
Status: Assigned (was: Available)
Colin could you look at this?
I'll let Zach determine if this should be RBS or not.

Have we been able to reproduce it? 
Have we seen more than one report?
If this is a one-off that we can't replicate, it shouldn't be RBS.

Comment 13 by wzang@chromium.org, May 24 2018

Status: Started (was: Assigned)
I'm taking a look.

Comment 14 by wzang@chromium.org, May 25 2018

I can repro locally. There is a WIP fix: https://chromium-review.googlesource.com/c/chromium/src/+/1072718 following apronin@'s suggestion.
Thanks for reconsidering the RBS in #12.  Assume it's still RBS per #14.  Please escalate attention / fix/ merge since stable is approaching.
Project Member

Comment 16 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a374af14a9813c83f766d6d8ab2215e879bcca5

commit 9a374af14a9813c83f766d6d8ab2215e879bcca5
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue May 29 22:53:19 2018

cros: Wait for cryptohome D-bus service in AutoEnrollmentController

The code is run during early stage of the first boot, it is possible
that cryptohomed hasn't yet registered on dbus at that point. So it
should wait for the service to be available. An example of this pattern
can be found in install_attributes.cc.

Bug:  841627 
Change-Id: I87125bc68bfbaec2b9468af7d22f7a4f4508f03d
Reviewed-on: https://chromium-review.googlesource.com/1072718
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562640}
[modify] https://crrev.com/9a374af14a9813c83f766d6d8ab2215e879bcca5/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc
[modify] https://crrev.com/9a374af14a9813c83f766d6d8ab2215e879bcca5/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.h

Comment 17 by wzang@chromium.org, May 29 2018

Labels: Merge-Request-67 Merge-Request-68
Status: Fixed (was: Started)
Requesting merge to M67 and M68. mkarkada@, please verify the issue is fixed in latest M69 Canary.
Project Member

Comment 18 by sheriffbot@chromium.org, May 29 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Merge approval is pending the testing called out in #17.  Thx
Project Member

Comment 20 by sheriffbot@chromium.org, May 30 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Verified (was: Fixed)
I'm not seeing any chrome crash at Google Chrome TOS screen on M69 (10739.0.0	69.0.3445.0) eve device. Fix can be merged to M67.
Project Member

Comment 22 by sheriffbot@chromium.org, Jun 4 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-67 Merge-Approved-67
Approving merge to M67 Chrome OS.

Project Member

Comment 24 by bugdroid1@chromium.org, Jun 4 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77c66bb905776f98ce8adeb225eb79f5bc849755

commit 77c66bb905776f98ce8adeb225eb79f5bc849755
Author: Wenzhao Zang <wzang@chromium.org>
Date: Mon Jun 04 19:44:21 2018

[Merge to M67] cros: Wait for cryptohome D-bus service in AutoEnrollmentController

The code is run during early stage of the first boot, it is possible
that cryptohomed hasn't yet registered on dbus at that point. So it
should wait for the service to be available. An example of this pattern
can be found in install_attributes.cc.

TBR=wzang@chromium.org

(cherry picked from commit 9a374af14a9813c83f766d6d8ab2215e879bcca5)

Bug:  841627 
Change-Id: I87125bc68bfbaec2b9468af7d22f7a4f4508f03d
Reviewed-on: https://chromium-review.googlesource.com/1072718
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562640}
Reviewed-on: https://chromium-review.googlesource.com/1085902
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#738}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/77c66bb905776f98ce8adeb225eb79f5bc849755/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc
[modify] https://crrev.com/77c66bb905776f98ce8adeb225eb79f5bc849755/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.h

Project Member

Comment 25 by bugdroid1@chromium.org, Jun 4 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fd18617b25ebdb0ee6637b993858b6dfe17b3c1

commit 5fd18617b25ebdb0ee6637b993858b6dfe17b3c1
Author: Wenzhao Zang <wzang@chromium.org>
Date: Mon Jun 04 19:46:15 2018

[Merge to M68] cros: Wait for cryptohome D-bus service in AutoEnrollmentController

The code is run during early stage of the first boot, it is possible
that cryptohomed hasn't yet registered on dbus at that point. So it
should wait for the service to be available. An example of this pattern
can be found in install_attributes.cc.

TBR=wzang@chromium.org

(cherry picked from commit 9a374af14a9813c83f766d6d8ab2215e879bcca5)

Bug:  841627 
Change-Id: I87125bc68bfbaec2b9468af7d22f7a4f4508f03d
Reviewed-on: https://chromium-review.googlesource.com/1072718
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562640}
Reviewed-on: https://chromium-review.googlesource.com/1085904
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#158}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/5fd18617b25ebdb0ee6637b993858b6dfe17b3c1/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc
[modify] https://crrev.com/5fd18617b25ebdb0ee6637b993858b6dfe17b3c1/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.h

Sign in to add a comment