Remove logging for WebView variations test experiment |
|||
Issue descriptionWe're logging info about the "First-WebView-Experiment" variations experiment to logcat for QA purposes. We should remove this after WebView variations has launched.
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2124d1a897ce682f2db8a04e6aa7f5ecb41e0cc commit f2124d1a897ce682f2db8a04e6aa7f5ecb41e0cc Author: Paul Miller <paulmiller@chromium.org> Date: Thu Aug 02 22:24:04 2018 Revert "WebView: Report test experiment via logcat" This reverts commit f8f05d0623a280b02b980aaf622c30713fa98d87. Variations has launched, so this log is no longer needed. Original change's description: > WebView: Report test experiment via logcat > > This is for testing purposes and will be removed after launching > variations in WebView: https://crbug.com/841623 . Skipping presubmit for > LOG(INFO). > > BUG=678288 > NOPRESUBMIT=true > > Change-Id: Ia100eb88a20b3155ef8d280e598644b3684990a0 > Reviewed-on: https://chromium-review.googlesource.com/1053375 > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Paul Miller <paulmiller@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557593} TBR=boliu@chromium.org,changwan@chromium.org,paulmiller@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 841623 Change-Id: Ia9259943b4b7896de98e917e29721ec5126aa00a Reviewed-on: https://chromium-review.googlesource.com/1161024 Reviewed-by: Paul Miller <paulmiller@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580350} [modify] https://crrev.com/f2124d1a897ce682f2db8a04e6aa7f5ecb41e0cc/android_webview/browser/aw_field_trial_creator.cc
,
Aug 2
,
Aug 6
paulmiller@, do we have the manual verificaiton for this bug? thanks
,
Aug 6
I don't think it's important to verify since it just removes a log message but if you want you can start WebView a few times and make sure "First-WebView-Experiment" doesn't appear in logcat. So `adb logcat | grep First-WebView-Experiment` shouldn't show anything.
,
Aug 15
Run the adb logcat | grep First-WebView-Experiment comment don't show anythings marking verified/fixed asus/WW_Z00A/Z00A:5.0/LRX21V// 69.0.3497.41
,
Aug 16
|
|||
►
Sign in to add a comment |
|||
Comment 1 by paulmiller@chromium.org
, May 10 2018