New issue
Advanced search Search tips

Issue 841615 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Rename iTunesLinksHandler to iTunesUrlsHandler

Project Member Reported by mrefaat@chromium.org, May 9 2018

Issue description

ITunesLinksHandler was the original name for the feature / the itunes_links directory was there and it had some observers, so that's why we stuck with the name.

Change the name to iTunesURLHandler is more meaningful.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/390f99c0db4422ec1550e4a40599335f9eef4291

commit 390f99c0db4422ec1550e4a40599335f9eef4291
Author: mrefaat <mrefaat@chromium.org>
Date: Thu May 10 19:44:24 2018

Rename iTunesLinksHandlerTabHelper to ITunesUrlsHandlerTabHelper

It's more appropriate as the tabhelper handle urls not links.

Bug:  841615 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7f852766712545574a1d07eeaa21e871f064a97a
Reviewed-on: https://chromium-review.googlesource.com/1053359
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557630}
[modify] https://crrev.com/390f99c0db4422ec1550e4a40599335f9eef4291/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/390f99c0db4422ec1550e4a40599335f9eef4291/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/390f99c0db4422ec1550e4a40599335f9eef4291/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/390f99c0db4422ec1550e4a40599335f9eef4291/ios/chrome/browser/ios_chrome_flag_descriptions.h
[delete] https://crrev.com/36d9cd71bcc8cd5098a1410b89f00e5dc76ef78f/ios/chrome/browser/itunes_links/OWNERS
[delete] https://crrev.com/36d9cd71bcc8cd5098a1410b89f00e5dc76ef78f/ios/chrome/browser/itunes_links/itunes_links_flag.h
[delete] https://crrev.com/36d9cd71bcc8cd5098a1410b89f00e5dc76ef78f/ios/chrome/browser/itunes_links/itunes_links_flag.mm
[rename] https://crrev.com/390f99c0db4422ec1550e4a40599335f9eef4291/ios/chrome/browser/itunes_urls/BUILD.gn
[add] https://crrev.com/390f99c0db4422ec1550e4a40599335f9eef4291/ios/chrome/browser/itunes_urls/OWNERS
[add] https://crrev.com/390f99c0db4422ec1550e4a40599335f9eef4291/ios/chrome/browser/itunes_urls/itunes_urls_flag.h
[add] https://crrev.com/390f99c0db4422ec1550e4a40599335f9eef4291/ios/chrome/browser/itunes_urls/itunes_urls_flag.mm
[rename] https://crrev.com/390f99c0db4422ec1550e4a40599335f9eef4291/ios/chrome/browser/itunes_urls/itunes_urls_handler_tab_helper.h
[rename] https://crrev.com/390f99c0db4422ec1550e4a40599335f9eef4291/ios/chrome/browser/itunes_urls/itunes_urls_handler_tab_helper.mm
[rename] https://crrev.com/390f99c0db4422ec1550e4a40599335f9eef4291/ios/chrome/browser/itunes_urls/itunes_urls_handler_tab_helper_unittest.mm
[modify] https://crrev.com/390f99c0db4422ec1550e4a40599335f9eef4291/ios/chrome/browser/tabs/BUILD.gn
[modify] https://crrev.com/390f99c0db4422ec1550e4a40599335f9eef4291/ios/chrome/browser/tabs/tab_helper_util.mm
[modify] https://crrev.com/390f99c0db4422ec1550e4a40599335f9eef4291/ios/chrome/test/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment