garcon: add rate limiting for URL handling |
||||
Issue descriptionWe recently encountered a bug where the browser (in our case: garcon's url handler) was being invoked in an infinite loop, effectively DoS'ing Chrome. At a minimum I think garcon url's handler should be rate limited, and maybe other garcon functionality.
,
May 10 2018
,
May 18 2018
,
May 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/31caa2eb0dd6ded6f10f7a76349bbc1a6c270c6a commit 31caa2eb0dd6ded6f10f7a76349bbc1a6c270c6a Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Sat May 19 21:03:22 2018 vm_tools: Add rate limiting for OpenUrl call This uses a fixed window rate limiting approach where the window timer is reset when a request is received that is out of the current window. A counter is increased each time a request is received while still in that window and if we exceed our limit we start rejecting requests. BUG= chromium:841610 TEST=Verified with manual testing Change-Id: Ic7530c34b0140284d01864718bbfffc342ce99a3 Reviewed-on: https://chromium-review.googlesource.com/1065116 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/31caa2eb0dd6ded6f10f7a76349bbc1a6c270c6a/vm_tools/concierge/container_listener_impl.cc [modify] https://crrev.com/31caa2eb0dd6ded6f10f7a76349bbc1a6c270c6a/vm_tools/concierge/container_listener_impl.h
,
May 21 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jkardatzke@chromium.org
, May 9 2018Status: Assigned (was: Untriaged)