Chrome 2D Keyboard after Recent Tabs used |
||
Issue descriptionChrome Version: 68.0.3425.0 also on 67 beta. OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? 1) Close all tabs 2) NTP 3) Show "Recent tabs" 4) Enter VR Browsing 5) Go to page with controls 6) Trigger 2D UI keyboard What is the expected result? Expect the VR 2D UI keyboard to be shown. What happens instead? The Chrome 2D keyboard is overlaid on display.
,
May 14 2018
The problem is that navigate to a new page from "recent tabs" page changes the web_content which associated with current tab. When that happened, we should update the ImeAdapter which associated with the new web content and restore the ImeAdapter of the old web content. We currently don't do that. So the 2D keyboard shows up. I need a little bit more time to figure out the relationship of tab and webcontent and tab switching. should have a CL to fix it soon.
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87a5c00489d3998a99f923388295b632eefd3c50 commit 87a5c00489d3998a99f923388295b632eefd3c50 Author: Biao She <bshe@chromium.org> Date: Tue May 15 16:40:41 2018 Fix 2D virtual keyboard shows up after navigate from recent tabs in VR This CL makes sure that a VR version ImeAdapter is used when WebContent for current tab swapped. Bug: 841607 Change-Id: I751221684c17101ae80c4ebeff5684f5f5b7f8c5 Reviewed-on: https://chromium-review.googlesource.com/1057827 Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#558745} [modify] https://crrev.com/87a5c00489d3998a99f923388295b632eefd3c50/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/274d58bc9d2743c49d0edd23c084d82e3e244315 commit 274d58bc9d2743c49d0edd23c084d82e3e244315 Author: Biao She <bshe@chromium.org> Date: Wed May 23 23:30:20 2018 Hide voice search button in VR if RecognizerIntent can't be resolved Bug: 841607 Change-Id: I936202dcf3b01459e7914f237b22d8c0e5b09137 Reviewed-on: https://chromium-review.googlesource.com/1070544 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#561309} [modify] https://crrev.com/274d58bc9d2743c49d0edd23c084d82e3e244315/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
May 24 2018
The commit in #4 is not intented for this issue. I made a mistake. It is intended for Issue 842322. commit in #3 should have fixed this issue. So mark it as closed. |
||
►
Sign in to add a comment |
||
Comment 1 by yfried...@chromium.org
, May 10 2018Labels: -Pri-3 M-68 Hotlist-MVP-VRB-Next Pri-1
Owner: bshe@chromium.org
Status: Assigned (was: Untriaged)