New issue
Advanced search Search tips

Issue 841602 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

PrintContextFrameTest.SubframePrintPageLayout fails without a root scroller

Project Member Reported by bokan@chromium.org, May 9 2018

Issue description

This test passes currently because the iframe happens to be the right size that the unshipped "implicit root scroller" experiment gets activated and causes the iframe not to resize when printing is entered. However, if the experiment is disabled (and thus, we use a real-world setup), this test fails the second check:

  EXPECT_EQ(child->OffsetWidth(), 800);

Expected: 800
Actual: 440
 

Comment 1 by bokan@chromium.org, May 9 2018

Owner: weili@chromium.org
Status: Assigned (was: Untriaged)
Please triage as necessary
Project Member

Comment 2 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67a4547441d203e57614e1c6ee1d614ca42eaf96

commit 67a4547441d203e57614e1c6ee1d614ca42eaf96
Author: David Bokan <bokan@chromium.org>
Date: Tue May 15 20:34:45 2018

Disable SubframePrintPageLayout unit test

This test passes today by accident of the fact that the iframe is the
exact size necessary to be promoted to the root scroller. This indicates
the test is failing in a realistic environment since the root scroller
promition isn't yet shipped.

Bug: 841602
Change-Id: I10c68e7f2f0d3c2d00536d278f7f6ed6d5978ba0
Reviewed-on: https://chromium-review.googlesource.com/1053350
Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558825}
[modify] https://crrev.com/67a4547441d203e57614e1c6ee1d614ca42eaf96/third_party/blink/renderer/core/page/print_context_test.cc

Sign in to add a comment