New issue
Advanced search Search tips

Issue 841599 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Close builder migration issues for builders that no longer exist

Project Member Reported by estaab@chromium.org, May 9 2018

Issue description

I believe it's the case that if a buildbot builder is deleted or renamed the migration app will lose track of the issue it filed (please correct me if I'm wrong). Those issues likely still have the tracking labels used in the builder sets burndown graphs.

We should figure out what issues are obsolete and close them to make sure our current counts are accurate.
 
(if this is particularly easy for anyone please go ahead and self-assign this issue, thanks!)

Comment 2 by no...@chromium.org, May 10 2018

Status: Fixed (was: Available)
https://chromium-review.googlesource.com/c/infra/infra/+/1053409 fixed it

Comment 3 by estaab@chromium.org, May 10 2018

Owner: no...@chromium.org
Status: Assigned (was: Fixed)
I think that addresses a different problem than what I'm asking about.

In particular, what happens if the migration app files a bug for a builder that exists on buildbot, then the builder is renamed or deleted on buildbot? What happens to the initial bug that was filed? The migration app doesn't close any bugs so can't we have some bugs open that don't correspond to any active builders?

Comment 4 by no...@chromium.org, May 10 2018

yes, the CL addressed a different problem, but incidentally it fixed this problem

If the builder is renamed, it is not longer present in the GetCompressedMasterJSON response, so app closes the bug. Same happens in builder is removed. The app closed bug 841082 today because this builder does not exist on buildbot https://ci.chromium.org/buildbot/chromium.android/android-kitkat-arm-rel/

If a bug is already fixed (e.g. by a human), the app's new comment with status=Fixed won't changed the status. It would, though, if a human set it to Verified, which would be a bit confusing.


Comment 5 by estaab@chromium.org, May 10 2018

Status: Fixed (was: Assigned)
Ah, ok. I was under the impression the migration app didn't close bugs anymore but I was mistaken. Thanks for fixing this!

Sign in to add a comment