New issue
Advanced search Search tips

Issue 841598 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Jul 31
Cc:
cl...@chromium.org
twelling...@chromium.org
mdjones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

BottomSheet should animate closed in any case requests are cleared

Project Member Reported by mdjones@chromium.org, May 9 2018 
Because of crbug.com/834923 animations when the bottom sheet is cleared have been removed in favor of the sheet popping out of existence. We should correctly handle the existing race and animate the sheet closed in these cases (switch tabs, navigate, or switch tab models).

Comment 1 by twelling...@chromium.org, May 9 2018

Labels: Hotlist-EoC-MVP Q2 O-EoC-Launch medium KR-Implementation-Complete

Comment 2 by twelling...@chromium.org, May 9 2018

Components: UI>Browser>Mobile>NavPanel
Adding the "NavPanel" component since the work entailed is actually in the bottom sheet widget rather than EoC specifically.

Comment 3 by fgor...@chromium.org, Jul 30

Labels: -Q2 -Hotlist-EoC-MVP -O-EoC-Launch -KR-Implementation-Complete Q3 O-EoC-Experiment KR-Omnibox-Entry-Point
Moving to Q3.
Is this still needed?

Comment 4 by twelling...@chromium.org, Jul 31 

No, I don't think so. The code in the original CL to disable animations when requests are cleared looks like it's been removed.

Matt, will you please confirm?

Comment 5 by mdjones@chromium.org, Jul 31

Status: Fixed (was: Available)
Yeah, this was actually fixed via "mFullShowRequestedSet" here: https://chromium-review.googlesource.com/c/chromium/src/+/996383

Comment 6 by twelling...@chromium.org, Aug 7

Labels: -medium -Q3 -O-EoC-Experiment -KR-Omnibox-Entry-Point
►

Sign in to add a comment