New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841596 link

Starred by 3 users
Status: Verified
Owner:
chanli@chromium.org
Closed: May 2018
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----

Blocking:
issue 846447



Sign in to add a comment

Findit hit too many 429s for request to Gitiles

Project Member Reported by st...@chromium.org, May 9 2018 
We need to pull change logs from Gitiles for our analysis.
However, there is a QPS quota for Findit app.

We are hitting too many 429s due to over quota.
https://screenshot.googleplex.com/RQvnFJMMYU9.png

This will stop Findit from both analysis and auto-action.

On low-hanging fruit is to pull change logs by a revision range by a single http request instead of pulling one change log per commit in many requests.

There might be other problems that we should explore.
Project Member

Comment 3 by bugdroid1@chromium.org, May 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3489d5d351e1749f7eee53f03bb988ecb4818404

commit 3489d5d351e1749f7eee53f03bb988ecb4818404
Author: Chan <chanli@chromium.org>
Date: Sat May 12 00:47:19 2018

[Findit] Use range query instead of individual queries when get change logs in regression range.

Before Findit queries change log for each revision separately.

For example it pulls change logs for each revision in failure_info.builds.blame_list. This change uses range query instead to reduce number of requests we send to gitiles.

Bug:  841596 

Change-Id: If65f3ca8286b26acfb1cf1591b34c0ebf16609a1
Reviewed-on: https://chromium-review.googlesource.com/1053993
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/3489d5d351e1749f7eee53f03bb988ecb4818404/appengine/findit/services/compile_failure/compile_failure_analysis.py
[modify] https://crrev.com/3489d5d351e1749f7eee53f03bb988ecb4818404/appengine/findit/services/ci_failure.py
[modify] https://crrev.com/3489d5d351e1749f7eee53f03bb988ecb4818404/appengine/findit/services/build_failure_analysis.py
[modify] https://crrev.com/3489d5d351e1749f7eee53f03bb988ecb4818404/appengine/findit/services/deps.py
[modify] https://crrev.com/3489d5d351e1749f7eee53f03bb988ecb4818404/appengine/findit/services/test_failure/test_failure_analysis.py
[modify] https://crrev.com/3489d5d351e1749f7eee53f03bb988ecb4818404/appengine/findit/services/git.py
[modify] https://crrev.com/3489d5d351e1749f7eee53f03bb988ecb4818404/appengine/findit/services/test/build_failure_analysis_test.py
[modify] https://crrev.com/3489d5d351e1749f7eee53f03bb988ecb4818404/appengine/findit/services/compile_failure/test/compile_failure_analysis_test.py
[modify] https://crrev.com/3489d5d351e1749f7eee53f03bb988ecb4818404/appengine/findit/services/test/ci_failure_test.py
[modify] https://crrev.com/3489d5d351e1749f7eee53f03bb988ecb4818404/appengine/findit/services/test/deps_test.py
[modify] https://crrev.com/3489d5d351e1749f7eee53f03bb988ecb4818404/appengine/findit/services/test/git_test.py
[modify] https://crrev.com/3489d5d351e1749f7eee53f03bb988ecb4818404/appengine/findit/services/test_failure/test/test_failure_analysis_test.py

Comment 4 by chanli@chromium.org, May 24 2018

Blocking: 846447
Status: Verified (was: Assigned)

Comment 5 by chanli@chromium.org, May 24 2018 

 Issue 804523  has been merged into this issue.
►

Sign in to add a comment