New issue
Advanced search Search tips

Issue 841595 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

FullscreenManager#onToggleOverlayVideoMode is not being called in BottomSheet

Project Member Reported by mdjones@chromium.org, May 9 2018

Issue description

This may be a more general issue with the event, but the onToggleOverlayVideoMode event is not being triggered in the bottom sheet.
 
Cc: peconn@chromium.org tedc...@chromium.org
ccing folks who might know of work that was done:

+peconn as I recall he was doing video related things in the past.
+tedchoc since this is a fullscreen manager issue.
Components: UI>Browser>Mobile>NavPanel
This is causing an issue where tapping on the bottom sheet at the same time a video is fullscreened results in the sheet being opened on top of the video. Not a very severe bug, but a bug none the less.
Cc: mlamouri@chromium.org
+mlamouri

Are you saying that onToggleOverlayVideoMode isn't called at all or just not in the bottom sheet?  I don't know what triggers that signal and whether the changes to the video stack make it still relevant.

I wonder if there is a different signal we should use when you enter fullscreen.  I'm not sure there is an observable method when the fullscreen web api is triggered to be honest.  Maybe hasEffectivelyFullscreenVideoChange on WebContentsObserver?

Comment 4 by peconn@chromium.org, May 10 2018

hasEffectivelyFullscreenVideoChange (and hasActiveEffectivelyFullscreenVideo) rely on a heuristic so aren't triggered immediately when a video goes to fullscreen. They may not be the best place to put that logic. mlamouri@ may have more information.
I can't seem to get onToggleOverlayVideoMode called at all. I'd expect this to be triggered for sites like youtube and bbc when viewing fullscreen videos, I may be mistaken though.

Sign in to add a comment