(relates to email with subject "Rich Answer icons/images").

Dave, for the rich answers that we don't have icons yet for, but that we plan to be the blue circle with white logo, maybe you can just throw a blue circle in so that we can see what it will look like?

I keep forgetting to bring this up, but we need something for knowledge answers (e.g. [how old is dwayne johnson]), also. Or maybe just the Google icon?

I think we should have a generic mono chrome "G" as a default/fallback where we don't have defined icons for. Ill make sure I add in my new asset drop. Redrawing 16px @1x specific icons for clarity. 

New svg assets here...I did a custom draw of the @1x/16px icons and set of @2x/32px:
https://drive.google.com/drive/folders/18FUVv56qBE8SvoaBPvVDVB0yoOP272i-?usp=sharing

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4da2d553b5a4006498986991c928c60ce867fe21

commit 4da2d553b5a4006498986991c928c60ce867fe21
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Sat Jun 09 02:42:13 2018

[Omnibox] New answer layout images/icons

This CL adds vector icons for some answers in suggest. These images are
not final. They are used behind a feature flag. The intention is to get
Canary review by UX/PM before finalizing the images.

Bug:  841594 
Change-Id: I52fe73ec904bfed9a26def2351626ab3e35c8407
Reviewed-on: https://chromium-review.googlesource.com/1087757
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565827}
[modify] https://crrev.com/4da2d553b5a4006498986991c928c60ce867fe21/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
[modify] https://crrev.com/4da2d553b5a4006498986991c928c60ce867fe21/components/omnibox/browser/BUILD.gn
[modify] https://crrev.com/4da2d553b5a4006498986991c928c60ce867fe21/components/omnibox/browser/suggestion_answer.h
[add] https://crrev.com/4da2d553b5a4006498986991c928c60ce867fe21/components/omnibox/browser/vector_icons/answer_currency.icon
[add] https://crrev.com/4da2d553b5a4006498986991c928c60ce867fe21/components/omnibox/browser/vector_icons/answer_dictionary.icon
[add] https://crrev.com/4da2d553b5a4006498986991c928c60ce867fe21/components/omnibox/browser/vector_icons/answer_finance.icon
[add] https://crrev.com/4da2d553b5a4006498986991c928c60ce867fe21/components/omnibox/browser/vector_icons/answer_sunrise.icon
[add] https://crrev.com/4da2d553b5a4006498986991c928c60ce867fe21/components/omnibox/browser/vector_icons/answer_when_is.icon

icons were added for 
- definition (dictionary)
- sunrise/sunset (sunrise)
- stock (finance)
- calendar (when_is)
- currency

These icons should be handled (because we currently get results/suggestions for them):
- calculator
- translate


But these don't seem to generate results/suggestions (so is there a current need for icons):
- time
- food/dining

#7, the new icons are in https://chromium-review.googlesource.com/c/chromium/src/+/1102105

Updating this comment to include #5 and #6.
Each row has the name we've been using (the icon name in parenthesis) "a quoted search string example".


icons were added for:
[These are done]
- definition      (dictionary) "define set point"
- sunrise/sunset  (sunrise)    "sunrise in los angeles"
- stock           (finance)    "abc stock price"
- calendar        (when_is)    "when is <holiday>"
- currency        (currency)   "33 dollars in British pounds"


These icons should be handled (because we currently get results/suggestions for them):
[These might get a generic "G" icon, they are not done, we need icons]
- calculator            (?) "3+5"
- knowledge answers     (?) "how old is <person>"
- translate             (?) "hello in Japanese"
- generic monochrome G  (?)


But these don't seem to generate results/suggestions (so is there a current need for icons):
[These won't be in m69 (because there are no related suggest results)]
- time         (?) "<unknown>"
- food/dining  (?) "<unknown>"

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee414c94a51c942b37b765ba2848e8145e11561d

commit ee414c94a51c942b37b765ba2848e8145e11561d
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Fri Jun 15 14:36:12 2018

[Omnibox] Update answer icons to sharper 16px SVGs

This CL updates the vector icons for several Answers in Suggest (AiS)
icons.

Bug:  841594 
Change-Id: Id4464de95bdbaf02d9f8fc48d17868acedb2e594
Reviewed-on: https://chromium-review.googlesource.com/1102105
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567643}
[modify] https://crrev.com/ee414c94a51c942b37b765ba2848e8145e11561d/components/omnibox/browser/vector_icons/answer_dictionary.icon
[modify] https://crrev.com/ee414c94a51c942b37b765ba2848e8145e11561d/components/omnibox/browser/vector_icons/answer_finance.icon
[modify] https://crrev.com/ee414c94a51c942b37b765ba2848e8145e11561d/components/omnibox/browser/vector_icons/answer_sunrise.icon
[modify] https://crrev.com/ee414c94a51c942b37b765ba2848e8145e11561d/components/omnibox/browser/vector_icons/answer_when_is.icon

Tested this issue on Windows 10, Mac OS 10.13.5 and Ubuntu 14.04 on the latest M-69 69.0.3464.0 build by following the below steps.

1. Launched Chrome and enabled the flag #omnibox-new-answer-layout.
2. Entered the search strings mentioned in comment #12 and answers are shown in the suggestion list, but icons are missing for few search strings.
Attached is the screen cast for reference.

Note: Couldn't get the icon with answer type for "33 dollars in British pounds".

dschuyler@ Request you to please check and confirm if anything is missed from our end in verifying the issue?

Thanks..

Deleted: 841594-M69.mp4 4.0 MB

	841594-M69.mp4 4.0 MB View Download

This is great. Testing this out today. 


Realizing now these missing assets below never made it into my export (obviously). Im exporting now and will get to you today. 

- calculator           
- knowledge answers     
- translate             
- generic monochrome G

Calculator/Translate @1x here:
https://drive.google.com/file/d/1Kj9avAxskX_9_5EJoUQjVIkkGBEZm74S/view?usp=sharing
https://drive.google.com/file/d/1bMaEh8ZAPtcxPvFBEYsanmWNwrB_ogUp/view?usp=sharing


Calculator/Translate @2x here:
https://drive.google.com/file/d/1TmC6FbZ8GpCALQDwoNyJpPWcGfp001Wa/view?usp=sharing
https://drive.google.com/file/d/1pMe0zFXJG-R1n4y7g75d-hBGkCif4QmB/view?usp=sharing

Knowledge and Generic G are both this asset:
@1x: https://drive.google.com/file/d/1aZFj4xXOux4HS2jSfu4vR1yM9ralmGge/view?usp=sharing
@2x: https://drive.google.com/file/d/1XDCxRmaDRJlQVnlEg8JpykY8M75Mn5zS/view?usp=sharing



Also from our chat...

conversion_16px.svg: is for conversions (money, weight, volume, etc)
time_16px: is for any "time in tokyo..." queries or related answers we might get back around time. 

FYI, regarding #15. It looks like those icons won't be used for now.

- "money" conversions have the type "finance" (e.g. "33 dollars in British pounds")
- "weight or volume" conversions have the type calculator (e.g. "4.5 oz in cups")
- "time" conversions are not (afaik) active on desktop

To use them (in the future) the back-end (gws and/or complete server) will need to send the client discernible responses.

Updating this comment to include #5 and #6.
Each row has the name we've been using (the icon name in parenthesis) "a quoted search string example".


icons were added for:
[These are done]
- definition      (dictionary) "define set point"
- sunrise/sunset  (sunrise)    "sunrise in los angeles"
- stock           (finance)    "abc stock price"
- calendar        (when_is)    "when is <holiday>"
- currency        (currency)   "33 dollars in British pounds"
- knowledge answers     (mono-G) "how old is <person>"
- translate             (translation) "hello in Japanese"
- generic monochrome G  (mono-G)


These icons should be handled (because we currently get results/suggestions for them):
- calculator            (?) "3+5" There's a CL at https://chromium-review.googlesource.com/c/chromium/src/+/1111460


But these don't seem to generate results/suggestions (so is there a current need for icons):
[These won't be in m69 (because there are no related suggest results)]
- conversions  (?) "<unknown>" these appear to be blended with other types (currency/calculator)
- time         (?) "<unknown>"
- food/dining  (?) "<unknown>"


When the CL at 1111460 lands, I plan to mark this fixed.

I'm going to take this over because, while all the answer types have an icon now, there's still an issue with the sizing of the icons that bklmn and I are going to iterate on.

I just noticed that orinj did some similar work on icon sizing in https://crrev.com/c/1112643.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/544d7d11d782b053a2978b8a1cc89bbdc6a3144d

commit 544d7d11d782b053a2978b8a1cc89bbdc6a3144d
Author: Orin Jaworski <orinj@chromium.org>
Date: Tue Jul 10 19:38:05 2018

[omnibox] Change render size and technique for answer icons

Answer icons were being rendered using an odd/even technique
with a circle of diameter 24, but the internal icons were not
properly sized.  Now the icons are kept intact with the original
design size of 16, and the circle is rendered manually.

Bug:  841594 
Change-Id: I5d31e43c4c0bdb70f6fe7dcbb85228a268d73571
Reviewed-on: https://chromium-review.googlesource.com/1130350
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573860}
[modify] https://crrev.com/544d7d11d782b053a2978b8a1cc89bbdc6a3144d/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
[modify] https://crrev.com/544d7d11d782b053a2978b8a1cc89bbdc6a3144d/components/omnibox/browser/vector_icons/answer_currency.icon
[modify] https://crrev.com/544d7d11d782b053a2978b8a1cc89bbdc6a3144d/components/omnibox/browser/vector_icons/answer_default.icon
[modify] https://crrev.com/544d7d11d782b053a2978b8a1cc89bbdc6a3144d/components/omnibox/browser/vector_icons/answer_dictionary.icon
[modify] https://crrev.com/544d7d11d782b053a2978b8a1cc89bbdc6a3144d/components/omnibox/browser/vector_icons/answer_finance.icon
[modify] https://crrev.com/544d7d11d782b053a2978b8a1cc89bbdc6a3144d/components/omnibox/browser/vector_icons/answer_sunrise.icon
[modify] https://crrev.com/544d7d11d782b053a2978b8a1cc89bbdc6a3144d/components/omnibox/browser/vector_icons/answer_when_is.icon

Is there more to do here or can we mark this Fixed?

This should be it.  If there's anything else, bklmn@ will let me know and we can re-open.

Tested this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 14.04 on the latest M-69 69.0.3488.0 build by following the below steps.

1. Launched Chrome and enabled the flag #omnibox-new-answer-layout.
2. Entered the search strings mentioned in comment #17 and answers are shown in the suggestion list along with the icons on Windows and Ubuntu 14.04. But the icons are not seen on Mac OS 10.13.3.
Attached is the screen casts of Windows/Linux and Mac OS behaviors.

orinj@ Request you to please check and confirm if anything is missed from our end in verifying the issue?

Thanks..

Deleted: 841594-Mac.mp4 2.4 MB

	841594-Mac.mp4 2.4 MB View Download

Deleted: 841594-Windows.mp4 4.8 MB

	841594-Windows.mp4 4.8 MB View Download

Yes, what seems to be missing is the same as in https://bugs.chromium.org/p/chromium/issues/detail?id=855723#c11  --  I don't know why your Mac version appears and behaves so differently from Windows.  Shouldn't the tabs look rounded?  Is Refresh turned on?  Try enabling the upcoming UI features flag: it affects several other flags.

I just got a hint from today's news: https://www.engadget.com/2018/07/11/googles-refreshed-chrome-design-is-nearly-here/

It says the new Material Design is enabled by default on Windows canary but is still behind the flag on Mac.  So try enabling chrome://flags/#upcoming-ui-features.