New issue
Advanced search Search tips

Issue 841592 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in IntToSmi<31>

Project Member Reported by ClusterFuzz, May 9 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6460666295353344

Fuzzer: v8_builtins_generator
Job Type: linux_ubsan_vptr_d8
Platform Id: linux

Crash Type: UNKNOWN WRITE
Crash Address: 0x3eaac0a052b8
Crash State:
  IntToSmi<31>
  IntToSmi
  IntToSmi
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_d8&range=53095:53096

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6460666295353344

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 9 2018

Components: Blink>JavaScript>API
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 9 2018

Labels: Test-Predator-Auto-Owner
Owner: delph...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/9d5aea8dc4d185f2a18bfadc5bebd80f33f4dc5e (Reland "[heap] Move even more objects into RO_SPACE").

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Simpler repro with explanation:

// a has packed SMI elements
a = [];

// a has dictionary elements
a.length = 0xFFFFFFF;

// a has dictionary elements and the backing array is slow_element_dictionary (length 0)
a.length = 0;

// a has dictionary elements and the backing array is slow_element_dictionary (length 0xFFFFFFF)
a.length = 0xFFFFFFF;

// This crashes because it attempts to remove 0 elements from slow_empty_dictionary.
a.length = 1;


Removing x elements sets NumberOfElements on HashTable to (NumberOfElements - x), which previously did nothing for x = 0, but is now illegal when slow_empty_dictionary is not writable.
Status: Fixed (was: Assigned)
Fixed in https://chromium-review.googlesource.com/c/v8/v8/+/1052693
Project Member

Comment 5 by sheriffbot@chromium.org, May 10 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 6 by ClusterFuzz, May 11 2018

ClusterFuzz has detected this issue as fixed in range 53115:53116.

Detailed report: https://clusterfuzz.com/testcase?key=6460666295353344

Fuzzer: v8_builtins_generator
Job Type: linux_ubsan_vptr_d8
Platform Id: linux

Crash Type: UNKNOWN WRITE
Crash Address: 0x3eaac0a052b8
Crash State:
  IntToSmi<31>
  IntToSmi
  IntToSmi
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_d8&range=53095:53096
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_d8&range=53115:53116

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6460666295353344

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, May 11 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6460666295353344 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 28

Labels: Pri-1
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 16

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment