[LayoutNG] Scrollbars tracking bug |
|
Issue descriptionLayoutNG scrollbars need work: - scrollbars appearing after layout should trigger relayout. - minmax values are invalidated once scrollbars appear. This invalidation needs to be propagated up the tree. Eventually, scrollbar visibility decisions should be made inside layout. Legacy code does this in PaintLayer.
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a6f4bdd270dddfedf1dcbe6db054dd3dcabf368 commit 5a6f4bdd270dddfedf1dcbe6db054dd3dcabf368 Author: Aleks Totic <atotic@chromium.org> Date: Thu May 31 06:30:36 2018 [LayoutNG] vertical-rl layout overflow should not include scrollbar Legacy vertical-rl coordinates ignore scrollbars. This is wrong, but we have to be Legacy compatible. 1 additional test passes, but it is a good one, tests all writing modes. css3/flexbox/scrollbars.html Bug: 841587 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie3093ceda3b6a1f1855f9e2353df69583e3c8f43 Reviewed-on: https://chromium-review.googlesource.com/1080233 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#563164} [modify] https://crrev.com/5a6f4bdd270dddfedf1dcbe6db054dd3dcabf368/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/5a6f4bdd270dddfedf1dcbe6db054dd3dcabf368/third_party/blink/renderer/core/layout/ng/layout_ng_mixin.cc [modify] https://crrev.com/5a6f4bdd270dddfedf1dcbe6db054dd3dcabf368/third_party/blink/renderer/core/layout/ng/layout_ng_mixin.h
,
Jun 6 2018
Related "Scrollbar related test failures" https://bugs.chromium.org/p/chromium/issues/detail?id=849751#c1
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2bbbf41f520f457a0d0044386a48a5813bbfad5 commit f2bbbf41f520f457a0d0044386a48a5813bbfad5 Author: Aleks Totic <atotic@chromium.org> Date: Thu Jun 14 18:04:04 2018 [LayoutNG] Fix overflow:scroll inline-block painting display:inline-block with text children gets painted as AtomicInline. NGBoxFragmentPainter::PaintAllPhasesAtomically was setting overflow clip for all painting phases, cutting off anything outside content box. It also was not painting scrollbars. Bug: 841587 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iff05c8ba1bed18ae53d679a5b5e81c7f6d409276 Reviewed-on: https://chromium-review.googlesource.com/1099998 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#567344} [modify] https://crrev.com/f2bbbf41f520f457a0d0044386a48a5813bbfad5/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/f2bbbf41f520f457a0d0044386a48a5813bbfad5/third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, May 21 2018