Settings: controlled-radio-button can be keyboard-selected even when controlled by policy. |
|||
Issue descriptionWhen a controlled-radio-button is supposed to be disabled by policy, while it correctly forbids selection via clicking, the user currently can still select the radio button by: 1) focus another radio button in the same group 2) use up/down arrow key to move the selection to the radio button
,
May 9 2018
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/498bc13110a6814ac7a64d9858ac13f381b5fa10 commit 498bc13110a6814ac7a64d9858ac13f381b5fa10 Author: Scott Chen <scottchen@chromium.org> Date: Thu May 10 02:24:19 2018 Settings: fix controlled-radio-button selectable while disabled When a controlled-radio-button is controlled by policy, it should not be selectable. While clicks are correctly blocked, users can still erroneously select it with keyboard navigation. This is fixed by changing the "controlled_" attribute to the standard "disabled" attribute. Bug: 841582 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I40f25379f9fc82b51d93f17587ef8c7d2c864e09 Reviewed-on: https://chromium-review.googlesource.com/1053267 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#557429} [modify] https://crrev.com/498bc13110a6814ac7a64d9858ac13f381b5fa10/chrome/browser/resources/settings/controls/controlled_radio_button.html [modify] https://crrev.com/498bc13110a6814ac7a64d9858ac13f381b5fa10/chrome/browser/resources/settings/controls/controlled_radio_button.js [modify] https://crrev.com/498bc13110a6814ac7a64d9858ac13f381b5fa10/chrome/test/data/webui/settings/controlled_radio_button_tests.js
,
May 10 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by scottchen@chromium.org
, May 9 2018