New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841574 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: Jan 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

InitPerfLog stops fuchsia tests from running

Project Member Reported by stephanstross@google.com, May 9 2018

Issue description

InitPerfLog fails to initialize on fuchsia for *_perftests targets, which prevents the tests from running. Timing data output by GTest reads 0s on all test cases.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0ca00bf269c1fd3ead61300eccceecd253579d1

commit f0ca00bf269c1fd3ead61300eccceecd253579d1
Author: Stephan Stross <stephanstross@google.com>
Date: Mon May 14 20:09:17 2018

Minor Fuchsia-specific fix to base/test/perf_test_suite.cc

Perftest logging on fuchsia is broken. The changed file
manages locating and initializing a log file, specialized
for each platform. Previously, the file failed to
initialize a log file, because there was no fuchsia
specific clause in the Initialize() function, and the
default assumptions don't work on Fuchsia. The OS_ANDROID
clause also works for Fuchsia, so this change adds
it to that code path.

Bug:  841574 
Change-Id: I83f0d424ce9acbb28f904c08d4660f7f7661fa3a
Reviewed-on: https://chromium-review.googlesource.com/1053229
Commit-Queue: Stephan Stross <stephanstross@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558430}
[modify] https://crrev.com/f0ca00bf269c1fd3ead61300eccceecd253579d1/base/test/perf_test_suite.cc

Comment 2 by w...@chromium.org, Jan 20 (2 days ago)

Owner: stephanstross@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment