fast/scrolling tests fail in threaded test suite |
|||||||
Issue descriptionI'm making fast/scrolling use the threaded test suite (https://crrev.com/c/1052823) but this test fails in threaded mode: ./third_party/WebKit/Tools/Scripts/run-webkit-tests -t ChromeDebug virtual/threaded/fast/scrolling/listbox-wheel-event.html
,
May 11 2018
Also overflow-scrollability.html: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/91457 and many others in SPv2 mode: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_layout_tests_slimming_paint_v2/11585
,
May 11 2018
I think shouldBecomeEqual() which uses a timeout is flake-prone and should be avoided. Raising priority because this sometimes blocks CQ.
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60b38cc39a03c049c836a9da943059c7816dfa29 commit 60b38cc39a03c049c836a9da943059c7816dfa29 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri May 11 20:30:32 2018 Skip virtual/threaded/fast/scrolling on SPv2 TBR=wangxianzhu@chromium.org Bug: 841567 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9bca44365295cd5ca2d41175a87f8ef07952dedd Reviewed-on: https://chromium-review.googlesource.com/1055825 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558005} [modify] https://crrev.com/60b38cc39a03c049c836a9da943059c7816dfa29/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
,
May 11 2018
At least virtual/threaded/fast/scrolling/overflow-scrollability.html is very flaky in site_per_process_webkit_layout_tests step: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=site_per_process_webkit_layout_tests%20(with%20patch)&tests=virtual%2Fthreaded%2Ffast%2Fscrolling%2Foverflow-scrollability.html Can we revert https://crrev.com/c/1052823 or disable virtual/threaded/fast/scrolling temporarily before the flakiness is fixed?
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/570bf5182b6a6df00b23d5c468fff8cc93805a89 commit 570bf5182b6a6df00b23d5c468fff8cc93805a89 Author: David Bokan <bokan@chromium.org> Date: Mon May 14 12:42:19 2018 Add flaky expectations for threaded scrolling tests TBR=wangxianzhu@chromium.org Bug: 841567 Change-Id: Ia47fb7c9a988f60f0f5a378338e560b21a26fe38 Reviewed-on: https://chromium-review.googlesource.com/1057348 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558271} [modify] https://crrev.com/570bf5182b6a6df00b23d5c468fff8cc93805a89/third_party/WebKit/LayoutTests/TestExpectations
,
May 14 2018
I've added expectations for all tests that are flaky in the suite. Chao, please make getting those tests to pass consistently part of this bug. Best would be to rewrite them using testharness.js and gpuBenchmarking for scroll gestures. As a hint, the flakiness for threaded tests I've seen mostly comes from gestures being dispatched to the compositor before layer information has gone from Blink to CC's active tree. It's likely many of these just needs 2-3 rAFs before starting a gesture.
,
May 24 2018
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/460c79792ce0fb46817c029ee3b1094c418112f4 commit 460c79792ce0fb46817c029ee3b1094c418112f4 Author: chaopeng <chaopeng@chromium.org> Date: Fri May 25 16:27:40 2018 Convert (absolute/fixed)-position-behind-scrollbar to new style There are 3 changes make in absolute-position-behind-scrollbar: 1. update tests to use testharness.js 2. call rAFs before start input 3. use promise_test and gpuBenchmarking events This should fix the (absolute/fixed)-position-behind-scrollbar.html flaky on virtual/threaded test suites. Bug: 841567, 846424 Change-Id: I3744198054fdf7351ffc769ebfafea11044baf4c Reviewed-on: https://chromium-review.googlesource.com/1072270 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#561904} [delete] https://crrev.com/7c3a331ed75e2a7db08dbbcfc105467c6d030759/third_party/WebKit/LayoutTests/fast/scrolling/absolute-position-behind-scrollbar-expected.txt [modify] https://crrev.com/460c79792ce0fb46817c029ee3b1094c418112f4/third_party/WebKit/LayoutTests/fast/scrolling/absolute-position-behind-scrollbar.html [delete] https://crrev.com/7c3a331ed75e2a7db08dbbcfc105467c6d030759/third_party/WebKit/LayoutTests/fast/scrolling/fixed-position-behind-scrollbar-expected.txt [modify] https://crrev.com/460c79792ce0fb46817c029ee3b1094c418112f4/third_party/WebKit/LayoutTests/fast/scrolling/fixed-position-behind-scrollbar.html [modify] https://crrev.com/460c79792ce0fb46817c029ee3b1094c418112f4/third_party/WebKit/LayoutTests/resources/gesture-util.js
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdfc18f08796d34d36202d52202d5587188477e9 commit bdfc18f08796d34d36202d52202d5587188477e9 Author: chaopeng <chaopeng@chromium.org> Date: Mon May 28 16:55:32 2018 Change gesture_util waitFor for less frames. flakiness_dashboard is using 6s as timeout. Reduce the waitFor frames to 200 will make waitFor timeout to failure which can help us understand the flaky. Bug: 841567 Change-Id: I82c36a48013058088a3b89eb3b1df7ad9809d9d8 Reviewed-on: https://chromium-review.googlesource.com/1075294 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#562281} [modify] https://crrev.com/bdfc18f08796d34d36202d52202d5587188477e9/third_party/WebKit/LayoutTests/resources/gesture-util.js
,
May 29 2018
After I committed the wait for 200 frame CL. Test fail again. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&showAllRuns=true&tests=virtual%2Fthreaded%2Ffast%2Fscrolling
,
May 29 2018
:( Looks like a consistent failure though so should be reproducible locally. Strange since it looks like the test was previously passing very quickly and now hits the time out...
,
May 29 2018
I use `stress` to simulate high cpu load locally then I can reproduce. It seems the flaky is caused by high load on test machine.
,
May 29 2018
The tests green again. And I saw this failed logs on Mac trybots: Received signal #CRASHED - gpu objc[40539]: Class MockCrApp is implemented in both /b/s/w/ir/out/Debug/libtest_runner.dylib and /b/s/w/ir/out/Debug/Content Shell.app/Contents/Frameworks/Content Shell Framework.framework/Versions/C/Content Shell Framework. One of the two will be used. Which one is undefined. [40539:775:0529/121626.570299:WARNING:vt_video_decode_accelerator_mac.cc(194)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "codecOpenErr" (-8973) [40539:775:0529/121626.570765:WARNING:vt_video_decode_accelerator_mac.cc(216)] Hardware decoding with VideoToolbox is not supported [40539:775:0529/121626.627774:ERROR:vt_video_encode_accelerator_mac.cc(516)] VTCompressionSessionCreate failed: -12908 It seems hardware issue.
,
May 29 2018
The mac failures are issue 846693 . The tests turned green without any change on your part? That's strange. I'm still seeing occasional flakes. You said you can repro locally...does turning off SmoothScrolling (via window.internals) help?
,
May 29 2018
Yes, it still flaky in WebKit Linux Trusty (dbg) and Win7 Tests (dbg). And I can not reproduce fail locally now. Let me try turn off SmoothScrolling.
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffa69147099c9c5fee6872bb4e82433ada936bfd commit ffa69147099c9c5fee6872bb4e82433ada936bfd Author: chaopeng <chaopeng@chromium.org> Date: Thu May 31 16:58:38 2018 Convert 3 layout tests to new style In this patch, we converted listbox-wheel-event, same-page-navigate and scrollbar-tickmarks-hittest into new style. 1. update tests to use testharness.js 2. call rAFs before start input 3. use promise_test and gpuBenchmarking events This should fix the tests flaky on virtual/threaded test suites. Bug: 841567 Change-Id: Ia4c7da8d9693222dbaac02191de8aa4b0fce95ff Reviewed-on: https://chromium-review.googlesource.com/1073749 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#563274} [delete] https://crrev.com/7682a8f7db28e76c21fbe5fb426dde16bfbaaddc/third_party/WebKit/LayoutTests/fast/scrolling/listbox-wheel-event-expected.html [modify] https://crrev.com/ffa69147099c9c5fee6872bb4e82433ada936bfd/third_party/WebKit/LayoutTests/fast/scrolling/listbox-wheel-event.html [modify] https://crrev.com/ffa69147099c9c5fee6872bb4e82433ada936bfd/third_party/WebKit/LayoutTests/fast/scrolling/same-page-navigate.html [delete] https://crrev.com/7682a8f7db28e76c21fbe5fb426dde16bfbaaddc/third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-tickmarks-hittest-expected.txt [modify] https://crrev.com/ffa69147099c9c5fee6872bb4e82433ada936bfd/third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-tickmarks-hittest.html [modify] https://crrev.com/ffa69147099c9c5fee6872bb4e82433ada936bfd/third_party/WebKit/LayoutTests/resources/gesture-util.js
,
Jun 2 2018
fast/scrolling/scrollbar-tickmarks-hittest.html is failing consistently on the bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=fast%2Fscrolling%2Fscrollbar-tickmarks-hittest.html
,
Jun 2 2018
Suppressing this failure. There's a previous timeout expectation for this test in Issue 267206 .
,
Jun 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/363d153b234835ab85f648015bf4622677b31bd2 commit 363d153b234835ab85f648015bf4622677b31bd2 Author: Kenneth Russell <kbr@chromium.org> Date: Sat Jun 02 23:04:38 2018 Suppress a few flaky layout tests. Mac: virtual/threaded/animations/responsive/ zoom-responsive-translate-animation.html virtual/threaded/http/tests/devtools/tracing/timeline-paint/ paint-profiler-update.js All platforms: fast/scrolling/scrollbar-tickmarks-hittest.html Tbr: alph@chromium.org Tbr: ericwilligers@chromium.org Tbr: chaopeng@chromium.org Tbr: pdr@chromium.org Bug: 848006 , 849040 , 841567 Change-Id: Ifb356dffc3a149b2e7593bddda21f31df6b1de48 Reviewed-on: https://chromium-review.googlesource.com/1083818 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#563951} [modify] https://crrev.com/363d153b234835ab85f648015bf4622677b31bd2/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 4 2018
It seems something happens in Jun 1-Jun 3. fast/scrolling/scrollbar-tickmarks-hittest.html almost green now. In bdfc18f08796d34d36202d52202d5587188477e9 we also change the known timeout to failure.
,
Jun 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00a72bddc5e5f2882ada86addef3e6a023f24429 commit 00a72bddc5e5f2882ada86addef3e6a023f24429 Author: chaopeng <chaopeng@chromium.org> Date: Sat Jun 09 04:24:01 2018 Turn off scroll animation for 3 layout tests These 3 layout tests still flaky on bots. It may caused by scroll animation. Bug: 841567 Change-Id: I864b850899ecd71866257859084d8b149f31f220 Reviewed-on: https://chromium-review.googlesource.com/1092010 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#565853} [modify] https://crrev.com/00a72bddc5e5f2882ada86addef3e6a023f24429/third_party/WebKit/LayoutTests/fast/scrolling/absolute-position-behind-scrollbar.html [modify] https://crrev.com/00a72bddc5e5f2882ada86addef3e6a023f24429/third_party/WebKit/LayoutTests/fast/scrolling/fixed-position-behind-scrollbar.html [modify] https://crrev.com/00a72bddc5e5f2882ada86addef3e6a023f24429/third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-tickmarks-hittest.html
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/349a9923b19ccbf9aa8b1b4e18832ea86824e87a commit 349a9923b19ccbf9aa8b1b4e18832ea86824e87a Author: chaopeng <chaopeng@chromium.org> Date: Wed Jul 11 00:44:25 2018 Convert hover-during-scroll.html to new test style There are 3 changes make in hover-during-scroll.html: 1. update tests to use testharness.js 2. call rAFs before start input 3. use promise_test and gpuBenchmarking events This should fix the hover-during-scroll.html flaky on virtual/threaded test suites. Bug: 841567 Change-Id: Idc46e81a3974e97478a871dc976af3acf7493269 Reviewed-on: https://chromium-review.googlesource.com/1130013 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#574003} [delete] https://crrev.com/1a60f2b8295dbc71fc6ce6ea5d6882c6ad736a88/third_party/WebKit/LayoutTests/fast/scrolling/hover-during-scroll-expected.txt [modify] https://crrev.com/349a9923b19ccbf9aa8b1b4e18832ea86824e87a/third_party/WebKit/LayoutTests/fast/scrolling/hover-during-scroll.html [modify] https://crrev.com/349a9923b19ccbf9aa8b1b4e18832ea86824e87a/third_party/WebKit/LayoutTests/resources/gesture-util.js
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c318a4bf245af9f053e6bff504d80f3b7265f51 commit 8c318a4bf245af9f053e6bff504d80f3b7265f51 Author: chaopeng <chaopeng@chromium.org> Date: Tue Jul 17 22:07:18 2018 Convert overflow-scrollability.html to new test style There are 3 changes make in overflow-scrollability.html: 1. update tests to use testharness.js 2. call rAFs before start input 3. use promise_test and gpuBenchmarking events This should fix the overflow-scrollability.html flaky on virtual/threaded test suites. Bug: 841567 Change-Id: Ic098832a3ce685774d204d245f61809edee4a60b Reviewed-on: https://chromium-review.googlesource.com/1131834 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#575793} [delete] https://crrev.com/8bedb092995ef32665ffc262fa7cb91774ac5e4b/third_party/WebKit/LayoutTests/fast/scrolling/overflow-scrollability-expected.txt [modify] https://crrev.com/8c318a4bf245af9f053e6bff504d80f3b7265f51/third_party/WebKit/LayoutTests/fast/scrolling/overflow-scrollability.html
,
Aug 2
virtual/threaded/fast/scrolling/overflow-scrollability.html tests look very flaky on Mac Retina (all timing out). Sample builds: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/609 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/608 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/605 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/599
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67893dce39a23c72121ebd769bbeaf889b7c31fa commit 67893dce39a23c72121ebd769bbeaf889b7c31fa Author: Kinuko Yasuda <kinuko@chromium.org> Date: Thu Aug 02 07:17:24 2018 Add Timeout expectation for virtual/threaded/fast/scrolling/overflow-scrollability.html TBR=chaopeng Bug: 841567 Change-Id: I824e726b2399870b6ba821b2c79adbd3673b7b31 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1160063 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580098} [modify] https://crrev.com/67893dce39a23c72121ebd769bbeaf889b7c31fa/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 22
overflow-scrollability.html and hover-during-scroll.html are still failing but this shouldn't block blink-gen-property-trees.
,
Sep 6
Issue 665577 has been merged into this issue.
,
Oct 31
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/838b775dbf4ee845f71af61b9be94d6917e58564 commit 838b775dbf4ee845f71af61b9be94d6917e58564 Author: chaopeng <chaopeng@chromium.org> Date: Wed Oct 31 18:21:07 2018 Add flaky expectations for virtual/fractional_scrolling_threaded/fast/scrolling/listbox-wheel-event.html fast/scrolling/listbox-wheel-event.html is flaky on virtual/threaded/ test suite, virtual/fractional_scrolling_threaded/ is virtual/threaded/ plus FractionalScrollOffsets flag. It should be same flaky with virtual/threaded/fast/scrolling/listbox-wheel-event.html. Bug: 841567 Change-Id: If3e0c7b465ccd3935e105fd52c946cd75c8651dd Reviewed-on: https://chromium-review.googlesource.com/c/1309993 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#604336} [modify] https://crrev.com/838b775dbf4ee845f71af61b9be94d6917e58564/third_party/WebKit/LayoutTests/TestExpectations |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bokan@chromium.org
, May 10 2018