New issue
Advanced search Search tips

Issue 841542 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

GM2: Lock icon should be gray

Project Member Reported by emilyschechter@chromium.org, May 9 2018

Issue description

Per GM2 specs, Lock icon should be gray (grey?)
 

Comment 1 by k...@chromium.org, May 10 2018

Status: Assigned (was: Untriaged)
Labels: M-69
Labels: -Pri-3 Pri-2
Added M69 and p2 since we should have this in M69.

This should be for the DV lock + EV string; aka all places that are currently green.
Project Member

Comment 5 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3f9e3c891650110375813315343c5be03d2dadc

commit a3f9e3c891650110375813315343c5be03d2dadc
Author: Tommy C. Li <tommycli@chromium.org>
Date: Wed May 30 17:11:58 2018

Omnibox UI Refresh: Update Secure chip color to gray for Refresh

When the Refresh flag is on, after this CL, even secure sites will
appear as gray.

Also to match the mocks, incognito mode icons have been recolored to
Google Gray 200 instead of 100 when Refresh flag is on.

Bug:  841542 ,  823535 
Change-Id: Iaa0febad225a5ac7437a6614e82f6345ccc1860d
Reviewed-on: https://chromium-review.googlesource.com/1072904
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562878}
[modify] https://crrev.com/a3f9e3c891650110375813315343c5be03d2dadc/chrome/browser/ui/omnibox/omnibox_theme.cc

Status: Fixed (was: Assigned)
Labels: Needs-Feedback
Tested the issue on latest chrome version# 69.0.3446.0 using Mac 10.12.6, Ubuntu 14.04 and Windows 10 with steps mentioned below:
1) Launched chrome version and navigated to chrome://flags and enabled refresh flag
2) On NTP, navigated to secure site(for example google.com) and observed Secure chip turns to gray on Linux and Windows, but on Mac it remains same as green colour.

@Tommy C. Li: Please find the attached screencast of Linux and Mac and help us in confirming the fix on Mac OS.

Thanks!
841542.ogv
808 KB View Download
841542 - Mac 10.12.6.mp4
524 KB View Download
On Mac Cocoa we expect it to remain Green.

Please confirm that on Mac Views it is Gray with these flags:

#views-browser-windows → Enabled
#top-chrome-md  → Refresh
#secondary-ui-md → Enabled

Sign in to add a comment