New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841527 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-11
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Reduce frequency of Blink rendering-related UKMs.

Project Member Reported by chrishtr@google.com, May 9 2018

Issue description

They are currently sampled every second; this uses too much user bandwidth.

See also internal b/79071304.
 
Pls apply appropriate OSs label. Thank you.
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Labels: Merge-Request-67
This is a simple and very safe merge, which fixes an issue where too much
data was being sent to the server.

Comment 5 by gov...@chromium.org, May 10 2018

Is this cl https://chromium-review.googlesource.com/c/chromium/src/+/1050938 verified in canary?
Project Member

Comment 6 by sheriffbot@chromium.org, May 10 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by gov...@chromium.org, May 10 2018

*** Bulk Edit ***
M67 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. 

If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.

Comment 8 by gov...@chromium.org, May 10 2018

NextAction: 2018-05-11
chrishtr@ to update bug with canary result tomorrow. Thank you.
The NextAction date has arrived: 2018-05-11
I think this is ready for merge.
Labels: -Merge-Review-67 Merge-Approved-67
Approving merge to M67 branch 3396 based on comment #4 and #10. Please merge and mark bug as fixed. Thank you.
Project Member

Comment 12 by bugdroid1@chromium.org, May 11 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd35637950932ec017915a1177bf63a62bd1b846

commit dd35637950932ec017915a1177bf63a62bd1b846
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Fri May 11 21:52:41 2018

Increase rendering UKM sampling period to 30 seconds.

At a 1-second aggregation period, the UKM team reports
that there is too much data being collected, which
causes too much user bandwidth.

See internal b/79071304.

TBR=chrishtr@chromium.org

(cherry picked from commit 79f554bc2d62df9ffcac3ad7e9460c9acfdae9f4)

Bug:  841527 
Change-Id: I9553b56a0b8b2b32229c7ee11586640c4f0a0a6f
Reviewed-on: https://chromium-review.googlesource.com/1050938
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#557097}
Reviewed-on: https://chromium-review.googlesource.com/1056154
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#575}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/dd35637950932ec017915a1177bf63a62bd1b846/third_party/blink/renderer/core/frame/local_frame_view.cc

Status: Fixed (was: Assigned)

Sign in to add a comment