New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841520 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Nov 5
Cc:
eugene...@chromium.org
thegreenfrog@chromium.org
█ danblakemore@google.com
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:8973


Sign in to add a comment

Not seeing Code-Review and Commit-Queue -1/0/+1/+2

Project Member Reported by pkl@chromium.org, May 9 2018 
This may be more of a question than a bug report.

Some non-committers on my team are not seeing the -1/0/+1/+2 buttons in the gerrit Reply screen. For example, this is my screen https://screenshot.googleplex.com/ofoBJcw9ch2 but they don't seem these buttons.

Is that because they are not committers? Or are they having some other mis-configurations?

Comment 1 by logan@google.com, May 9 2018

Project: chromium
Moved issue gerrit:8973 to now be  issue chromium:841520 .

Comment 2 by logan@google.com, May 9 2018

Components: Infra>Codereview>Gerrit

Comment 3 by ajp@chromium.org, Nov 5

Status: WontFix (was: New)
Hard to diagnose fully without more information, but my suspicion is that you are/were correct and that it is because they are not committers. It depends on the repo configuration but for chromium/src and similar repositories, you can only apply the CR+1 label if you are a committer. And you can only apply the CR+2 label if a committer has applied CR+1. There are separate tryjob permissions users can get for CQ+1. 

Closing for now. Given the age I'm assuming this has been worked out. But please reopen if after this comment you think there is a bug or problem.
►

Sign in to add a comment