New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841514 link

Starred by 5 users
Status: Available
Owner: ----
Cc:
tedc...@chromium.org
█ asimjour@chromium.org
dbbrooks@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

2D UI - new Save data dialog appears in 2D when placed in phone

Project Member Reported by dougman@chromium.org, May 9 2018 
Chrome Version: 68.0.3425.0 Canary
OS: Android 8.1.0 on Pixel 2

What steps will reproduce the problem?
(1) Uninstall and reinstall Chrome
(2) Trigger the "Save data and browse faster" dialog
(3) Enter VR Browsing

What is the expected result?
The dialog should be closed and we transition to VR Browsing normally.

What happens instead?
The user is presented DON, then the dialog in Chrome 2D, then VR Browsing.
SaveData_Dialog.mp4
11.9 MB View Download

Comment 1 by cjgrant@chromium.org, May 16 2018

Cc: asimjour@chromium.org
Owner: asimjour@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by asimjour@chromium.org, Jul 18 

 Issue 829682  has been merged into this issue.

Comment 3 by asimjour@chromium.org, Jul 18

Labels: -Pri-3 Pri-2
Updating data server dialog to use ModalDialogManager fixes this problem as well as  crbug.com/829682 .

Comment 4 by asimjour@chromium.org, Jul 18

Cc: tedc...@chromium.org
I have a WIP patch that fixes this problem, but I need to get feedback from UX before going forward. Here is how Data Saver Dialog looks like before and after using ModalDialogManager.

+tedchoc, do you know who I need to talk to about this change?
After.png
304 KB View Download
Before.png
338 KB View Download

Comment 5 by tedc...@chromium.org, Jul 18 

hannahs@ for dialog convergence.  What happens if you rotate the phone after your change?  Those dialogs have some crazy orientation magic that would be good to see as well.

Comment 6 by asimjour@chromium.org, Aug 27

Labels: -Pri-2 Pri-3
Owner: ----
Status: Available (was: Assigned)
It should be fixed once we have a plan on how to move ModalDialogViews from 2D to VR and other way around. Doesn't sound to have a high priority at the time.

Comment 7 by asimjour@chromium.org, Aug 27 

 Issue 822800  has been merged into this issue.

Comment 8 by samdrazin@chromium.org, Today (15 hours ago)

Labels: VR-B-SVR-Only
►

Sign in to add a comment