I dont think there is chromium.org/dummy.pdf file

TEST_F(FindTextTest, FindText) {
  pp::URLLoader dummy_loader;
  TestClient client;
  PDFiumEngine engine(&client);
  ASSERT_TRUE(engine.New("https://chromium.org/dummy.pdf", ""));
  ASSERT_TRUE(engine.HandleDocumentLoad(dummy_loader));

I added the test.

Sorry i gave the wrong test.

Crash is 
https://chromium-coverage.appspot.com/reports/556999/linux/metadata/pdfium_unittests.log

[----------] 1 test from CPDF_HintTablesTest
[ RUN      ] CPDF_HintTablesTest.Load
UndefinedBehaviorSanitizer:DEADLYSIGNAL
==21623==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x0000034ea029 bp 0x7fff2a3149b0 sp 0x7fff2a314990 T21623)
==21623==The signal is caused by a READ memory access.
==21623==Hint: address points to the zero page.
    #0 0x34ea028  (/chromium/src/out/coverage/pdfium_unittests+0x34ea028)
    #1 0x3474746  (/chromium/src/out/coverage/pdfium_unittests+0x3474746)
    #2 0xcde49a  (/chromium/src/out/coverage/pdfium_unittests+0xcde49a)
    #3 0x3004343  (/chromium/src/out/coverage/pdfium_unittests+0x3004343)
    #4 0x30062c5  (/chromium/src/out/coverage/pdfium_unittests+0x30062c5)
    #5 0x3007ab0  (/chromium/src/out/coverage/pdfium_unittests+0x3007ab0)
    #6 0x30256a7  (/chromium/src/out/coverage/pdfium_unittests+0x30256a7)
    #7 0x3024d4f  (/chromium/src/out/coverage/pdfium_unittests+0x3024d4f)
    #8 0x1003af3  (/chromium/src/out/coverage/pdfium_unittests+0x1003af3)
    #9 0x7f827af2782f  (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
    #10 0xc4c029  (/chromium/src/out/coverage/pdfium_unittests+0xc4c029)

I am trying to see why we didnt symbolize this.

Here is the full stacktrace

[----------] 1 test from CPDF_HintTablesTest
[ RUN      ] CPDF_HintTablesTest.Load
UndefinedBehaviorSanitizer:DEADLYSIGNAL
==11072==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x000003926239 bp 0x7ffd4cb89840 sp 0x7ffd4cb89820 T11072)
==11072==The signal is caused by a READ memory access.
==11072==Hint: address points to the zero page.
    #0 0x3926238 in get ../../buildtools/third_party/libc++/trunk/include/memory:2607:19
    #1 0x3926238 in operator-> ../../third_party/pdfium/core/fxcrt/retain_ptr.h:80
    #2 0x3926238 in CPDF_ReadValidator::CPDF_ReadValidator(fxcrt::RetainPtr<IFX_SeekableReadStream> const&, CPDF_DataAvail::FileAvail*) ../../third_party/pdfium/core/fpdfapi/parser/cpdf_read_validator.cpp:51
    #3 0x38b0976 in MakeRetain<CPDF_ReadValidator, const fxcrt::RetainPtr<IFX_SeekableReadStream> &, CPDF_DataAvail::FileAvail *const &> ../../third_party/pdfium/core/fxcrt/retain_ptr.h:125:27
    #4 0x38b0976 in CPDF_DataAvail::CPDF_DataAvail(CPDF_DataAvail::FileAvail*, fxcrt::RetainPtr<IFX_SeekableReadStream> const&, bool) ../../third_party/pdfium/core/fpdfapi/parser/cpdf_data_avail.cpp:85
    #5 0xfbce7a in MakeUnique<CPDF_DataAvail, nullptr_t, fxcrt::RetainPtr<IFX_SeekableReadStream>, bool> ../../third_party/pdfium/third_party/base/ptr_util.h:56:33
    #6 0xfbce7a in MakeDataAvailFromFile ../../third_party/pdfium/core/fpdfapi/parser/cpdf_hint_tables_unittest.cpp:26
    #7 0xfbce7a in CPDF_HintTablesTest_Load_Test::TestBody() ../../third_party/pdfium/core/fpdfapi/parser/cpdf_hint_tables_unittest.cpp:44
    #8 0x33f8123 in testing::Test::Run() ../../third_party/googletest/src/googletest/src/gtest.cc
    #9 0x33fa0a5 in testing::TestInfo::Run() ../../third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #10 0x33fb890 in testing::TestCase::Run() ../../third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #11 0x3419417 in testing::internal::UnitTestImpl::RunAllTests() ../../third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #12 0x3418abf in testing::UnitTest::Run() ../../third_party/googletest/src/googletest/src/gtest.cc
    #13 0x12e25b1 in RUN_ALL_TESTS ../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #14 0x12e25b1 in main ../../third_party/pdfium/testing/unit_test_main.cpp:86
    #15 0x7f09902bd2b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
    #16 0xf2a029 in _start (/usr/local/google/home/aarya/build/chromium/src/out/coverage/pdfium_unittests+0xf2a029)

UndefinedBehaviorSanitizer can not provide additional info.
==11072==ABORTING

And command is
out/coverage/pdfium_unittests not pdf_unittests, sorry for confusion.

I'll take a look anyway. Do we know why these tests only crash with coverage turned on? They are not crashing when built + ran in a PDFium checkout.

That is the part we are unclear about, so your help is appreciated here.

Hm, interesting. I don't see anything coverage-specific in the stacktrace. My wild guess would be: can it go out of memory, and then end up with a null-deref?

However, that doesn't sound likely to me, as our coverage bots have ~120 GB of RAM each.

I can reproduce the CPDF_HintTablesTest.Load crash in a coverage build. I'll try to answer my own question then.

pdfium_unittests does not work in general in a Chromium checkout, because the directory structure is different. The only bots that run pdfium_unittests are on the PDFium waterfall, which uses a standalone PDFium checkout.

How much work is needed to make it work in chromium checkout OR does it make sense to remove it. Since it is DEPSed in, it will be nice to make the test run so that coverage of those parts of code show up. We won't be be running standalone components from their repos for quite a while, so need a solution from chromium checkout.

It's not much work. https://pdfium-review.googlesource.com/32314

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/code-coverage/+/c9eb3ff238238aee0f5aed2e2b45d9242dbde5af

commit c9eb3ff238238aee0f5aed2e2b45d9242dbde5af
Author: Abhishek Arya <inferno@chromium.org>
Date: Thu May 10 03:35:57 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c97ea548f8d4cb5cbb285353839ca5128b5af49

commit 1c97ea548f8d4cb5cbb285353839ca5128b5af49
Author: Abhishek Arya <inferno@chromium.org>
Date: Thu May 10 03:53:19 2018

Coverage: Add llvm-symbolizer to path for symbolized stacks

R=mmoroz@chromium.org,liaoyuke@chromium.org

Bug:  784464 ,  841513 
Change-Id: Ia592f2c0145d9117e6c59d14c6b1685d104429c0
Reviewed-on: https://chromium-review.googlesource.com/1053161
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557446}
[modify] https://crrev.com/1c97ea548f8d4cb5cbb285353839ca5128b5af49/tools/code_coverage/coverage.py

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/f4f19b51b2d588abe80df8493c23d708ec63f1b7

commit f4f19b51b2d588abe80df8493c23d708ec63f1b7
Author: Lei Zhang <thestig@chromium.org>
Date: Thu May 10 17:33:56 2018

Make GetTestDataDir() work in a non-standalone checkout.

Set the test data dir path correctly if PDFium is living inside another
project as third_party/pdfium.

BUG= chromium:841513 

Change-Id: I565f7d97157e1769be8b7910f3c77d6d00015543
Reviewed-on: https://pdfium-review.googlesource.com/32314
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/f4f19b51b2d588abe80df8493c23d708ec63f1b7/testing/utils/path_service.h
[modify] https://crrev.com/f4f19b51b2d588abe80df8493c23d708ec63f1b7/testing/utils/path_service.cpp

Just waiting for the DEPS roll now.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/511f71f2d113829989df1949d1a9343f1d0019f8

commit 511f71f2d113829989df1949d1a9343f1d0019f8
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu May 10 20:13:17 2018

Roll src/third_party/pdfium/ 95061379c..80302c77a (5 commits)

https://pdfium.googlesource.com/pdfium.git/+log/95061379c945..80302c77a854

$ git log 95061379c..80302c77a --date=short --no-merges --format='%ad %ae %s'
2018-05-10 rharrison Use test_dir instead of 'pdfium' for source type
2018-05-10 thestig Add CPDF_Transparency.
2018-05-10 thestig Make GetTestDataDir() work in a non-standalone checkout.
2018-05-10 tsepez Fix destruction order in CPDF_Dibsource.
2018-05-10 npm Remove a completeness check from CJBig2_GRRDProc::DecodeTemplate0Opt

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:841513 , chromium:840695 , chromium:841200 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I579c4a7663af521bb842f5e0f309f2bcd71732f3
Reviewed-on: https://chromium-review.googlesource.com/1054263
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557647}
[modify] https://crrev.com/511f71f2d113829989df1949d1a9343f1d0019f8/DEPS