Issue metadata
Sign in to add a comment
|
Unit tests break when sanitizer flags are used for full system builds. |
||||||||||||||||||||||||
Issue descriptionWhen all packages are built with sanitizer flags, unit tests fail to run because of a mixup in host binaries vs target libraries. e.g. portable tests complains about missing symbols in libpython, libncurses, libreadline etc.
,
May 10 2018
,
May 10 2018
+1, I think that can be put off for a while though. As I've pointed out, chrome doesn't yet have this. I asked kcc about this today, he clarified that this is something that he wants, but agreed that it isn't something strictly needed
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/3c311c15709b2c77c9d70be0a866a775555db08a commit 3c311c15709b2c77c9d70be0a866a775555db08a Author: Manoj Gupta <manojgupta@google.com> Date: Thu May 10 22:10:06 2018 cbuildbot: Disable unit tests in fuzzer builds. As part of instrumenting the whole system with sanitizer flags, too many packages and libraries fail to run with current test infrastructure setup. So disable the unit test stage for now. BUG= chromium:841512 TEST=No more unit test stage in amd64-generic-fuzzer builder. Change-Id: Ib46002da50b2f8eccb37aeb1d7c12a4a5cc48cec Reviewed-on: https://chromium-review.googlesource.com/1053087 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Jonathan Metzman <metzman@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/3c311c15709b2c77c9d70be0a866a775555db08a/cbuildbot/builders/fuzzer_builders.py
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6297b2be6ab0dde891052b935537b2b29ab499a commit b6297b2be6ab0dde891052b935537b2b29ab499a Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 11 00:15:20 2018 Roll src/third_party/chromite/ 0aae1c1fc..3c311c157 (4 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/0aae1c1fc30a..3c311c15709b $ git log 0aae1c1fc..3c311c157 --date=short --no-merges --format='%ad %ae %s' 2018-05-09 manojgupta cbuildbot: Disable unit tests in fuzzer builds. 2018-04-20 bmgordon build_stages: Use snapshot to clean up chroot. 2018-05-04 yunlian generic_stages: temporarily ignore all target prebuilts. 2018-05-08 guocb auto_updater: filter more directories when copy devserver to DUT Created with: roll-dep src/third_party/chromite BUG= chromium:841512 , chromium:829665 ,chromium:730144, chromium:826418 , chromium:840975 ,chromium:824580 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0abebd960beb44b1560aca995781fed1b91f453f Reviewed-on: https://chromium-review.googlesource.com/1054619 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557735} [modify] https://crrev.com/b6297b2be6ab0dde891052b935537b2b29ab499a/DEPS
,
May 15 2018
Closing for now. May revisit later on. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by manojgupta@chromium.org
, May 9 2018