New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841509 link

Starred by 1 user
Status: Fixed
Owner:
aee@chromium.org
Closed: May 2018
Cc:
rdevlin....@chromium.org
█ scottchen@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Update chrome://extensions messages in Guest mode

Project Member Reported by michae...@chromium.org, May 9 2018 
In Guest mode, including on Chrome OS, the chrome://extensions page shows some extraneous strings:

> Extension management is not available to Guest users. Please sign in to manage extensions.

This is fine, although "sign in" isn't the best language -- you'd need to switch to another profile (whether or not that profile is signed in), since you can't "sign in" in Guest mode

> Find extensions and themes in the Chrome Web Store

Should remove.

> No search results found

Should remove.

Tested on Linux and CrOS; I imagine Windows and Mac are the same.
guest.png
201 KB View Download

Comment 1 by rdevlin....@chromium.org, May 10 2018

Cc: scottchen@chromium.org rdevlin....@chromium.org aee@chromium.org dpa...@chromium.org
Owner: ----
I probably won't get to this in the immediate future.  cc'ing some other folks in case they have bandwidth.

Comment 2 by aee@chromium.org, May 10 2018

Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Started (was: Untriaged)

Comment 3 by aee@chromium.org, May 10 2018 

Screenshot of using the common page not available UI also used for bookmarks and history pages.
Screen Shot 2018-05-10 at 1.05.02 PM.png
147 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88b5ae144d57e2d56c47bc1069ff564ec985310b

commit 88b5ae144d57e2d56c47bc1069ff564ec985310b
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Mon May 14 09:07:12 2018

MD Extensions: use common page not available for guest ui

Bug:  841509 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idf57751875b2ffe762476b33f9b0af66f3ea76c8
Reviewed-on: https://chromium-review.googlesource.com/1054609
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558234}
[modify] https://crrev.com/88b5ae144d57e2d56c47bc1069ff564ec985310b/chrome/app/md_extensions_strings.grdp
[modify] https://crrev.com/88b5ae144d57e2d56c47bc1069ff564ec985310b/chrome/browser/resources/md_extensions/item_list.html
[modify] https://crrev.com/88b5ae144d57e2d56c47bc1069ff564ec985310b/chrome/browser/resources/md_extensions/item_list.js
[modify] https://crrev.com/88b5ae144d57e2d56c47bc1069ff564ec985310b/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/88b5ae144d57e2d56c47bc1069ff564ec985310b/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/88b5ae144d57e2d56c47bc1069ff564ec985310b/chrome/browser/resources/md_extensions/navigation_helper.js
[modify] https://crrev.com/88b5ae144d57e2d56c47bc1069ff564ec985310b/chrome/browser/resources/md_extensions/toolbar.html
[modify] https://crrev.com/88b5ae144d57e2d56c47bc1069ff564ec985310b/chrome/browser/resources/md_extensions/toolbar.js
[modify] https://crrev.com/88b5ae144d57e2d56c47bc1069ff564ec985310b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/88b5ae144d57e2d56c47bc1069ff564ec985310b/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/88b5ae144d57e2d56c47bc1069ff564ec985310b/chrome/browser/ui/webui/page_not_available_for_guest/page_not_available_for_guest_ui.cc
[modify] https://crrev.com/88b5ae144d57e2d56c47bc1069ff564ec985310b/chrome/test/data/webui/extensions/extension_navigation_helper_test.js
Project Member

Comment 5 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbe58f93e0108fc144d296b20efb94f31c6a80d8

commit bbe58f93e0108fc144d296b20efb94f31c6a80d8
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Mon May 14 20:32:10 2018

MD Extensions: use extension title for not available in guest mode page

Bug:  841509 
Change-Id: I841f3487c12716d4ab0c88a6a27462729308f31c
Reviewed-on: https://chromium-review.googlesource.com/1057837
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558446}
[modify] https://crrev.com/bbe58f93e0108fc144d296b20efb94f31c6a80d8/chrome/app/md_extensions_strings.grdp
[modify] https://crrev.com/bbe58f93e0108fc144d296b20efb94f31c6a80d8/chrome/browser/ui/webui/page_not_available_for_guest/page_not_available_for_guest_ui.cc

Comment 6 by aee@chromium.org, May 14 2018

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, May 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37f4d3c49ab3fb447cccd667744695306ff3a235

commit 37f4d3c49ab3fb447cccd667744695306ff3a235
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue May 15 00:17:58 2018

MD Extensions: an element attribute without value translates to a boolean polymer prop set to true

Bug:  841509 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibaf6dfa740738d3718494d32bd32db2de7a116e8
Reviewed-on: https://chromium-review.googlesource.com/1058178
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558544}
[modify] https://crrev.com/37f4d3c49ab3fb447cccd667744695306ff3a235/chrome/browser/resources/md_extensions/toolbar.html
►

Sign in to add a comment