Overflow Menu - Incognito menu items reversed |
|||||
Issue descriptionChrome Version: 68.0.3425.0 OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? (1) Navigate to www.google.com (2) Enter VR Browsing (3) Use Overflow menu to open "New incognito tab" (4) Look at Overflow menu What is the expected result? The order of the "New incognito tab" and "Close incognito tabs" menu items or in the original order as listed here. What happens instead? These menu items have been reversed in the current canary build.
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e83e4ecc29842cec8406136a8d66d8c8a65b8a2 commit 0e83e4ecc29842cec8406136a8d66d8c8a65b8a2 Author: Christopher Grant <cjgrant@chromium.org> Date: Thu May 10 22:23:01 2018 VR: Restore overflow menu ordering - Revert to "new incognito tab" above "close all incognito tabs" - Don't duplicate the UI model logic in each button handler BUG= 841501 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I87e625ec75270114567810c595ca3767e7e93b0f Reviewed-on: https://chromium-review.googlesource.com/1054503 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#557695} [modify] https://crrev.com/0e83e4ecc29842cec8406136a8d66d8c8a65b8a2/chrome/browser/vr/ui_scene_creator.cc
,
May 11 2018
,
May 14 2018
,
May 14 2018
Fix verified in build 68.0.3427.0 Canary. Looks good.
,
May 14 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by cjgrant@chromium.org
, May 10 2018Status: Started (was: Untriaged)