Presubmit warnings for multiple definitions of ClassRegisterImpl |
||
Issue description
I saw presubmit warnings for this class the other day:
$ git cl upload
WARNING: multiple definitions of org.chromium.chrome.browser.ClassRegisterImpl:
[redacted].../src/chrome/android/java/src/org/chromium/chrome/browser/ClassRegisterImpl.java
[redacted].../src/clank/java/src/org/chromium/chrome/browser/ClassRegisterImpl.java
You need to whitelist your class name. James recently did this for PSB in issue 838493 . Note: this warning only shows up if that class is part of the CL.
,
May 10 2018
Cool, thanks for clean up this!
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/524eb683cc64aa57e92d9d4c7cb638fb286d77b0 commit 524eb683cc64aa57e92d9d4c7cb638fb286d77b0 Author: James Wallace-Lee <jamwalla@chromium.org> Date: Thu May 10 01:36:35 2018 Exclude ClassRegisterImpl from presubmit warning There are two definitions of ClassRegisterImpl, one downstream. This CL supresses the presubmit warning that there are multiple defintions of the class. Bug: 841499 Change-Id: Ifba28a0bb605901d5c7524d5c8ffc71c667d894b Reviewed-on: https://chromium-review.googlesource.com/1053360 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#557412} [modify] https://crrev.com/524eb683cc64aa57e92d9d4c7cb638fb286d77b0/PRESUBMIT.py
,
May 10 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by ntfschr@chromium.org
, May 9 2018Owner: jamwalla@chromium.org
Status: Assigned (was: Available)