New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841474 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Adapt BindOnce/Repeating for Offline Pages

Project Member Reported by romax@chromium.org, May 9 2018

Issue description

Use BindOnce/Repeating explicitly for all callbacks.
 

Comment 1 by romax@chromium.org, May 9 2018

See more in crbug.com/714018
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dd02281013e96899a556ce076008a2cf040e04c

commit 1dd02281013e96899a556ce076008a2cf040e04c
Author: Yafei Duan <romax@chromium.org>
Date: Fri May 11 23:51:39 2018

[Offline Pages] Making RequestCoodinator use Once/Repeating callback.

Improve the base::Bind* and base::Callback usage by adapting
Once/Repeating callbacks in RequestCoordinator and Offliner related
code.

Bug: 841474
Change-Id: I95b14867b4ba3b666188b48ad94749f21c7720d1
Reviewed-on: https://chromium-review.googlesource.com/1053527
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558063}
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/chrome/browser/offline_pages/android/offline_page_bridge.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/chrome/browser/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/chrome/browser/offline_pages/background_loader_offliner.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/chrome/browser/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/add_request_task.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/add_request_task.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/add_request_task_unittest.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/change_requests_state_task.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/change_requests_state_task.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/change_requests_state_task_unittest.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/cleanup_task.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/cleanup_task_unittest.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/connection_notifier.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/connection_notifier.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/get_requests_task.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/get_requests_task.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/get_requests_task_unittest.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/initialize_store_task.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/initialize_store_task.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/initialize_store_task_unittest.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/mark_attempt_aborted_task.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/mark_attempt_aborted_task.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/mark_attempt_aborted_task_unittest.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/mark_attempt_completed_task.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/mark_attempt_completed_task.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/mark_attempt_completed_task_unittest.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/mark_attempt_started_task.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/mark_attempt_started_task.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/mark_attempt_started_task_unittest.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/offliner.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/offliner_stub.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/offliner_stub.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/pending_state_updater.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/pick_request_task.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/pick_request_task.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/pick_request_task_unittest.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/reconcile_task.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/reconcile_task.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/reconcile_task_unittest.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/remove_requests_task.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/remove_requests_task.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/remove_requests_task_unittest.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/request_coordinator.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/request_coordinator.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/request_coordinator_unittest.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/request_queue.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/request_queue.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/request_queue_in_memory_store.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/request_queue_in_memory_store.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/request_queue_store.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/request_queue_store_sql.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/request_queue_store_sql.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/request_queue_store_unittest.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/request_queue_unittest.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/update_request_task.cc
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/background/update_request_task.h
[modify] https://crrev.com/1dd02281013e96899a556ce076008a2cf040e04c/components/offline_pages/core/downloads/download_ui_adapter.cc

Owner: romax@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1679774173c03c662b09cb0b412fe25f81b1914

commit d1679774173c03c662b09cb0b412fe25f81b1914
Author: Yafei Duan <romax@chromium.org>
Date: Mon May 21 23:50:59 2018

[Offline Pages] Make MultipleOfflinePageItemCallback to be OnceCallback.

Making MultipleOfflinePageItemCallback to be a OnceCallback, and changed
related Bind calls to BindOnce calls.

Also some related minor changes to the touched files, like formatting,
using BindRepeating for unchanged callback and using base::WrapUnique
when applicable.

Bug: 841474
Change-Id: I9582aeec14a3a2763f1c4c5afbce0e609600511c
Reviewed-on: https://chromium-review.googlesource.com/1052826
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560413}
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/chrome/browser/offline_pages/android/offline_page_bridge.cc
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/components/ntp_snippets/offline_pages/offline_pages_test_utils.cc
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/components/ntp_snippets/offline_pages/offline_pages_test_utils.h
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/components/ntp_snippets/remote/prefetched_pages_tracker_impl.cc
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/components/ntp_snippets/remote/prefetched_pages_tracker_impl_unittest.cc
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/components/offline_pages/core/downloads/download_ui_adapter.cc
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/components/offline_pages/core/downloads/download_ui_adapter_unittest.cc
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/components/offline_pages/core/model/get_pages_task.cc
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/components/offline_pages/core/model/get_pages_task.h
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/components/offline_pages/core/model/get_pages_task_unittest.cc
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/components/offline_pages/core/model/offline_page_model_taskified.cc
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/components/offline_pages/core/model/offline_page_model_taskified.h
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/components/offline_pages/core/offline_page_model.h
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/components/offline_pages/core/offline_page_types.h
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/components/offline_pages/core/stub_offline_page_model.cc
[modify] https://crrev.com/d1679774173c03c662b09cb0b412fe25f81b1914/components/offline_pages/core/stub_offline_page_model.h

Project Member

Comment 5 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27c8040672af1bbb073cc9829a5d0a29fa55b7b1

commit 27c8040672af1bbb073cc9829a5d0a29fa55b7b1
Author: Yafei Duan <romax@chromium.org>
Date: Tue May 22 01:17:08 2018

[Offline Pages] Making SingleOfflinePageItemCallback an OnceCallback.

Making SingleOfflinePageItemCallback an OnceCallback, changed related
base::Bind() to base::BindOnce().

Bug: 841474
Change-Id: I5149dbcd7b0e1884859881a4c9f22010409c0ab2
Reviewed-on: https://chromium-review.googlesource.com/1055190
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560443}
[modify] https://crrev.com/27c8040672af1bbb073cc9829a5d0a29fa55b7b1/chrome/browser/offline_pages/android/offline_page_bridge.cc
[modify] https://crrev.com/27c8040672af1bbb073cc9829a5d0a29fa55b7b1/components/offline_pages/core/model/get_pages_task.cc
[modify] https://crrev.com/27c8040672af1bbb073cc9829a5d0a29fa55b7b1/components/offline_pages/core/model/get_pages_task.h
[modify] https://crrev.com/27c8040672af1bbb073cc9829a5d0a29fa55b7b1/components/offline_pages/core/model/get_pages_task_unittest.cc
[modify] https://crrev.com/27c8040672af1bbb073cc9829a5d0a29fa55b7b1/components/offline_pages/core/model/offline_page_model_taskified.cc
[modify] https://crrev.com/27c8040672af1bbb073cc9829a5d0a29fa55b7b1/components/offline_pages/core/model/offline_page_model_taskified.h
[modify] https://crrev.com/27c8040672af1bbb073cc9829a5d0a29fa55b7b1/components/offline_pages/core/offline_page_model.h
[modify] https://crrev.com/27c8040672af1bbb073cc9829a5d0a29fa55b7b1/components/offline_pages/core/offline_page_types.h
[modify] https://crrev.com/27c8040672af1bbb073cc9829a5d0a29fa55b7b1/components/offline_pages/core/stub_offline_page_model.cc
[modify] https://crrev.com/27c8040672af1bbb073cc9829a5d0a29fa55b7b1/components/offline_pages/core/stub_offline_page_model.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1

commit e5d5f1f8cdc9c3189a2438664c8b3998db0137a1
Author: Yafei Duan <romax@chromium.org>
Date: Fri Jun 01 02:46:52 2018

[Offline Pages] Change Add/SavePageCallback to OnceCallback.

Changed SavePageCallback, AddPageCallback and
OfflinePageArchiver::CreateArchiveCallback to OnceCallback.

Bug: 841474
Change-Id: I587be86d0458af644ffd4dafae9a93b816d09af2
Reviewed-on: https://chromium-review.googlesource.com/1072741
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563502}
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/chrome/browser/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/chrome/browser/offline_pages/offline_page_mhtml_archiver.cc
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/chrome/browser/offline_pages/offline_page_mhtml_archiver.h
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/chrome/browser/offline_pages/offline_page_mhtml_archiver_unittest.cc
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/chrome/browser/offline_pages/offline_page_request_handler_unittest.cc
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/components/offline_pages/core/model/offline_page_model_taskified.cc
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/components/offline_pages/core/model/offline_page_model_taskified.h
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/components/offline_pages/core/model/offline_page_model_taskified_unittest.cc
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/components/offline_pages/core/offline_page_archiver.h
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/components/offline_pages/core/offline_page_archiver_unittest.cc
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/components/offline_pages/core/offline_page_model.h
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/components/offline_pages/core/offline_page_test_archiver.cc
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/components/offline_pages/core/offline_page_test_archiver.h
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/components/offline_pages/core/offline_page_types.h
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/components/offline_pages/core/prefetch/mock_thumbnail_fetcher.h
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/components/offline_pages/core/prefetch/prefetch_dispatcher_impl_unittest.cc
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/components/offline_pages/core/prefetch/prefetch_importer_impl_unittest.cc
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/components/offline_pages/core/stub_offline_page_model.cc
[modify] https://crrev.com/e5d5f1f8cdc9c3189a2438664c8b3998db0137a1/components/offline_pages/core/stub_offline_page_model.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/870c70adecb80d0fe6c0b1866bc2111a308992d7

commit 870c70adecb80d0fe6c0b1866bc2111a308992d7
Author: Yafei Duan <romax@chromium.org>
Date: Fri Jun 01 17:58:24 2018

[Offline Pages] Change Callbacks to OnceCallback.

Change other callbacks defined in offline_page_types.h to be either
OnceCallback or RepeatingCallback.

Bug: 841474
Change-Id: I3c5cfe5f225d5edb8d75c93acc819b1169b9ce47
Reviewed-on: https://chromium-review.googlesource.com/1072711
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563716}
[modify] https://crrev.com/870c70adecb80d0fe6c0b1866bc2111a308992d7/chrome/browser/android/signin/signin_manager_android_unittest.cc
[modify] https://crrev.com/870c70adecb80d0fe6c0b1866bc2111a308992d7/chrome/browser/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/870c70adecb80d0fe6c0b1866bc2111a308992d7/chrome/browser/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/870c70adecb80d0fe6c0b1866bc2111a308992d7/chrome/browser/offline_pages/offline_page_utils.h
[modify] https://crrev.com/870c70adecb80d0fe6c0b1866bc2111a308992d7/components/offline_pages/core/model/offline_page_model_taskified.cc
[modify] https://crrev.com/870c70adecb80d0fe6c0b1866bc2111a308992d7/components/offline_pages/core/model/offline_page_model_taskified.h
[modify] https://crrev.com/870c70adecb80d0fe6c0b1866bc2111a308992d7/components/offline_pages/core/offline_page_model.h
[modify] https://crrev.com/870c70adecb80d0fe6c0b1866bc2111a308992d7/components/offline_pages/core/offline_page_types.h
[modify] https://crrev.com/870c70adecb80d0fe6c0b1866bc2111a308992d7/components/offline_pages/core/stub_offline_page_model.cc
[modify] https://crrev.com/870c70adecb80d0fe6c0b1866bc2111a308992d7/components/offline_pages/core/stub_offline_page_model.h

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7315d2b64b13ae057bd1c58d590c18c4685dea2

commit e7315d2b64b13ae057bd1c58d590c18c4685dea2
Author: Yafei Duan <romax@chromium.org>
Date: Mon Jun 11 22:42:36 2018

[Offline Pages] Use OnceCallback/RepeatingCallback for core/.

Replaced base::Callback with OnceCallback or RepeatingCallback, and
changed related usage of base::Bind to BindOnce or BindRepeating for the
usages in components/offline_pages/core/.

Bug: 841474
Change-Id: Ic762dde4d7333747d36fdec01900e3b9d4168832
Reviewed-on: https://chromium-review.googlesource.com/1089997
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566178}
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/content/background_loader/background_loader_contents_unittest.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/content/renovations/render_frame_script_injector.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/content/renovations/test/page_renovator_browsertest.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/archive_manager.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/downloads/download_ui_adapter.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/downloads/download_ui_adapter_unittest.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/model/clear_storage_task.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/model/delete_page_task_unittest.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/model/offline_page_model_taskified_unittest.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/offline_page_metadata_store_test_util.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/generate_page_bundle_reconcile_task_unittest.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/generate_page_bundle_request.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/generate_page_bundle_request.h
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/generate_page_bundle_request_unittest.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/generate_page_bundle_task.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/generate_page_bundle_task.h
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/get_operation_request.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/get_operation_request.h
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/get_operation_request_unittest.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/get_operation_task.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/get_operation_task.h
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/prefetch_dispatcher_impl.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/prefetch_dispatcher_impl_unittest.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/prefetch_downloader_impl.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/prefetch_gcm_app_handler_unittest.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/prefetch_network_request_factory.h
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/prefetch_network_request_factory_impl.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/prefetch_network_request_factory_impl.h
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/prefetch_request_fetcher.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/prefetch_request_fetcher.h
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/prefetch_request_fetcher_unittest.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/prefetch_request_operation_response_unittest.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/prefetch_types.h
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/sent_get_operation_cleanup_task_unittest.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/prefetch/store/prefetch_store.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/renovations/page_renovator.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/renovations/page_renovator.h
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/renovations/page_renovator_unittest.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/renovations/script_injector.h
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/snapshot_controller.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/task.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/task.h
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/task_queue.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/task_unittest.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/test_task.cc
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/test_task.h
[modify] https://crrev.com/e7315d2b64b13ae057bd1c58d590c18c4685dea2/components/offline_pages/core/test_task_runner.cc

Comment 9 by romax@chromium.org, Jun 28 2018

in //components/offline_pages, only ./content still has base::Callback since its dependency on external APIs. Otherwise there's no occurrences in //components/offline_pages

Sign in to add a comment