New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841473 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

Delete prefetch experiment code

Project Member Reported by csharrison@chromium.org, May 9 2018

Issue description

Looks like we still have some old code in ChromeResourceDispatcherHostDelegate which checks if prefetch is enabled. I think it can be safely removed (it should be shipped by now).

https://cs.chromium.org/chromium/src/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc?rcl=09de1265b68aff3feb6d7e9fe5a1db909acb9497&l=383
 
Cc: xunji...@chromium.org
Owner: csharrison@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eb14f69d744a138c8216d45d75ea3a7519697ab

commit 7eb14f69d744a138c8216d45d75ea3a7519697ab
Author: Charlie Harrison <csharrison@chromium.org>
Date: Mon May 14 16:09:10 2018

Remove some prefetch experimentation code

It also looks like we can remove the ShouldBeginRequest from
RDHD, which I've done here.

TBR=pasko@chromium.org

Bug:  841473 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I238fe589cc192ccec47242350e6bc847f8da65cc
Reviewed-on: https://chromium-review.googlesource.com/1052889
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558333}
[modify] https://crrev.com/7eb14f69d744a138c8216d45d75ea3a7519697ab/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/7eb14f69d744a138c8216d45d75ea3a7519697ab/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/7eb14f69d744a138c8216d45d75ea3a7519697ab/chrome/browser/prefetch/prefetch_browsertest.cc
[modify] https://crrev.com/7eb14f69d744a138c8216d45d75ea3a7519697ab/content/browser/browser_side_navigation_browsertest.cc
[modify] https://crrev.com/7eb14f69d744a138c8216d45d75ea3a7519697ab/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/7eb14f69d744a138c8216d45d75ea3a7519697ab/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/7eb14f69d744a138c8216d45d75ea3a7519697ab/content/browser/loader/url_loader_factory_impl_unittest.cc
[modify] https://crrev.com/7eb14f69d744a138c8216d45d75ea3a7519697ab/content/public/browser/resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/7eb14f69d744a138c8216d45d75ea3a7519697ab/content/public/browser/resource_dispatcher_host_delegate.h
[modify] https://crrev.com/7eb14f69d744a138c8216d45d75ea3a7519697ab/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Status: Fixed (was: Started)

Sign in to add a comment