New issue
Advanced search Search tips

Issue 841465 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Extensions Click-to-Script: Don't apply experimental behavior if the experiment is disabled

Project Member Reported by rdevlin....@chromium.org, May 9 2018

Issue description

If the user does not have the experiment enabled, there should be no behavior change from the default.

See also related  issue 839681 .
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/582db61df3c481f784b77d3d429bfe51aa75883c

commit 582db61df3c481f784b77d3d429bfe51aa75883c
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Thu May 17 00:38:31 2018

[Extensions Click-to-Script] Only apply behavior with the feature enabled

Ensure that click-to-script functionality is only applied if the feature
is enabled. This guarantees that users have an escape hatch.

Bug:  841465 

Change-Id: Ieaf7aa19af449329f536fc46ec3b4dedf09c66b8
Reviewed-on: https://chromium-review.googlesource.com/1053049
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559365}
[modify] https://crrev.com/582db61df3c481f784b77d3d429bfe51aa75883c/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[modify] https://crrev.com/582db61df3c481f784b77d3d429bfe51aa75883c/chrome/browser/extensions/api/developer_private/extension_info_generator.cc
[modify] https://crrev.com/582db61df3c481f784b77d3d429bfe51aa75883c/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
[modify] https://crrev.com/582db61df3c481f784b77d3d429bfe51aa75883c/chrome/browser/extensions/extension_action_runner_browsertest.cc
[modify] https://crrev.com/582db61df3c481f784b77d3d429bfe51aa75883c/chrome/browser/extensions/extension_context_menu_model.cc
[modify] https://crrev.com/582db61df3c481f784b77d3d429bfe51aa75883c/chrome/browser/extensions/permissions_updater.cc
[modify] https://crrev.com/582db61df3c481f784b77d3d429bfe51aa75883c/chrome/browser/extensions/scripting_permissions_modifier.cc
[modify] https://crrev.com/582db61df3c481f784b77d3d429bfe51aa75883c/chrome/browser/extensions/scripting_permissions_modifier.h
[modify] https://crrev.com/582db61df3c481f784b77d3d429bfe51aa75883c/chrome/browser/extensions/scripting_permissions_modifier_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment