New issue
Advanced search Search tips

Issue 841459 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Keyboard Shortcuts window shows wrong shortcuts for non-QWERTY layout

Project Member Reported by michae...@chromium.org, May 9 2018

Issue description

Chrome Version: 67.0.3396.26

The accelerator to toggle High Contrast mode is Ctrl + Launcher + H, but the keyboard shortcuts window shows a different accelerator, which doesn't work.

What steps will reproduce the problem?
(1) Ctrl + Alt + / to open keyboard shortcuts windom
(2) Search for "contrast"

Expected: "Turn on high contrast mode" shortcut listed as Ctrl + Launcher + h
Actual: "Turn on high contrast mode" shortcut listed as Ctrl + Launcher + d
 
Owner: wutao@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Type-Bug -Pri-2 Pri-1 Type-Bug-Regression
Summary: Keyboard Shortcuts window shows wrong shortcuts for non-QWERTY layout (was: "High contrast mode" shortcut incorrect in Keyboard Shortcuts window)
Oh, wow, this extends to every shortcut!

Here's the problem: I have a physical US QWERTY keyboard, but use the US Dvorak keyboard layout. The Keyboard Shortcuts window somehow tries to account for this but gets it backwards!

* The High Contrast Mode shortcut is Ctrl + Launcher + h.
* The physical "h" key types a "d" when in Dvorak input method.
* The Keyboard Shortcuts window translates "h" to "d", but that makes no sense!

If keyboard shortcuts were based on physical keys -- they're not, they change when you change input methods -- then the Keyboard Shortcuts window would be doing the right thing. Instead, it's showing me "d" because typing "d" on Dvorak presses the physical "h" key, but the shortcut is only activated by pressing the logical "h" key (which is the physical "j" key).

Another example:

* The correct shortcut for "Show hidden files in Files" is Ctrl + .
* In Dvorak, I type "." by hitting the physical "e" key.
* Regardless, typing Dvorak's version of Ctrl + . is the correct shotcut.
* The Keyboard Shortcuts window lists the hotkey as "Ctrl + v" because the physical "." key types a "v" in Dvorak. But neither the physical "." key, nor the physical "v" key, activates the shortcut.
Cc: derat@chromium.org martiniss@chromium.org
+some dvorak users to make sure I'm not crazy

Comment 5 by derat@chromium.org, May 17 2018

Mergedinto: 841670
Status: Duplicate (was: Assigned)

Sign in to add a comment