New issue
Advanced search Search tips

Issue 841458 link

Starred by 1 user
Status: Verified
Owner:
kmarshall@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

Runner scripts hang on package SCP errors

Project Member Reported by kmarshall@chromium.org, May 9 2018 
The Fuchsia runner scripts hang if SCP fails or the user terminates the script using ctrl-C.

The issue has to do with the log reader's termination event not being set.
Project Member

Comment 1 by bugdroid1@chromium.org, May 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ec5d217f6fb600a098dfad9124614ea9c06147a

commit 6ec5d217f6fb600a098dfad9124614ea9c06147a
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed May 09 23:05:35 2018

Fuchsia: Send thread kill signal to system logging thread on error.

The runner script will hang if the script is aborted or if an error
occurs during the package copy process, because the system logging
thread will continue to stay alive.

This CL sends an event to the logging thread in the "finally"
block to request that the thread terminate.

Bug:  841458 

Change-Id: Ia5073b86b8d83b576ed67c6ca6dc22ffece4f9c3
Reviewed-on: https://chromium-review.googlesource.com/1052671
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557367}
[modify] https://crrev.com/6ec5d217f6fb600a098dfad9124614ea9c06147a/build/fuchsia/run_package.py

Comment 2 by kmarshall@chromium.org, May 16 2018

Status: Fixed (was: Assigned)

Comment 3 by kmarshall@chromium.org, May 16 2018

Status: Verified (was: Fixed)
►

Sign in to add a comment