New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841446 link

Starred by 3 users
Status: Fixed
Owner:
moh...@chromium.org
Closed: Oct 10
Cc:
sadrul@chromium.org
█ gklassen@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 709332
Blocking:
issue 840391



Sign in to add a comment

Make OopAsh start Viz/Gpu

Project Member Reported by sky@chromium.org, May 9 2018 
For OopAsh the ash process will be the VizHost. Currently viz/gpu are heavily tied with content. In order to convert --mash to --oop-ash we need a way for Ash to start viz. For the short term it's fine to have ash use content for this. Long term viz/gpu should be refactored out of content. This bug is to provide a way for Ash to start viz/gpu (in process).

Comment 1 by zalcorn@chromium.org, May 25 2018

Components: -UI>Shell Internals>Services>Ash

Comment 2 by sky@chromium.org, May 30 2018

Blockedon: 709332

Comment 3 by sky@chromium.org, Aug 27

Labels: Proj-Mash-MultiProcess
Owner: moh...@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by moh...@chromium.org, Sep 27

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9505d8d7411d13996368054a7d24fd88ac629c2

commit f9505d8d7411d13996368054a7d24fd88ac629c2
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Sat Oct 06 01:34:03 2018

Use viz::GpuHostImpl in OopAsh

This CL updates ws::gpu_host::GpuHost to use viz::GpuHostImpl as its
implementation for viz::mojom::GpuHost. It does not replace ws::GpuHost
completely as it still depends ws::GpuClient. A follow-up CL would
replace ws::GpuClient with viz::GpuClient. Then we can probably remove
ws::GpuHost.

BUG= 841446 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ibec183545d235803d6206b93aac27055a72bde26
Reviewed-on: https://chromium-review.googlesource.com/c/1239336
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597392}
[modify] https://crrev.com/f9505d8d7411d13996368054a7d24fd88ac629c2/ash/ash_service.cc
[modify] https://crrev.com/f9505d8d7411d13996368054a7d24fd88ac629c2/components/viz/host/DEPS
[modify] https://crrev.com/f9505d8d7411d13996368054a7d24fd88ac629c2/components/viz/host/gpu_host_impl.cc
[modify] https://crrev.com/f9505d8d7411d13996368054a7d24fd88ac629c2/components/viz/host/gpu_host_impl.h
[modify] https://crrev.com/f9505d8d7411d13996368054a7d24fd88ac629c2/components/viz/test/BUILD.gn
[add] https://crrev.com/f9505d8d7411d13996368054a7d24fd88ac629c2/components/viz/test/gpu_host_impl_test_api.cc
[add] https://crrev.com/f9505d8d7411d13996368054a7d24fd88ac629c2/components/viz/test/gpu_host_impl_test_api.h
[modify] https://crrev.com/f9505d8d7411d13996368054a7d24fd88ac629c2/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/f9505d8d7411d13996368054a7d24fd88ac629c2/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/f9505d8d7411d13996368054a7d24fd88ac629c2/services/ws/gpu_host/BUILD.gn
[modify] https://crrev.com/f9505d8d7411d13996368054a7d24fd88ac629c2/services/ws/gpu_host/DEPS
[modify] https://crrev.com/f9505d8d7411d13996368054a7d24fd88ac629c2/services/ws/gpu_host/gpu_host.cc
[modify] https://crrev.com/f9505d8d7411d13996368054a7d24fd88ac629c2/services/ws/gpu_host/gpu_host.h
[modify] https://crrev.com/f9505d8d7411d13996368054a7d24fd88ac629c2/services/ws/gpu_host/gpu_host_unittest.cc
[delete] https://crrev.com/f0aed3303fadbd016e0073cc212aeb839990b27a/services/ws/gpu_host/test_gpu_host.cc
[delete] https://crrev.com/f0aed3303fadbd016e0073cc212aeb839990b27a/services/ws/gpu_host/test_gpu_host.h
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30588560782b21f7910332d49796948a3b482c19

commit 30588560782b21f7910332d49796948a3b482c19
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Tue Oct 09 03:41:14 2018

Remove GpuHost interface from ws::gpu_host

This interface is not used anymore. Instead, its sole implementation,
formerly called DefaultGpuHost, is renamed to GpuHost.

BUG= 841446 

Change-Id: I4449a2cf4ca06793b9f4f8db04cee4bab5e1cc18
Reviewed-on: https://chromium-review.googlesource.com/c/1243570
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597792}
[modify] https://crrev.com/30588560782b21f7910332d49796948a3b482c19/ash/ash_service.cc
[modify] https://crrev.com/30588560782b21f7910332d49796948a3b482c19/ash/ash_service.h
[modify] https://crrev.com/30588560782b21f7910332d49796948a3b482c19/services/ws/gpu_host/gpu_host.cc
[modify] https://crrev.com/30588560782b21f7910332d49796948a3b482c19/services/ws/gpu_host/gpu_host.h
[modify] https://crrev.com/30588560782b21f7910332d49796948a3b482c19/services/ws/gpu_host/gpu_host_test_api.cc
[modify] https://crrev.com/30588560782b21f7910332d49796948a3b482c19/services/ws/gpu_host/gpu_host_test_api.h
[modify] https://crrev.com/30588560782b21f7910332d49796948a3b482c19/services/ws/gpu_host/gpu_host_unittest.cc
[modify] https://crrev.com/30588560782b21f7910332d49796948a3b482c19/services/ws/test_ws/test_window_service.cc
[modify] https://crrev.com/30588560782b21f7910332d49796948a3b482c19/services/ws/test_ws/test_window_service.h

Comment 7 by moh...@chromium.org, Oct 10

Status: Fixed (was: Started)
OOP-Ash now uses implementations of mojom::GpuHost, mojom::Gpu, and mojom::GpuMemoryBufferFactory provided in //components/viz/host/.
►

Sign in to add a comment