Remove migration code when most users use PasswordHashData |
||||
Issue descriptionIn password_store.cc, migration code is currently in place to migrate the use of SyncPasswordData to PasswordHashData. """ hash_password_manager_.MaybeMigrateExistingSyncPasswordHash(sync_username); """ We should monitor UMA metric ""PasswordManager.IsSyncPasswordHashSaved", to determine if majority of users have completed the migration (SAVED_VIA_LIST_PREF). When it happens, we should remove the migration code.
,
Sep 15
The NextAction date has arrived: 2018-09-15
,
Sep 20
On Chrome OS, there are still >10% of password hash saved in the old format. Let's wait for another milestone to delete these migration code.
,
Sep 27
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e82d33667b68bcd286fb7d887a76ac787268645 commit 9e82d33667b68bcd286fb7d887a76ac787268645 Author: Jialiu Lin <jialiul@chromium.org> Date: Thu Oct 11 21:24:57 2018 Remove migration code and deprecate SyncPasswordData Bug: 841438 Change-Id: I543aba240476c4e2111202a604d20ccdcfcb3d7a Reviewed-on: https://chromium-review.googlesource.com/c/1257559 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#598948} [modify] https://crrev.com/9e82d33667b68bcd286fb7d887a76ac787268645/components/password_manager/core/browser/hash_password_manager.cc [modify] https://crrev.com/9e82d33667b68bcd286fb7d887a76ac787268645/components/password_manager/core/browser/hash_password_manager.h [modify] https://crrev.com/9e82d33667b68bcd286fb7d887a76ac787268645/components/password_manager/core/browser/hash_password_manager_unittest.cc [modify] https://crrev.com/9e82d33667b68bcd286fb7d887a76ac787268645/components/password_manager/core/browser/password_hash_data.cc [modify] https://crrev.com/9e82d33667b68bcd286fb7d887a76ac787268645/components/password_manager/core/browser/password_hash_data.h [modify] https://crrev.com/9e82d33667b68bcd286fb7d887a76ac787268645/components/password_manager/core/browser/password_store.cc
,
Oct 11
,
Oct 20
The NextAction date has arrived: 2018-10-20 |
||||
►
Sign in to add a comment |
||||
Comment 1 by jialiul@chromium.org
, Jul 19