New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841424 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Remove tab switcher card tilt behavior

Project Member Reported by mdjones@chromium.org, May 9 2018

Issue description

The card tilt behavior is one of several unneeded features in the tab switcher. Moving forward we do not want it in modern. We should simply remove this behavior from all versions of the tab switcher to avoid the added logic of supporting both.
 
Here is a recording from my in-flight patch:
recording.mp4
4.1 MB View Download
lgtm! Thanks so much for getting that out so fast!
For now let's keep the stack/unstack behavior when all the tabs are scrolled up for M69. We can explore removing/replacing this post-launch as a follow up.
Project Member

Comment 4 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a517bf87c03dcd4e0223be7e4cc4a22fa8d0d1d7

commit a517bf87c03dcd4e0223be7e4cc4a22fa8d0d1d7
Author: Matthew Jones <mdjones@chromium.org>
Date: Mon May 14 20:54:50 2018

Remove tab tilt behavior on overscroll in tab switcher

This patch removes the tab tilting behavior during overscroll in the
tab switcher. This patch keeps the full-roll easter egg.

Bug:  841424 
Change-Id: I0ab57f9012a4fd05c92afe427e8886459f5e0086
Reviewed-on: https://chromium-review.googlesource.com/1056160
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558452}
[modify] https://crrev.com/a517bf87c03dcd4e0223be7e4cc4a22fa8d0d1d7/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/Stack.java

Status: Fixed (was: Assigned)
Issue 835396 has been merged into this issue.

Sign in to add a comment