Include RLZ VPD keys into metrics |
|||||||
Issue descriptionWe need to add the RLZ VPD keys to the list of documented keys in check_rw_vpd to prevent pollution of the Platform.Vpd.UnknownKeys metrics.
,
May 14 2018
Manually verified on 10675.0.0. Requesting merge to 67 for this metrics-only change which prevents the rlz_embargo_end_date and should_send_rlz_ping VPD keys from being counted as unknown.
,
May 14 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 14 2018
Approving merge to M67 Chrome OS since should be a no-impact change to prod systems.
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vpd/+/f324c33e424b5d12ab1f00e0b2d9c5b10fd7e23d commit f324c33e424b5d12ab1f00e0b2d9c5b10fd7e23d Author: Thiemo Nagel <tnagel@chromium.org> Date: Mon May 14 16:09:23 2018 vpd: Add RLZ-related keys to check_rw_vpd Adding: rlz_embargo_end_date should_send_rlz_ping BRANCH=none BUG= chromium:841394 TEST=none Change-Id: I43d47dcfc1ba05263d6cb438b469732868d91c25 Reviewed-on: https://chromium-review.googlesource.com/1052468 Commit-Ready: Thiemo Nagel <tnagel@chromium.org> Tested-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Stephen Lin <stephenlin@google.com> Reviewed-by: Thiemo Nagel <tnagel@chromium.org> (cherry picked from commit 1c1806d8df4bb5976eed71a2e2bf156c36ccdce2) Reviewed-on: https://chromium-review.googlesource.com/1057170 Commit-Queue: Thiemo Nagel <tnagel@chromium.org> [modify] https://crrev.com/f324c33e424b5d12ab1f00e0b2d9c5b10fd7e23d/util/check_rw_vpd
,
May 14 2018
Thanks a lot, Kevin!
,
May 17 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 17 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, May 10 2018