New issue
Advanced search Search tips

Issue 841364 link

Starred by 2 users
Status: Started
Owner:
sunxd@chromium.org
Cc:
flackr@chromium.org
xidac...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 700075



Sign in to add a comment

Compute correct wheel event handler regions for cc

Project Member Reported by sunxd@chromium.org, May 9 2018 
We now mark the whole cc layer tree with event properties block when there is a wheel event handler. This could be improved as usually the wheel event handler region is smaller than the whole page, we want to compute the correct region for cc and unblock scroll events occurred outside the region.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f98e813703e762f5311f808d601f229bb39d3c9

commit 9f98e813703e762f5311f808d601f229bb39d3c9
Author: sunxd <sunxd@chromium.org>
Date: Thu Aug 16 15:34:49 2018

Rename HasWheelEventHandlerAt to HasBlockingWheelEventHandlerAt

The original name is confusing given that there might be passive event
handlers, but the function only returns true if event listener property
is Blocking or BlockingAndPassive. This CL renames the function name for
better readability.

Bug: 841364
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia6e28347e33fd28d3cc4954b307010fe2861dbfb
Reviewed-on: https://chromium-review.googlesource.com/1176108
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583661}
[modify] https://crrev.com/9f98e813703e762f5311f808d601f229bb39d3c9/cc/input/input_handler.h
[modify] https://crrev.com/9f98e813703e762f5311f808d601f229bb39d3c9/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/9f98e813703e762f5311f808d601f229bb39d3c9/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/9f98e813703e762f5311f808d601f229bb39d3c9/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/9f98e813703e762f5311f808d601f229bb39d3c9/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/9f98e813703e762f5311f808d601f229bb39d3c9/ui/events/blink/input_handler_proxy_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/751457a662bbce4f7da8f43c8ea5e7764ad0b20f

commit 751457a662bbce4f7da8f43c8ea5e7764ad0b20f
Author: sunxd <sunxd@chromium.org>
Date: Sat Sep 29 21:09:57 2018

Rename TouchActionRect to HitTestRect

We are going to implement wheel event handler region computation in
ScrollingCoordinator and painting, since wheel event regions share many
similarities to touch action rects, we want to use the same code path
for wheel events. As a result, TouchActionRect will store wheel data as
well and they should be renamed to HitTestRect.

Bug: 841364
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1d9c967033846d1945163192a437f11cbebdf641
Reviewed-on: https://chromium-review.googlesource.com/1239490
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595330}
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/core/layout/layout_object.cc
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/core/layout/layout_object.h
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.h
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/core/paint/block_painter.cc
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/core/paint/inline_flow_box_painter.cc
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/core/paint/replaced_painter.cc
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/core/paint/svg_model_object_painter.cc
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/core/paint/svg_text_painter.cc
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/core/paint/table_painter.cc
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/core/paint/table_row_painter.cc
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/platform/BUILD.gn
[add] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/platform/graphics/hit_test_rect.cc
[add] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/platform/graphics/hit_test_rect.h
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/platform/graphics/paint/hit_test_data.cc
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/platform/graphics/paint/hit_test_data.h
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/platform/graphics/paint/paint_chunk.cc
[modify] https://crrev.com/751457a662bbce4f7da8f43c8ea5e7764ad0b20f/third_party/blink/renderer/platform/graphics/paint/paint_chunk.h
[delete] https://crrev.com/6ea9f0aa34c684520d7bf4d8ba733941e78cfa23/third_party/blink/renderer/platform/graphics/touch_action_rect.cc
[delete] https://crrev.com/6ea9f0aa34c684520d7bf4d8ba733941e78cfa23/third_party/blink/renderer/platform/graphics/touch_action_rect.h

Comment 3 by xidac...@chromium.org, Nov 16

Cc: xidac...@chromium.org
►

Sign in to add a comment