New issue
Advanced search Search tips

Issue 841360 link

Starred by 1 user
Status: Fixed
Owner:
liber...@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 832852



Sign in to add a comment

ffmpeg includes v4l2 too often

Project Member Reported by liber...@chromium.org, May 9 2018 
even with v4l2-m2m and libv4l2 disabled on the configure command line, several v4l2 files end up in ffmpeg_generated.gni .

to get around this, i added an explicit check in configure for whether v4l2 is enabled, and skip all of it otherwise.
Project Member

Comment 1 by bugdroid1@chromium.org, May 9 2018

Labels: merge-merged-merge-m68
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/a5ef4a7a43af84dda13a34db34d709bad59f004c

commit a5ef4a7a43af84dda13a34db34d709bad59f004c
Author: liberato@chromium.org <liberato@chromium.org>
Date: Wed May 09 21:25:13 2018

Explicitly turn off v4l2 in configure.

configure seems to enable v4l2-m2m even if we explicitly turn it
off with arguments.

This CL makes configure check the command-line arguments, and skip
v4l2 (and v4l2-m2m) if they're turned off.

Bug:  841360 
Change-Id: I3c597c12e91631ecd9b526cdea056e064901e008
Reviewed-on: https://chromium-review.googlesource.com/1052372
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>

[modify] https://crrev.com/a5ef4a7a43af84dda13a34db34d709bad59f004c/configure
[modify] https://crrev.com/a5ef4a7a43af84dda13a34db34d709bad59f004c/chromium/patches/README

Comment 2 by liber...@chromium.org, May 9 2018

Status: Fixed (was: Started)
►

Sign in to add a comment