New issue
Advanced search Search tips

Issue 841358 link

Starred by 2 users
Status: Fixed
Owner:
sunxd@chromium.org
Closed: Sep 6
Cc:
flackr@chromium.org
rjkroege@chromium.org
riajiang@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 823888
issue 874919



Sign in to add a comment

Prevent hit testing on pointer-events:none surface layers.

Project Member Reported by sunxd@chromium.org, May 9 2018 
cc layers now supply viz with hit test data, but it is not aware of the information of pointer-events: none. We want to instead of using draws_content || hit_testable_without_drawing, use a bool bit hit_testable to represent whether the layer is hit testable.

The bool will be set by blink and hit_testable = (draws_content || hit_testable_without_drawing) && (style.pointerEvents != None) && (!inert).

We also need to change cc::SurfaceLayer's hit_testable bit to a more specific name surface_hit_testable for disambiguation.
Project Member

Comment 1 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2869c922761bb8075bd86a93482b04f9ef33672d

commit 2869c922761bb8075bd86a93482b04f9ef33672d
Author: sunxd <sunxd@chromium.org>
Date: Mon May 14 20:48:32 2018

Rename SurfaceLayer::hit_testable_ to surface_hit_testable_

We want to propagate pointer-events: none information to cc to generate
correct hit testing data for viz. The plan is to have blink set the hit
testable bit on cc::Layers. In order to disambiguate the bit in surface
layer that represents the origin of the surface, we want to rename the
variable.

Bug:  841358 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I207815dcfad0f29b222b0a39c350f1e926aedac9
Reviewed-on: https://chromium-review.googlesource.com/1052506
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558450}
[modify] https://crrev.com/2869c922761bb8075bd86a93482b04f9ef33672d/cc/layers/surface_layer.cc
[modify] https://crrev.com/2869c922761bb8075bd86a93482b04f9ef33672d/cc/layers/surface_layer.h
[modify] https://crrev.com/2869c922761bb8075bd86a93482b04f9ef33672d/cc/layers/surface_layer_impl.cc
[modify] https://crrev.com/2869c922761bb8075bd86a93482b04f9ef33672d/cc/layers/surface_layer_impl.h
[modify] https://crrev.com/2869c922761bb8075bd86a93482b04f9ef33672d/components/viz/client/hit_test_data_provider_surface_layer.cc
[modify] https://crrev.com/2869c922761bb8075bd86a93482b04f9ef33672d/components/viz/client/hit_test_data_provider_surface_layer_unittest.cc
[modify] https://crrev.com/2869c922761bb8075bd86a93482b04f9ef33672d/content/renderer/child_frame_compositing_helper.cc
[modify] https://crrev.com/2869c922761bb8075bd86a93482b04f9ef33672d/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/2869c922761bb8075bd86a93482b04f9ef33672d/ui/compositor/layer.cc
[modify] https://crrev.com/2869c922761bb8075bd86a93482b04f9ef33672d/ui/compositor/layer_unittest.cc

Comment 2 by sunxd@chromium.org, Aug 16

Blocking: 874919
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc

commit 2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc
Author: sunxd <sunxd@chromium.org>
Date: Thu Sep 06 21:26:50 2018

Do not hit test OOPIFs with pointer-events: none

Frame owners may have pointer-events: none property which blocks them
from receiving mouse and touch events. Currently in V2 viz hit testing
hit test data provider has no information about whether OOPIFs have
pointer-events: none property.

This CL plumbs pointer-events: none property from HTMLFrameOwnerElement
to cc::SurfaceLayer so that the hit test data provider in LayerTreeHostImpl
will be able to generate proper hit test data for pointer-events: none
OOPIFs.

Bug:  841358 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I381c8f0b1dcfb14b7ef24c7b2b3806ae60ec4182
Reviewed-on: https://chromium-review.googlesource.com/1127440
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589306}
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/cc/layers/surface_layer.cc
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/cc/layers/surface_layer.h
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/cc/layers/surface_layer_impl.cc
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/cc/layers/surface_layer_impl.h
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/components/viz/common/features.cc
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/content/browser/site_per_process_hit_test_browsertest.cc
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/content/renderer/child_frame_compositing_helper.cc
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/content/renderer/child_frame_compositing_helper.h
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/content/renderer/child_frame_compositing_helper_unittest.cc
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/content/renderer/child_frame_compositor.h
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/content/test/data/frame_tree/page_with_positioned_frame_pointer-events_none.html
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/third_party/blink/public/web/web_remote_frame.h
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/third_party/blink/public/web/web_remote_frame_client.h
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/third_party/blink/renderer/core/exported/web_remote_frame_impl.cc
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/third_party/blink/renderer/core/exported/web_remote_frame_impl.h
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/third_party/blink/renderer/core/frame/remote_frame.cc
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/third_party/blink/renderer/core/frame/remote_frame.h
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/third_party/blink/renderer/core/frame/remote_frame_client.h
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/third_party/blink/renderer/core/frame/remote_frame_client_impl.cc
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/third_party/blink/renderer/core/frame/remote_frame_client_impl.h
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/third_party/blink/renderer/core/html/html_frame_owner_element.h
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/third_party/blink/renderer/core/layout/layout_embedded_content.cc
[modify] https://crrev.com/2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc/ui/compositor/layer_unittest.cc

Comment 4 by sunxd@chromium.org, Sep 6

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97b4f8c0a5fcad06608f21b05a539be2ea2703e4

commit 97b4f8c0a5fcad06608f21b05a539be2ea2703e4
Author: Justin Donnelly <jdonnelly@chromium.org>
Date: Fri Sep 07 16:26:09 2018

Revert "Do not hit test OOPIFs with pointer-events: none"

This reverts commit 2c0b1626adf748ef1b4b57b5f81e2a8a80d7a6dc.

Reason for revert: The "SitePerProcessHitTestDataGenerationBrowserTest.PointerEventsNoneOOPIF/2" test is broken on the Android CFI bot:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2797

Original change's description:
> Do not hit test OOPIFs with pointer-events: none
> 
> Frame owners may have pointer-events: none property which blocks them
> from receiving mouse and touch events. Currently in V2 viz hit testing
> hit test data provider has no information about whether OOPIFs have
> pointer-events: none property.
> 
> This CL plumbs pointer-events: none property from HTMLFrameOwnerElement
> to cc::SurfaceLayer so that the hit test data provider in LayerTreeHostImpl
> will be able to generate proper hit test data for pointer-events: none
> OOPIFs.
> 
> Bug:  841358 
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I381c8f0b1dcfb14b7ef24c7b2b3806ae60ec4182
> Reviewed-on: https://chromium-review.googlesource.com/1127440
> Commit-Queue: Xianda Sun <sunxd@chromium.org>
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589306}

TBR=rjkroege@chromium.org,flackr@chromium.org,kenrb@chromium.org,pdr@chromium.org,chrishtr@chromium.org,fsamuel@chromium.org,sunxd@chromium.org,joelhockey@chromium.org,riajiang@chromium.org,gklassen@chromium.org

Change-Id: I5fc43bd1b5dd60312ff9046802f8ac18b8f2e6bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  841358 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1213823
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589542}
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/cc/layers/surface_layer.cc
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/cc/layers/surface_layer.h
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/cc/layers/surface_layer_impl.cc
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/cc/layers/surface_layer_impl.h
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/components/viz/common/features.cc
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/content/browser/site_per_process_hit_test_browsertest.cc
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/content/renderer/child_frame_compositing_helper.cc
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/content/renderer/child_frame_compositing_helper.h
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/content/renderer/child_frame_compositing_helper_unittest.cc
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/content/renderer/child_frame_compositor.h
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/content/test/data/frame_tree/page_with_positioned_frame_pointer-events_none.html
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/third_party/blink/public/web/web_remote_frame.h
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/third_party/blink/public/web/web_remote_frame_client.h
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/third_party/blink/renderer/core/exported/web_remote_frame_impl.cc
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/third_party/blink/renderer/core/exported/web_remote_frame_impl.h
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/third_party/blink/renderer/core/frame/remote_frame.cc
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/third_party/blink/renderer/core/frame/remote_frame.h
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/third_party/blink/renderer/core/frame/remote_frame_client.h
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/third_party/blink/renderer/core/frame/remote_frame_client_impl.cc
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/third_party/blink/renderer/core/frame/remote_frame_client_impl.h
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/third_party/blink/renderer/core/html/html_frame_owner_element.h
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/third_party/blink/renderer/core/layout/layout_embedded_content.cc
[modify] https://crrev.com/97b4f8c0a5fcad06608f21b05a539be2ea2703e4/ui/compositor/layer_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c02c059891de67fa3b2ef879a322f5b01db87ab8

commit c02c059891de67fa3b2ef879a322f5b01db87ab8
Author: sunxd <sunxd@chromium.org>
Date: Wed Sep 12 18:27:22 2018

Reland: Do not hit test OOPIFs with pointer-events: none

Frame owners may have pointer-events: none property which blocks them
from receiving mouse and touch events. Currently in V2 viz hit testing
hit test data provider has no information about whether OOPIFs have
pointer-events: none property.

This CL plumbs pointer-events: none property from HTMLFrameOwnerElement
to cc::SurfaceLayer so that the hit test data provider in LayerTreeHostImpl
will be able to generate proper hit test data for pointer-events: none
OOPIFs.

The patch was reverted due to flaky browser test, we are relanding it by
fixing the flakiness. The original patch also triggered a clusterfuzz bug,
it is also fixed in this one.

Bug:  841358 ,  881917 ,  881703 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I66bf72095e5501c37b01beda134a583bf216c5b7
Reviewed-on: https://chromium-review.googlesource.com/1213538
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590755}
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/cc/layers/surface_layer.cc
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/cc/layers/surface_layer.h
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/cc/layers/surface_layer_impl.cc
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/cc/layers/surface_layer_impl.h
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/components/viz/common/features.cc
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/browser/site_per_process_hit_test_browsertest.cc
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/child_frame_compositing_helper.cc
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/child_frame_compositing_helper.h
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/child_frame_compositing_helper_unittest.cc
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/child_frame_compositor.h
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/test/data/frame_tree/page_with_positioned_frame_pointer-events_none.html
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/public/web/web_remote_frame.h
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/public/web/web_remote_frame_client.h
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/exported/web_remote_frame_impl.cc
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/exported/web_remote_frame_impl.h
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/frame/remote_frame.cc
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/frame/remote_frame.h
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/frame/remote_frame_client.h
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/frame/remote_frame_client_impl.cc
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/frame/remote_frame_client_impl.h
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/html/html_frame_owner_element.h
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/layout/layout_embedded_content.cc
[modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/ui/compositor/layer_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf

commit 02a0bc1278a5f419764a82b8df7b1f5b181d1cbf
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Sep 19 00:42:09 2018

Simplify plumbing pointer-events:none for a remote frame's surface layer

Rather than plumb this through several layers so that //content can set
the corresponding bit, just set it directly from Blink.

Bug:  841358 
Change-Id: Id3fd32f75f07b5c8361220ee44402ce403e624c4
Reviewed-on: https://chromium-review.googlesource.com/1225931
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592284}
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/content/renderer/child_frame_compositing_helper.cc
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/content/renderer/child_frame_compositing_helper.h
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/content/renderer/child_frame_compositing_helper_unittest.cc
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/content/renderer/child_frame_compositor.h
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/third_party/blink/public/web/web_remote_frame.h
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/third_party/blink/public/web/web_remote_frame_client.h
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/third_party/blink/renderer/core/DEPS
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/third_party/blink/renderer/core/exported/web_remote_frame_impl.cc
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/third_party/blink/renderer/core/exported/web_remote_frame_impl.h
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/third_party/blink/renderer/core/frame/remote_frame.cc
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/third_party/blink/renderer/core/frame/remote_frame.h
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/third_party/blink/renderer/core/frame/remote_frame_client.h
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/third_party/blink/renderer/core/frame/remote_frame_client_impl.cc
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/third_party/blink/renderer/core/frame/remote_frame_client_impl.h
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf/third_party/blink/renderer/core/html/html_frame_owner_element.h
►

Sign in to add a comment