New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841351 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 744736



Sign in to add a comment

results_dashboard should gzip when uploading

Project Member Reported by eyaich@chromium.org, May 9 2018

Issue description

Cc: benjhayden@chromium.org
+benjhayden

Think this is the failure: Error uploading histogram data: HTTP Response 413: Request Entity Too Large


Ethan, think we'll need to roll back for this benchmark and investigate.
Labels: -Pri-1 Pri-2
Summary: results_dashboard should gzip when uploading (was: system_health.memory_desktop dashboard upload failures across chromium.perf)
Revert landed here https://chromium-review.googlesource.com/c/chromium/src/+/1052407

so lowering to P2 and changing the focus of this bug to be about uploading gzip. Catapult-side bug for the dashboard feature here: https://github.com/catapult-project/catapult/issues/4443
Labels: -Type-Bug-Regression Type-Feature
Status: Assigned (was: Untriaged)
Blocking: 744736
Project Member

Comment 6 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/837dcdddfbec5cefc77174776c27acad46220c2a

commit 837dcdddfbec5cefc77174776c27acad46220c2a
Author: Ethan Kuefner <eakuefner@chromium.org>
Date: Thu May 10 13:03:08 2018

[Perf] Compress histogram data before uploading (OBBS)

This is the OBBS-side version of
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1052920

Bug:  841351 
Change-Id: Ie863c647ecd93ebeda326b00ebcad1543db0f7ef
Reviewed-on: https://chromium-review.googlesource.com/1053048
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557499}
[modify] https://crrev.com/837dcdddfbec5cefc77174776c27acad46220c2a/tools/perf/core/results_dashboard.py

Project Member

Comment 7 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/807797c61928cfb29977b2598f8c89da8e6c58c3

commit 807797c61928cfb29977b2598f8c89da8e6c58c3
Author: Ethan Kuefner <eakuefner@chromium.org>
Date: Mon May 14 16:30:24 2018

[Build] Compress histogram data before uploading

We're seeing some HistogramSets (e.g. from system_health) that are too large
for the POST body. So, let's compress them before we upload.

Matching Dashboard-side functionality has already landed in
https://chromium-review.googlesource.com/c/catapult/+/1052668

Bug:  841351 
Change-Id: I0f3187d89a3d1b5a84718a4c9763f90159d43b07
Reviewed-on: https://chromium-review.googlesource.com/1052920
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/807797c61928cfb29977b2598f8c89da8e6c58c3/scripts/slave/results_dashboard.py

Status: Fixed (was: Assigned)
This is done.

Sign in to add a comment