results_dashboard should gzip when uploading |
||||||
Issue descriptionhttps://uberchromegw.corp.google.com/i/chromium.perf/waterfall An example log from Mac 10.11. Looks like the histogram merge is failing: https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FMac_Air_10.11_Perf%2F2186%2F%2B%2Frecipes%2Fsteps%2Fsystem_health.memory_desktop_Dashboard_Upload%2F0%2Fstdout
,
May 9 2018
Revert landed here https://chromium-review.googlesource.com/c/chromium/src/+/1052407 so lowering to P2 and changing the focus of this bug to be about uploading gzip. Catapult-side bug for the dashboard feature here: https://github.com/catapult-project/catapult/issues/4443
,
May 9 2018
,
May 9 2018
,
May 9 2018
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/837dcdddfbec5cefc77174776c27acad46220c2a commit 837dcdddfbec5cefc77174776c27acad46220c2a Author: Ethan Kuefner <eakuefner@chromium.org> Date: Thu May 10 13:03:08 2018 [Perf] Compress histogram data before uploading (OBBS) This is the OBBS-side version of https://chromium-review.googlesource.com/c/chromium/tools/build/+/1052920 Bug: 841351 Change-Id: Ie863c647ecd93ebeda326b00ebcad1543db0f7ef Reviewed-on: https://chromium-review.googlesource.com/1053048 Reviewed-by: Simon Hatch <simonhatch@chromium.org> Reviewed-by: Emily Hanley <eyaich@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#557499} [modify] https://crrev.com/837dcdddfbec5cefc77174776c27acad46220c2a/tools/perf/core/results_dashboard.py
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/807797c61928cfb29977b2598f8c89da8e6c58c3 commit 807797c61928cfb29977b2598f8c89da8e6c58c3 Author: Ethan Kuefner <eakuefner@chromium.org> Date: Mon May 14 16:30:24 2018 [Build] Compress histogram data before uploading We're seeing some HistogramSets (e.g. from system_health) that are too large for the POST body. So, let's compress them before we upload. Matching Dashboard-side functionality has already landed in https://chromium-review.googlesource.com/c/catapult/+/1052668 Bug: 841351 Change-Id: I0f3187d89a3d1b5a84718a4c9763f90159d43b07 Reviewed-on: https://chromium-review.googlesource.com/1052920 Commit-Queue: Simon Hatch <simonhatch@chromium.org> Reviewed-by: Simon Hatch <simonhatch@chromium.org> Reviewed-by: Emily Hanley <eyaich@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/807797c61928cfb29977b2598f8c89da8e6c58c3/scripts/slave/results_dashboard.py
,
May 22 2018
This is done. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by simonhatch@chromium.org
, May 9 2018