New issue
Advanced search Search tips

Issue 841348 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Traffic light buttons no longer aligned in MD refresh

Project Member Reported by sdy@chromium.org, May 9 2018

Issue description

Chrome Version: 68.0.3425.0
OS: macOS

See screenshot.
 
Screen Shot 2018-05-09 at 11.25.13 AM.png
15.1 KB View Download
I think this was a result of https://chromium-review.googlesource.com/c/chromium/src/+/1029173

Moving them 3px down would look nice again :)

BTW: I noticed that we have a "dead drag space" now. In this area dragging the window doesn't work anymore :( 
Buttons_3px_down.png
36.0 KB View Download
Dead_Drag_Space.png
103 KB View Download

Comment 2 by gov...@chromium.org, May 23 2018

Labels: Target-69
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b3c8c76f9eb311a4474d427bb2b0f81f402034c

commit 6b3c8c76f9eb311a4474d427bb2b0f81f402034c
Author: Sidney San Martín <sdy@chromium.org>
Date: Wed Jun 06 04:58:27 2018

Calculate Mac window title bar height dynamically.

This fixes the window button position for MD refresh.

Bug:  841348 
Change-Id: Ib313a773a6a220cb8e3e39c944325e4a105ec7ad
Reviewed-on: https://chromium-review.googlesource.com/1081053
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564791}
[modify] https://crrev.com/6b3c8c76f9eb311a4474d427bb2b0f81f402034c/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm

Looks nicely aligned again in latest Chromium Snapshot #564926.

The "dead drag space" issue is also fixed now 👍

Thanks sdy@!
Bildschirmfoto 2018-06-06 um 19.40.03.png
16.7 KB View Download

Comment 5 by sdy@chromium.org, Jun 6 2018

Cc: ellyjo...@chromium.org pkasting@chromium.org sdy@chromium.org
 Issue 848430  has been merged into this issue.
Labels: Needs-Feedback
Tried  verifying the issue as per the test steps from the duped   Issue 848430  
but somehow unable to reproduce the issue on the reported version 68.0.3425.0 itself. 
Could someone help us in verifying the fix on canary.

Thanks!
You may need to turn the "top chrome MD" flag to "material refresh" -- it's probably not that way automatically.

(BTW, I thought we were trying to align the traffic lights with the favicons rather than centering in the vertical space; but not sure.)

Comment 8 by sdy@chromium.org, Jun 7 2018

Status: Fixed (was: Assigned)
We tried it both ways and they both looked odd, so we settled on centered as looking somewhat better. Here are screenshots of both, if you want to compare/have any other ideas.
traffic_lights_favicon_aligned.png
272 KB View Download
traffic_lights_center_aligned.png
272 KB View Download
My personal preference is favicon-algined, but I don't use Mac enough for my opinion to have merit.  As long as bettes@ and the Mac folks like this route, it's good with me.

Comment 10 by sdy@chromium.org, Jun 7 2018

Center-aligned is currently the consensus among Mac folks and bettes@, but it's not set in stone yet.

Sign in to add a comment