Traffic light buttons no longer aligned in MD refresh |
|||||
Issue descriptionChrome Version: 68.0.3425.0 OS: macOS See screenshot.
,
May 23 2018
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b3c8c76f9eb311a4474d427bb2b0f81f402034c commit 6b3c8c76f9eb311a4474d427bb2b0f81f402034c Author: Sidney San Martín <sdy@chromium.org> Date: Wed Jun 06 04:58:27 2018 Calculate Mac window title bar height dynamically. This fixes the window button position for MD refresh. Bug: 841348 Change-Id: Ib313a773a6a220cb8e3e39c944325e4a105ec7ad Reviewed-on: https://chromium-review.googlesource.com/1081053 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#564791} [modify] https://crrev.com/6b3c8c76f9eb311a4474d427bb2b0f81f402034c/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm
,
Jun 6 2018
Looks nicely aligned again in latest Chromium Snapshot #564926. The "dead drag space" issue is also fixed now 👍 Thanks sdy@!
,
Jun 6 2018
Issue 848430 has been merged into this issue.
,
Jun 7 2018
Tried verifying the issue as per the test steps from the duped Issue 848430 but somehow unable to reproduce the issue on the reported version 68.0.3425.0 itself. Could someone help us in verifying the fix on canary. Thanks!
,
Jun 7 2018
You may need to turn the "top chrome MD" flag to "material refresh" -- it's probably not that way automatically. (BTW, I thought we were trying to align the traffic lights with the favicons rather than centering in the vertical space; but not sure.)
,
Jun 7 2018
We tried it both ways and they both looked odd, so we settled on centered as looking somewhat better. Here are screenshots of both, if you want to compare/have any other ideas.
,
Jun 7 2018
My personal preference is favicon-algined, but I don't use Mac enough for my opinion to have merit. As long as bettes@ and the Mac folks like this route, it's good with me.
,
Jun 7 2018
Center-aligned is currently the consensus among Mac folks and bettes@, but it's not set in stone yet. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by meh...@chromium.org
, May 9 201836.0 KB
36.0 KB View Download
103 KB
103 KB View Download