Regression: BackgroundFetch download notifications do not show |
||||
Issue descriptionBackground Fetch notifications do not show up both on Android and on Desktop (Linux) for Chrome ToT builds (68) Other download notifications are showing up as usual. Assigning to Shakti for initial triage, thanks!
,
May 10 2018
Bumping to P1 as this is blocking development on our end. is_transient in the OfflineItem struct (https://cs.chromium.org/chromium/src/components/offline_items_collection/core/offline_item.h?rcl=4a4f739bcda82268926827d28eb058e2f716537e&l=106) is defined as: // Whether or not this item is transient. Transient items won't show up in // persistent UI spaces and will only show up as notifications. I'm proposing a CL shortly.
,
May 10 2018
Updating owner & status because it sounds like you're working on this Mugdha, please change back if incorrect.
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef7b418e2945c4f2cc146b14d12f9f90bbc49887 commit ef7b418e2945c4f2cc146b14d12f9f90bbc49887 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Fri May 11 00:41:35 2018 Download : Removed isTransient check from background fetch notifications Transient downloads are meant not to show up in download home. However notifications must be shown during the download. This was broken recently due to a change which affected background fetch notifications to get lost. Restoring this behavior. Bug: 841344 Change-Id: I034b9761b0bd33275e23a298691b49e0db7f6d3f Reviewed-on: https://chromium-review.googlesource.com/1052891 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557740} [modify] https://crrev.com/ef7b418e2945c4f2cc146b14d12f9f90bbc49887/chrome/android/java/src/org/chromium/chrome/browser/download/items/OfflineContentAggregatorNotificationBridgeUi.java
,
May 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by na...@chromium.org
, May 9 2018