New issue
Advanced search Search tips

Issue 841313 link

Starred by 4 users
Status: Verified
Owner:
jam@chromium.org
Closed: Aug 16
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug
Proj-Servicification

Blocked on:
issue 852871
Blocking:
issue 840359



Sign in to add a comment

Implement Google-related-pref URL/header munging w/Network Service

Project Member Reported by morlovich@chromium.org, May 9 2018 
Currently ChromeNetworkDelegate does 3 bits of URL/header alteration based on prefs that relate to various Google properties:
- forcing safe mode on search
- forcing restricted mode on youtube
- some sort of Google Apps domains thing.

These should all clearly happen someplace in chrome/, with no specific support from the NetworkService, but of course ChromeNetworkDelegate approach won't work with Network Service, so some new approach is needed

Comment 1 by morlovich@chromium.org, May 9 2018

Blocking: 840359

Comment 2 by dxie@chromium.org, May 14 2018

Labels: -Pri-3 Proj-Servicification-Canary OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2
Status: Available (was: Untriaged)

Comment 3 by mmenke@chromium.org, Jun 14 2018 

 Issue 852859  has been merged into this issue.

Comment 4 by mmenke@chromium.org, Jun 14 2018 

 Issue 852861  has been merged into this issue.

Comment 5 by mmenke@chromium.org, Jun 14 2018 

 Issue 852858  has been merged into this issue.

Comment 6 by mmenke@chromium.org, Jun 14 2018

Blockedon: 852871

Comment 7 by mmenke@chromium.org, Jul 3

Components: Enterprise
Labels: -Pri-2 Pri-1
Adding the Enterprise label.  All three of these features look to have been added by the Enterprise team.  Also marking as Canary blocking, as this is something we presumably don't want to break, even on Canary.

Comment 8 by rsorokin@chromium.org, Jul 4

Components: Internals>Network
Labels: Enterprise-Triaged
Owner: ljusten@chromium.org
Lutz, could you please take a look? Since you touched some network settings recently (kinda).

Comment 9 by ljusten@chromium.org, Jul 4

Owner: mmenke@chromium.org
Matt, I'm somewhat familiar with the Youtube policy from my Noogler project, but I'm not familiar with the network service and this seems to require deeper knowledge of that service, so I feel I'm not the right person. Please let me know if you have any questions about the policies, though.

Comment 10 by ljusten@chromium.org, Jul 4

Status: Assigned (was: Available)

Comment 11 by mmenke@chromium.org, Jul 9

Owner: ----
Status: Available (was: Assigned)
I was merely filing bugs for things that need to get done before launching the network service.  I was certainly not volunteering to single-handedly do everything needed to launch the network service.

Comment 12 by dxie@chromium.org, Jul 11

Owner: jam@chromium.org
Status: Assigned (was: Available)

Comment 13 by jam@chromium.org, Jul 25

Status: Started (was: Assigned)
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f7fc91ec1d7c92489022ca54b71995af916d4ce

commit 1f7fc91ec1d7c92489022ca54b71995af916d4ce
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Jul 26 02:48:06 2018

Refactor SigninUpdater so that it's more generic.

This change moves it to a more generic name, RendererUpdater, in preparation for sending a few more pref updates. The only behavior change is to fix sending signin-notifications to renderers that share the same Profile as where the notification is coming from.

Bug:  841313 
Change-Id: I3d408cca35cdc89e1fc0cf8d9b0a43c9e172e739
Reviewed-on: https://chromium-review.googlesource.com/1150825
Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578176}
[modify] https://crrev.com/1f7fc91ec1d7c92489022ca54b71995af916d4ce/chrome/browser/BUILD.gn
[modify] https://crrev.com/1f7fc91ec1d7c92489022ca54b71995af916d4ce/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/1f7fc91ec1d7c92489022ca54b71995af916d4ce/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[add] https://crrev.com/1f7fc91ec1d7c92489022ca54b71995af916d4ce/chrome/browser/profiles/renderer_updater.cc
[add] https://crrev.com/1f7fc91ec1d7c92489022ca54b71995af916d4ce/chrome/browser/profiles/renderer_updater.h
[add] https://crrev.com/1f7fc91ec1d7c92489022ca54b71995af916d4ce/chrome/browser/profiles/renderer_updater_factory.cc
[add] https://crrev.com/1f7fc91ec1d7c92489022ca54b71995af916d4ce/chrome/browser/profiles/renderer_updater_factory.h
[delete] https://crrev.com/aaa9e0f5eb0c570bd9fd06f351a0b45191f24ba9/chrome/browser/signin/signin_updater.cc
[delete] https://crrev.com/aaa9e0f5eb0c570bd9fd06f351a0b45191f24ba9/chrome/browser/signin/signin_updater.h
[delete] https://crrev.com/aaa9e0f5eb0c570bd9fd06f351a0b45191f24ba9/chrome/browser/signin/signin_updater_factory.cc
[delete] https://crrev.com/aaa9e0f5eb0c570bd9fd06f351a0b45191f24ba9/chrome/browser/signin/signin_updater_factory.h
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cf3d7f024aec446ac1d9865c20950ab76c653d5

commit 9cf3d7f024aec446ac1d9865c20950ab76c653d5
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Jul 27 02:40:39 2018

Move google_util from components/google/browser to components/google/common so that it can be called in the renderer.

Bug:  841313 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I751bf47bf452e6dc365939131fd1e95ceee64d50
Reviewed-on: https://chromium-review.googlesource.com/1152502
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578523}
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/android_webview/DEPS
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/android_webview/browser/aw_contents_statics.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/android/signin/signin_manager_android.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/android/url_utilities.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/download/download_commands.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/net/dns_probe_browsertest.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/net/safe_search_util.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/plugins/plugin_infobar_delegates.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/prerender/prerender_histograms.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/prerender/prerender_util.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/printing/print_dialog_cloud.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/printing/print_dialog_cloud_win.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/rlz/chrome_rlz_tracker_delegate.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/safe_browsing/chrome_password_protection_service.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/safe_browsing/download_protection/download_protection_service.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/safe_browsing/safe_browsing_util.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/search/one_google_bar/one_google_bar_loader_impl.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/search/search.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/search_engines/template_url_service_android.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/search_engines/ui_thread_search_terms_data.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/signin/signin_promo.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/supervised_user/supervised_user_google_auth_navigation_throttle.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/ui/navigation_correction_tab_observer.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/ui/search/search_tab_helper.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/ui/toolbar/chrome_toolbar_model_delegate.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/ui/views/sync/one_click_signin_dialog_view.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/ui/webui/settings/about_handler.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/browser/ui/webui/settings/protocol_handlers_handler.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/arc/intent_helper/DEPS
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/arc/intent_helper/link_handler_model.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/google/DEPS
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/google/core/browser/BUILD.gn
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/google/core/browser/DEPS
[delete] https://crrev.com/9d5b198622ca89fa6643617f25b66cd7f27ae314/components/google/core/browser/google_tld_list.h
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/google/core/browser/google_url_tracker.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/google/core/browser/google_util_unittest.cc
[add] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/google/core/common/BUILD.gn
[rename] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/google/core/common/google_switches.cc
[rename] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/google/core/common/google_switches.h
[add] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/google/core/common/google_tld_list.h
[rename] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/google/core/common/google_util.cc
[rename] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/google/core/common/google_util.h
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/history/core/browser/BUILD.gn
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/history/core/browser/DEPS
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/history/core/browser/visit_database.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/ntp_tiles/DEPS
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/ntp_tiles/popular_sites_impl.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/policy/core/browser/DEPS
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/policy/core/browser/url_util.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/safe_search_api/BUILD.gn
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/safe_search_api/DEPS
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/safe_search_api/url_checker.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/search_engines/template_url.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/search_engines/template_url_prepopulate_data.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/search_engines/template_url_prepopulate_data_unittest.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/search_engines/template_url_unittest.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/security_interstitials/DEPS
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/security_interstitials/core/controller_client.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/security_interstitials/core/safe_browsing_loud_error_ui.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/security_interstitials/core/safe_browsing_quiet_error_ui.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/signin/core/browser/chrome_connected_header_helper.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/signin/core/browser/signin_header_helper.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/signin/ios/browser/account_consistency_service.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/suggestions/DEPS
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/suggestions/suggestions_service_impl.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/variations/net/variations_http_headers.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/components/web_resource/web_resource_service.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/DEPS
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/metrics/new_tab_page_uma.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/reading_list/reading_list_distiller_page.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/search_engines/ui_thread_search_terms_data.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/u2f/u2f_controller.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/contextual_search/contextual_search_controller.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/contextual_search/contextual_search_delegate.cc
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/location_bar/location_bar_legacy_coordinator.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/ntp/incognito_view.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/settings/clear_browsing_data_manager.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/settings/do_not_track_collection_view_controller.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/settings/sync_encryption_collection_view_controller.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/ui/settings/translate_collection_view_controller.mm
[modify] https://crrev.com/9cf3d7f024aec446ac1d9865c20950ab76c653d5/ios/chrome/browser/voice/voice_search_url_rewriter.mm
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8dd98642173f26e20338e9da9eb74d31126198c

commit b8dd98642173f26e20338e9da9eb74d31126198c
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Aug 01 21:37:43 2018

Apply Google-related request modifications for networking service path.

This adds support for:
1) Safe Search
2) YouTube restricted mode
3) restricting consumer accounts
through Group Policy.

The other supporting change is to make ThrottlingURLLoader handle a throttle changing the URL in WillStartRequest.

Bug:  841313 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ic98e14dd5fa7b5b00d4befd3314aca7a67e6ba5a
Reviewed-on: https://chromium-review.googlesource.com/1152507
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579953}
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/BUILD.gn
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/io_thread.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/net/chrome_network_delegate.h
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/net/chrome_network_delegate_unittest.cc
[delete] https://crrev.com/b4311d0f07775f7ee4556bcaeb437f045b1d76cf/chrome/browser/net/safe_search_util.h
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/profiles/renderer_updater.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/profiles/renderer_updater.h
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/supervised_user/supervised_user_pref_store.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/browser/supervised_user/supervised_user_service_browsertest.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/common/BUILD.gn
[add] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/common/google_url_loader_throttle.cc
[add] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/common/google_url_loader_throttle.h
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/common/net/BUILD.gn
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/common/net/DEPS
[rename] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/common/net/safe_search_util.cc
[add] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/common/net/safe_search_util.h
[rename] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/common/net/safe_search_util_unittest.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/common/renderer_configuration.mojom
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/common/url_constants.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/common/url_constants.h
[delete] https://crrev.com/b4311d0f07775f7ee4556bcaeb437f045b1d76cf/chrome/common/variations/OWNERS
[delete] https://crrev.com/b4311d0f07775f7ee4556bcaeb437f045b1d76cf/chrome/common/variations_header_url_loader_throttle.cc
[delete] https://crrev.com/b4311d0f07775f7ee4556bcaeb437f045b1d76cf/chrome/common/variations_header_url_loader_throttle.h
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/renderer/chrome_render_thread_observer.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/renderer/chrome_render_thread_observer.h
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/renderer/url_loader_throttle_provider_impl.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/chrome/test/BUILD.gn
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/components/variations/variations_http_header_provider.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/content/common/throttling_url_loader.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/content/common/throttling_url_loader.h
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/content/common/throttling_url_loader_unittest.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/content/public/common/url_loader_throttle.h
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/b8dd98642173f26e20338e9da9eb74d31126198c/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 17 by jam@chromium.org, Aug 1

Status: Fixed (was: Started)
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ec986920aa571ec42586f88bc582b86b8fad657

commit 4ec986920aa571ec42586f88bc582b86b8fad657
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Aug 02 01:33:57 2018

Revert "Apply Google-related request modifications for networking service path."

This reverts commit b8dd98642173f26e20338e9da9eb74d31126198c.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 579953 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I4ZGQ5ODY0MjE3M2YyNmUyMDMzOGU5ZGE5ZWI3NGQzMTEyNjE5OGMM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/9356

Sample Failed Step: not_site_per_process_unit_tests

Original change's description:
> Apply Google-related request modifications for networking service path.
> 
> This adds support for:
> 1) Safe Search
> 2) YouTube restricted mode
> 3) restricting consumer accounts
> through Group Policy.
> 
> The other supporting change is to make ThrottlingURLLoader handle a throttle changing the URL in WillStartRequest.
> 
> Bug:  841313 
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: Ic98e14dd5fa7b5b00d4befd3314aca7a67e6ba5a
> Reviewed-on: https://chromium-review.googlesource.com/1152507
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579953}

Change-Id: Ic1b90a4148f1d5ebb4442ce34fa5421d879ef32f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  841313 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1159801
Cr-Commit-Position: refs/heads/master@{#580025}
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/BUILD.gn
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/io_thread.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/net/chrome_network_delegate.h
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/net/chrome_network_delegate_unittest.cc
[rename] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/net/safe_search_util.cc
[add] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/net/safe_search_util.h
[rename] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/net/safe_search_util_unittest.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/profiles/renderer_updater.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/profiles/renderer_updater.h
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/supervised_user/supervised_user_pref_store.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/browser/supervised_user/supervised_user_service_browsertest.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/common/BUILD.gn
[delete] https://crrev.com/032102f00a32d672fb197a99ae9e04af8a81c693/chrome/common/google_url_loader_throttle.cc
[delete] https://crrev.com/032102f00a32d672fb197a99ae9e04af8a81c693/chrome/common/google_url_loader_throttle.h
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/common/net/BUILD.gn
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/common/net/DEPS
[delete] https://crrev.com/032102f00a32d672fb197a99ae9e04af8a81c693/chrome/common/net/safe_search_util.h
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/common/renderer_configuration.mojom
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/common/url_constants.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/common/url_constants.h
[add] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/common/variations/OWNERS
[add] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/common/variations_header_url_loader_throttle.cc
[add] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/common/variations_header_url_loader_throttle.h
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/renderer/chrome_render_thread_observer.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/renderer/chrome_render_thread_observer.h
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/renderer/url_loader_throttle_provider_impl.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/chrome/test/BUILD.gn
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/components/variations/variations_http_header_provider.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/content/common/throttling_url_loader.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/content/common/throttling_url_loader.h
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/content/common/throttling_url_loader_unittest.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/content/public/common/url_loader_throttle.h
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/4ec986920aa571ec42586f88bc582b86b8fad657/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fb604920ab02cefffbef77f295cdd407830c3c4

commit 9fb604920ab02cefffbef77f295cdd407830c3c4
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Aug 02 04:28:50 2018

Apply Google-related request modifications for networking service path.

This adds support for:
1) Safe Search
2) YouTube restricted mode
3) restricting consumer accounts
through Group Policy.

The other supporting change is to make ThrottlingURLLoader handle a throttle changing the URL in WillStartRequest.

This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1152507 with a fix for the CFI failure in unit_tests.

TBR=kinuko

Bug:  841313 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iedb413e4cb2837d71d380e5df74d7f80305181cd
Reviewed-on: https://chromium-review.googlesource.com/1159821
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580063}
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/BUILD.gn
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/io_thread.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/net/chrome_network_delegate.h
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/net/chrome_network_delegate_unittest.cc
[delete] https://crrev.com/d01b7c9e8df0568084a589486949a54ca82e89f1/chrome/browser/net/safe_search_util.h
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/profiles/renderer_updater.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/profiles/renderer_updater.h
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/supervised_user/supervised_user_pref_store.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/browser/supervised_user/supervised_user_service_browsertest.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/common/BUILD.gn
[add] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/common/google_url_loader_throttle.cc
[add] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/common/google_url_loader_throttle.h
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/common/net/BUILD.gn
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/common/net/DEPS
[rename] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/common/net/safe_search_util.cc
[add] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/common/net/safe_search_util.h
[rename] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/common/net/safe_search_util_unittest.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/common/renderer_configuration.mojom
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/common/url_constants.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/common/url_constants.h
[delete] https://crrev.com/d01b7c9e8df0568084a589486949a54ca82e89f1/chrome/common/variations/OWNERS
[delete] https://crrev.com/d01b7c9e8df0568084a589486949a54ca82e89f1/chrome/common/variations_header_url_loader_throttle.cc
[delete] https://crrev.com/d01b7c9e8df0568084a589486949a54ca82e89f1/chrome/common/variations_header_url_loader_throttle.h
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/renderer/chrome_render_thread_observer.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/renderer/chrome_render_thread_observer.h
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/renderer/url_loader_throttle_provider_impl.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/chrome/test/BUILD.gn
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/components/variations/variations_http_header_provider.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/content/common/throttling_url_loader.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/content/common/throttling_url_loader.h
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/content/common/throttling_url_loader_unittest.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/content/public/common/url_loader_throttle.h
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/9fb604920ab02cefffbef77f295cdd407830c3c4/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 20 by chchakrapani@chromium.org, Aug 16

Status: Assigned (was: Fixed)
Hi John,
Could you please provide steps to verify the fix. Thanks.!

Comment 21 by jam@chromium.org, Aug 16

Status: Fixed (was: Assigned)
There's automated tests. To test manually, you'd need to enable the enterprise policies.

Note this isn't enabled by default yet; it's behind a flag (network service).

Comment 22 by chchakrapani@chromium.org, Aug 16

Status: Verified (was: Fixed)
Thanks John :)
Closing the issue as it was verified through automated tests.
►

Sign in to add a comment