New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841311 link

Starred by 2 users
Status: Assigned
Owner:
█ nednguyen@chromium.org
Last visit > 30 days ago
Cc:
perezju@chromium.org
charliea@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Refactor story_runner to use shared_state's platform for determining test disabling state

Project Member Reported by nedngu...@google.com, May 9 2018 
Full context is in  issue 840428 .

This refactors help:
1) Making Telemetry benchmark less browser specific.
2) Removing one call of browser discovery. Currently, Telemetry benchmark_runner invoke browser discovering at least two times:
one to discover the target test platform for test disabling logic, and another one during the story run loop.
Project Member

Comment 1 by bugdroid1@chromium.org, May 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09de1265b68aff3feb6d7e9fe5a1db909acb9497

commit 09de1265b68aff3feb6d7e9fe5a1db909acb9497
Author: nednguyen <nednguyen@google.com>
Date: Wed May 09 19:02:02 2018

Set shared_browserless_state to use host platform as the test target platform

Later, when we refactor story_runner to use shared_state's platform for
determining test disabling logic, we would need to make sure that platform is
not None.

Bug: 841311
Change-Id: If38d9ae2f03d12034ed2b1352672cb5ef33ebc40
Reviewed-on: https://chromium-review.googlesource.com/1052207
Reviewed-by: Ravi Mistry <rmistry@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#557268}
[modify] https://crrev.com/09de1265b68aff3feb6d7e9fe5a1db909acb9497/tools/perf/contrib/cluster_telemetry/shared_browserless_story.py

Comment 2 by benhenry@chromium.org, Aug 3

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Comment 3 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 4 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry
►

Sign in to add a comment