New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841294 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

FR: ChromAD Autocomplete domain name policy for sign in screen

Project Member Reported by alu...@chromium.org, May 9 2018

Issue description

Description: Enable domain name autocomplete during user sign in


Use case:
Enable a policy to autocomplete the domain portion so that a user is only required to enter the userID. 

A policy for Chrome cloud management exists. 
https://www.chromium.org/administrators/policy-list-3#DeviceLoginScreenDomainAutoComplete

Motivation:
Speed up the login process. 

Having to enter the full email is error prone.
Enterprise users don't typically need to do that on other OS, so this impacts adoption.


Existing workarounds:
None. 
 
Labels: Enterprise-Triaged
Owner: atwilson@chromium.org
Drew, it seems someone from our team should take it.
Cc: pelets...@chromium.org
Owner: ljusten@chromium.org
Owner: rsorokin@chromium.org
Roman, I remember we talked about this and I thought we were doing this.
kAccountsPrefLoginScreenDomainAutoComplete only seems to be used for GaiaScreenHandler, though.

Could it be related to the new login UI?
Status: Assigned (was: Untriaged)
I'll take a look
Labels: -Pri-3 M-68 Pri-2
Status: Started (was: Assigned)
Labels: -chomad Chromad
Project Member

Comment 8 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81c3a128e40a939265e187f5c034673d90d86850

commit 81c3a128e40a939265e187f5c034673d90d86850
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Wed May 23 08:09:06 2018

Chromad: Propagate DeviceLoginScreenDomainAutoComplete

This CL wires DeviceLoginScreenDomainAutoComplete policy with the Active
Directory login screen

BUG= chromium:841294 
TEST=ActiveDirectoryLoginAutocompleteTest.TestAutocomplete

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I29b264b251cc21b909a526bfb35c73110e6a93ea
Reviewed-on: https://chromium-review.googlesource.com/1069147
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561000}
[modify] https://crrev.com/81c3a128e40a939265e187f5c034673d90d86850/chrome/browser/chromeos/login/active_directory_login_browsertest.cc
[modify] https://crrev.com/81c3a128e40a939265e187f5c034673d90d86850/chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Status: Fixed (was: Started)
We don't see the policy in the ADMX template. 

Can someone confirm if there is work required to update and release a new ADMX template for Chomad so customers can use this policy?
Cc: rsorokin@chromium.org
 Issue 819982  has been merged into this issue.
Sorry, it was not added into admx. We're on it
I've uploaded a fix. For your convenience, I've attached the ADMX templates.
admx.zip
3.5 MB Download
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5da55860823a94842fea672b78c7a0e26572a20e

commit 5da55860823a94842fea672b78c7a0e26572a20e
Author: Lutz Justen <ljusten@chromium.org>
Date: Mon Jun 11 11:26:59 2018

policy_templates: Support DLSDomainAutoComplete for AD

CL:1069147 added support for DeviceLoginScreenDomainAutoComplete for
Active Directory (AD) managed Chrome OS devices. However, the policy
wasn't included in the ADMX template, so it couldn't be set. This CL
fixes that.

BUG= chromium:841294 
TEST=ninja -C out/Release -j 2000 policy_templates
     for target OS chrome_os. Checked that generated Chrome OS templates
    contain policy.

Change-Id: Iea9ef7cc9616e4705a16e762b19fc264307e569d
Reviewed-on: https://chromium-review.googlesource.com/1092531
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565965}
[modify] https://crrev.com/5da55860823a94842fea672b78c7a0e26572a20e/components/policy/resources/policy_templates.json

Status: Verified (was: Fixed)
Verified Autocomplete domain is shown on sign-in screen in M68.0.3440.23 10718.21.0 dev reks.
Owner: ljusten@chromium.org
This is actually not working right now. By default it autocompletes with the MACHINE domain, but the DLSDomainAutoComplete policy does not take effect.

Protofiles needs to be uprev'ed in Chrome OS. I'll take a look.
Status: Assigned (was: Verified)
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cf45861cd9fc78e3db2b49238f6a567892f747c8

commit cf45861cd9fc78e3db2b49238f6a567892f747c8
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Jun 21 15:14:24 2018

authpolicy: Update DevicePolicyEncoder with new policies

Companion change of uprev protofiles and VERSION to Chromium 69.0.3466.
Adds support for DeviceLoginScreenDomainAutoComplete and
kDeviceAutoUpdateTimeRestrictions.

CQ-DEPEND=CL:1107625

BUG= chromium:841294 
TEST=./build_packages --board=amd64-generic && \
      cros_run_unit_tests --board=amd64-generic --packages authpolicy

Change-Id: Iae16b198e8f963612e34d0568d56964c77a3cfdf
Reviewed-on: https://chromium-review.googlesource.com/1107623
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/cf45861cd9fc78e3db2b49238f6a567892f747c8/authpolicy/policy/device_policy_encoder.cc
[modify] https://crrev.com/cf45861cd9fc78e3db2b49238f6a567892f747c8/authpolicy/policy/device_policy_encoder_unittest.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c3cd2c80468443553752d0e6983c3cc6156f2188

commit c3cd2c80468443553752d0e6983c3cc6156f2188
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Jun 21 15:14:24 2018

Uprev protofiles and VERSION to Chromium 69.0.3466

This picks up the following changes:

Changes for components/policy.git
(https://chromium.googlesource.com/chromium/src/components/policy)
17dc45b1 Adolfo Victoria     Add new policy: Update Time Restrictions
ead22806 Patrick Noland      [EoC] Add enterprise policy for contextual..
a6305c44 Roger Tawa          Cleanup policy caption and description.
bdf11cbe A Olsen             Refactor boilerplate in cloud_policy_gener..
fc039910 proberge            Update the ChromeCleanupReportingEnabled p..
088f7887 Adolfo Victoria     Refactor OffHoursInterval to WeeklyTimeInt..
bd3ad59e Lutz Justen         policy_templates: Support DLSDomainAutoCom..
9c48f5dd A Olsen             RF:Surface errors for invalid JSON string ..
1cb1b5fc Pavol Marko         Move highest policy id into constant and e..
aac3f0f0 Pavol Marko         Update network traffic annotations and des..
f0f8ddb2 A Olsen             Revert "Surface errors for invalid JSON st..
dbef11a1 Yves Arrouye        Upload EIDs as bytes.
6b4b4987 Aga Wronska         Increment highest id counter in policy_tem..
9933ef83 Aga Wronska         Fix typo in UsageTimeLimit policy descript..
c928f868 A Olsen             Surface errors for invalid JSON string pol..
26f57678 Henrique Grandine.. Change UsageTimeLimit policy OS supported ..
edc732f0 Bernhard Bauer      Remove image content setting policies on A..
227d3abb Alexander Hendrich  'AllowedLocales' policy follow up
d9f2eaa8 Aga Wronska         Add EnableSyncConsent policy.
50125caa Bartosz Fabianowski Change B&R and GLS policy defaults
f4239dae Pavol Marko         Remove line breaks in site isolation polic..
02e0a7e8 Aga Wronska         Include time zone for child user in sessio..
f3797e5f Luciana Maroun      Adding a policy handler for usage time lim..
0d482d30 Pavol Marko         DeveloperToolsAvailability overrides Devel..
40eed6d2 Lukasz Anforowicz   Limit Android Site Isolation enterprise po..
858e1153 Henrique Grandine.. Rename field on UsageTimeLimit policy.
5f02553c Henrique Grandine.. Add Time Limit policy. go/ucos-timelimit-dd.
8b56f73c Pavol Marko         Support direct upload of EIDs from the dev..
2feeb9e4 Jialiu Lin          Remove the GSuite restriction from login &..
6c698dd2 Adam Langley        Clarify description of CookiesSessionOnlyF..
6d50b4f3 Ivan Sandrk         Add "ArcCommand" to Chrome OS
f342394d Jialiu Lin          Remove PasswordProtectionRiskTrigger policy
ae6cf4ab Bartosz Fabianowski Add policy to control app install event lo..
53ee8c52 Julian Pastarmov    Add a field for deleted policies to policy..
914d5366 Pavol Marko         Send brand code on enterprise enrollment
8936dd42 Chris Palmer        Create Android-specific enterprise policy ..

CQ-DEPEND=CL:1107623

BUG= chromium:841294 
TEST=./build_packages --board=amd64-generic && \
     cros_run_unit_tests --board=amd64-generic --packages authpolicy

Change-Id: I37429397483fbf246d55dc6b7810d32e2c408d79
Reviewed-on: https://chromium-review.googlesource.com/1107625
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[rename] https://crrev.com/c3cd2c80468443553752d0e6983c3cc6156f2188/chromeos-base/protofiles/protofiles-0.0.21.ebuild
[modify] https://crrev.com/c3cd2c80468443553752d0e6983c3cc6156f2188/chromeos-base/protofiles/files/VERSION

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified fixed, DeviceLoginScreenDomainAutoComplete policy takes effect for Chromad (see attached screenshots).

Chrome OS: 10888.0.0
Chrome: 69.0.3494.0
Device: Santa
Screenshot 2018-07-19 at 4.08.29 PM.png
63.6 KB View Download
Screenshot 2018-07-19 at 4.06.29 PM.png
1020 KB View Download

Sign in to add a comment