Added flag to lld-link in r332012

We probably also want to give lld-link an fansi-escape-codes flag to make this work on Windows under ansicon.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00db3ddc4c4f9ebd4d95ad44ea4ef74415c66394

commit 00db3ddc4c4f9ebd4d95ad44ea4ef74415c66394
Author: Nico Weber <thakis@chromium.org>
Date: Mon May 21 20:06:59 2018

Let lld emit colored diagnostics when invoked from ninja.

Bug:  841221 
Change-Id: I72d13c78a2c623865a4f29542d25f6b3488b350b
Reviewed-on: https://chromium-review.googlesource.com/1067460
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560343}
[modify] https://crrev.com/00db3ddc4c4f9ebd4d95ad44ea4ef74415c66394/build/config/compiler/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18da5f23138a86e9142cbebc5b0ef44291d9569a

commit 18da5f23138a86e9142cbebc5b0ef44291d9569a
Author: Tommy Li <tommycli@chromium.org>
Date: Mon May 21 21:47:23 2018

Revert "Let lld emit colored diagnostics when invoked from ninja."

This reverts commit 00db3ddc4c4f9ebd4d95ad44ea4ef74415c66394.

Reason for revert: Breaks Linux CFI build here: https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/8024

Original change's description:
> Let lld emit colored diagnostics when invoked from ninja.
> 
> Bug:  841221 
> Change-Id: I72d13c78a2c623865a4f29542d25f6b3488b350b
> Reviewed-on: https://chromium-review.googlesource.com/1067460
> Reviewed-by: Reid Kleckner <rnk@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560343}

TBR=thakis@chromium.org,rnk@chromium.org

Change-Id: I3811083daa622dca605ca32be5cc4c7098b60b4a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  841221 
Reviewed-on: https://chromium-review.googlesource.com/1067949
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560345}
[modify] https://crrev.com/18da5f23138a86e9142cbebc5b0ef44291d9569a/build/config/compiler/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/979ca1f97abdc13a5bd9605ca5bfd21cae211c42

commit 979ca1f97abdc13a5bd9605ca5bfd21cae211c42
Author: Nico Weber <thakis@chromium.org>
Date: Tue May 22 17:28:20 2018

Set use_lld = false in nacl toolchains and reland "Let lld emit colored diagnostics when invoked from ninja."

This reverts commit 18da5f23138a86e9142cbebc5b0ef44291d9569a.

Reason for revert: The original commit broke the CFI bot with errors like:

  src/native_client/toolchain/linux_x86/pnacl_newlib/bin/../x86_64-nacl/bin/ld:
      unrecognized option '--color-diagnostics'

I do not know why this only happened on the CFI bot (XXX), but since we only add
-fuse-ld=lld if !is_nacl, we should set use_lld to false in the nacl toolchains,
which fixes this, and probably many future issues like it.

Original change's description:
> Revert "Let lld emit colored diagnostics when invoked from ninja."
>
> This reverts commit 00db3ddc4c4f9ebd4d95ad44ea4ef74415c66394.
>
> Reason for revert: Breaks Linux CFI build here: https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/8024
>
> Original change's description:
> > Let lld emit colored diagnostics when invoked from ninja.
> >
> > Bug:  841221 
> > Change-Id: I72d13c78a2c623865a4f29542d25f6b3488b350b
> > Reviewed-on: https://chromium-review.googlesource.com/1067460
> > Reviewed-by: Reid Kleckner <rnk@chromium.org>
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#560343}
>
> TBR=thakis@chromium.org,rnk@chromium.org
>
> Change-Id: I3811083daa622dca605ca32be5cc4c7098b60b4a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  841221 
> Reviewed-on: https://chromium-review.googlesource.com/1067949
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Commit-Queue: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560345}

TBR=thakis@chromium.org,rnk@chromium.org,tommycli@chromium.org

Change-Id: I5d4c9298e3613ab84650f081a59715880d780805
Bug:  841221 
Reviewed-on: https://chromium-review.googlesource.com/1068218
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560676}
[modify] https://crrev.com/979ca1f97abdc13a5bd9605ca5bfd21cae211c42/build/config/compiler/BUILD.gn
[modify] https://crrev.com/979ca1f97abdc13a5bd9605ca5bfd21cae211c42/build/toolchain/nacl/BUILD.gn