New issue
Advanced search Search tips

Issue 841218 link

Starred by 3 users
Status: Fixed
Owner:
lethalantidote@chromium.org
Closed: Sep 18
Cc:
dmazz...@chromium.org
steimel@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Media Controls: don't hide controls while they are accessibility focused

Project Member Reported by mlamouri@chromium.org, May 9 2018 
Chrome 67 has been improving the accessibility of the controls on Android by keeping them visible if the user goes to them with an accessibility tool but we would like a solution when accessibility focus behave like regular focus. That only affects Android because other platforms will set real focus on the element when accessibility focused.
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af5f52b07b719e58963a559d67bdde054c8c3f84

commit af5f52b07b719e58963a559d67bdde054c8c3f84
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed May 16 18:38:44 2018

Expose Android accessibility focus to Blink accessibility internals

Bug:  841218 
TBR=michaelpg@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iaea99a1a18c1eea7d1480b68b4a1aa71448d09d1
Reviewed-on: https://chromium-review.googlesource.com/1050498
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559203}
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/content/browser/accessibility/browser_accessibility_manager.cc
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/content/browser/accessibility/browser_accessibility_manager.h
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/content/browser/accessibility/web_contents_accessibility_android.cc
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/content/browser/accessibility/web_contents_accessibility_android.h
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/content/renderer/accessibility/render_accessibility_impl.cc
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/third_party/blink/public/web/web_ax_object.h
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/third_party/blink/renderer/modules/accessibility/ax_object.cc
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/third_party/blink/renderer/modules/accessibility/ax_object.h
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/third_party/blink/renderer/modules/exported/web_ax_object.cc
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/ui/accessibility/ax_enum_util.cc
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/ui/accessibility/ax_enums.mojom
[modify] https://crrev.com/af5f52b07b719e58963a559d67bdde054c8c3f84/ui/accessibility/ax_node_data.cc

Comment 2 by lethalantidote@chromium.org, Sep 13

Owner: lethalantidote@chromium.org
Status: Assigned (was: Available)

Comment 3 by lethalantidote@chromium.org, Sep 13

Labels: -Pri-3 Pri-1

Comment 4 by lethalantidote@chromium.org, Sep 17

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65c18293283cf5bb3fa5f8bd4f376d73424b60f3

commit 65c18293283cf5bb3fa5f8bd4f376d73424b60f3
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Tue Sep 18 21:27:00 2018

Prevents controls from hiding when given accessibility focus.

Previously, when one gave a media control accessibility focus (swiping to it
in TalkBack for example), the controls would continue to hold a11y focus, but
hide. This was confusing. Now they continue to show when given a11y focus.

Bug:  841218 
Change-Id: I0a589bc3c51b4c3dad23ab666b94470d5991c9d1
Reviewed-on: https://chromium-review.googlesource.com/1228989
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592199}
[modify] https://crrev.com/65c18293283cf5bb3fa5f8bd4f376d73424b60f3/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/65c18293283cf5bb3fa5f8bd4f376d73424b60f3/third_party/blink/renderer/modules/accessibility/ax_media_controls.h
[modify] https://crrev.com/65c18293283cf5bb3fa5f8bd4f376d73424b60f3/third_party/blink/renderer/modules/accessibility/ax_object.cc
[modify] https://crrev.com/65c18293283cf5bb3fa5f8bd4f376d73424b60f3/third_party/blink/renderer/modules/media_controls/elements/media_control_elements_helper.cc
[modify] https://crrev.com/65c18293283cf5bb3fa5f8bd4f376d73424b60f3/third_party/blink/renderer/modules/media_controls/elements/media_control_elements_helper.h
[modify] https://crrev.com/65c18293283cf5bb3fa5f8bd4f376d73424b60f3/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.cc
[modify] https://crrev.com/65c18293283cf5bb3fa5f8bd4f376d73424b60f3/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.h
[modify] https://crrev.com/65c18293283cf5bb3fa5f8bd4f376d73424b60f3/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/65c18293283cf5bb3fa5f8bd4f376d73424b60f3/third_party/blink/renderer/modules/media_controls/media_controls_impl.h
[modify] https://crrev.com/65c18293283cf5bb3fa5f8bd4f376d73424b60f3/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc

Comment 6 by lethalantidote@chromium.org, Sep 18

Status: Fixed (was: Started)

Comment 7 by dmazz...@chromium.org, Jan 15 

Issue 702844 has been merged into this issue.
►

Sign in to add a comment