New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841210 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in skcms_TransferFunction_eval

Project Member Reported by ClusterFuzz, May 9 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6245710027292672

Fuzzer: libFuzzer_color_transform_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  skcms_TransferFunction_eval
  max_roundtrip_error
  skcms_MakeUsableAsDestinationWithSingleCurve
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=556846:556868

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6245710027292672

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 9 2018

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 9 2018

Cc: hubbe@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, May 9 2018

Cc: brianosman@google.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Switch to using skcms for ICC profile parsing by brianosman@google.com - https://chromium.googlesource.com/chromium/src/+/e6ae8f4c3bf66e5bf6641711062c15ea61df9cd2

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 4 by sheriffbot@chromium.org, May 9 2018

Labels: M-68
Project Member

Comment 5 by sheriffbot@chromium.org, May 9 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, May 9 2018

Labels: Pri-1
Project Member

Comment 7 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skcms/+/f771d234ebdc7a1297ad6afd7574987d2ed2c7ad

commit f771d234ebdc7a1297ad6afd7574987d2ed2c7ad
Author: Brian Osman <brianosman@google.com>
Date: Wed May 09 14:44:57 2018

Ensure that the TFs from ApproximateCurve are invertible

It's possible to produce an inverse curve (tf_inv) whose inverse (tf) is
no longer invertible.

Bug:  chromium:841210 
Change-Id: I757330039191da2aa74ad8a091d679f987c940bf
Reviewed-on: https://skia-review.googlesource.com/126924
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>

[modify] https://crrev.com/f771d234ebdc7a1297ad6afd7574987d2ed2c7ad/tests.c
[modify] https://crrev.com/f771d234ebdc7a1297ad6afd7574987d2ed2c7ad/profiles/misc/Japan_Color_2001_Coated.icc.txt
[modify] https://crrev.com/f771d234ebdc7a1297ad6afd7574987d2ed2c7ad/profiles/misc/sRGB_Calibrated_Heterogeneous.icc.txt
[modify] https://crrev.com/f771d234ebdc7a1297ad6afd7574987d2ed2c7ad/src/TransferFunction.c
[modify] https://crrev.com/f771d234ebdc7a1297ad6afd7574987d2ed2c7ad/profiles/misc/Coated_FOGRA39_CMYK.icc.txt
[add] https://crrev.com/f771d234ebdc7a1297ad6afd7574987d2ed2c7ad/profiles/fuzz/inverse_tf_not_invertible.icc.txt
[modify] https://crrev.com/f771d234ebdc7a1297ad6afd7574987d2ed2c7ad/profiles/misc/Phase_One_P25.icc.txt
[modify] https://crrev.com/f771d234ebdc7a1297ad6afd7574987d2ed2c7ad/profiles/misc/Kodak_sRGB.icc.txt
[modify] https://crrev.com/f771d234ebdc7a1297ad6afd7574987d2ed2c7ad/profiles/sRGB_Facebook.icc.txt
[modify] https://crrev.com/f771d234ebdc7a1297ad6afd7574987d2ed2c7ad/profiles/misc/sRGB_Calibrated_Homogeneous.icc.txt
[add] https://crrev.com/f771d234ebdc7a1297ad6afd7574987d2ed2c7ad/profiles/fuzz/inverse_tf_not_invertible.icc
[modify] https://crrev.com/f771d234ebdc7a1297ad6afd7574987d2ed2c7ad/profiles/misc/ColorLogic_ISO_Coated_CMYK.icc.txt
[modify] https://crrev.com/f771d234ebdc7a1297ad6afd7574987d2ed2c7ad/profiles/misc/DisplayCal_ASUS_NonMonotonic.icc.txt
[modify] https://crrev.com/f771d234ebdc7a1297ad6afd7574987d2ed2c7ad/profiles/misc/US_Web_Coated_SWOP_CMYK.icc.txt

Owner: brianosman@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 9 by ClusterFuzz, May 10 2018

ClusterFuzz has detected this issue as fixed in range 557225:557237.

Detailed report: https://clusterfuzz.com/testcase?key=6245710027292672

Fuzzer: libFuzzer_color_transform_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  skcms_TransferFunction_eval
  max_roundtrip_error
  skcms_MakeUsableAsDestinationWithSingleCurve
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=556846:556868
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=557225:557237

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6245710027292672

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, May 10 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6245710027292672 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, May 10 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 13 by sheriffbot@chromium.org, Aug 16

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment