Delegating

Summarizing a bit of repro detail here:
Selecting the radio button option with the mouse works.
Selecting the radio button option with the keyboard arrow keys does not work.
Selecting the radio button option with the keyboard arrow keys, and then pressing enter, does work.

I agree with OP that 482735 is very likely to have introduced the issue.
My current hypothesis: ContentSettingSingleRadioGroup has a selected_item_ field that tracks the selected radio option, but the code that updates it only listens for click events.  Before 482735, selecting a radio button option with the arrow keys simulated a click on that radio button. 482735 removed that simulated click in order to remove the 'ink drop' animation when selecting a radio option with arrow keys.  However, the simulated click was also the mechanism that updated selected_item_, so without it, selected_item_ gets out of sync with the radio group's state.

I'll add a unit test to validate that hypothesis, and if it checks out will try removing selected_item_ so we don't have duplicated state.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/754f9b669fd1200644b11820597926099b60d4b3

commit 754f9b669fd1200644b11820597926099b60d4b3
Author: Taylor Bergquist <tbergquist@chromium.org>
Date: Fri Jul 13 23:12:02 2018

Fix radio buttons in content setting bubbles

The various content setting bubbles were listening to their radio
buttons and maintaining a separate copy of the buttons' checkedness
state.  However, radio buttons didn't notify their listeners when the
arrow keys were used to change checkedness; they only notified on mouse
events.

This CL makes the bubbles refer to the actual radio button state when
closing instead of listening to the buttons.  It also gets rid of radio
button listening as a thing, since it didn't work anyways and nobody
else was using it.

Other yaks shaved by this change:
- Remove Checkbox::set_listener so that it can't be called on radio
buttons.  Listeners must be added at construction time now.
- Move the business logic out of destructors in the content setting
bubbles so that the bubble models can reference their views without
worrying about them having been already cleaned up.  It's now in an
explicitly invoked separate method 'CommitChanges'.
- The RPH (register protocol handler) content setting bubble was the
only one that applied settings changes as users clicked on radio
buttons, rather than when the dialog was closed.  It's now consistent
with the other bubbles.

Bug:  841202 
Change-Id: I16761571fd03bb1925d95995d8b7e6f0e03aa02a
Reviewed-on: https://chromium-review.googlesource.com/1128377
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575112}
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/ash/message_center/notifier_settings_view.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/content_settings/content_setting_bubble_model.h
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
[add] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/content_settings/fake_owner.cc
[add] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/content_settings/fake_owner.h
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/content_settings/framebust_block_browsertest.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/views/chrome_cleaner_dialog_win.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/views/content_setting_bubble_contents.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/views/content_setting_bubble_contents.h
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/views/create_application_shortcut_view.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/views/global_error_bubble_view_unittest.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/views/media_router/cast_dialog_sink_button_unittest.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/views/translate/translate_bubble_view.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/chrome/browser/ui/views/uninstall_view.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/ui/views/controls/button/checkbox.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/ui/views/controls/button/checkbox.h
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/ui/views/controls/button/radio_button.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/ui/views/examples/box_layout_example.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/ui/views/examples/checkbox_example.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/ui/views/examples/dialog_example.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/ui/views/examples/label_example.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/ui/views/examples/multiline_example.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/ui/views/examples/radio_button_example.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/ui/views/examples/radio_button_example.h
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/ui/views/examples/table_example.cc
[modify] https://crrev.com/754f9b669fd1200644b11820597926099b60d4b3/ui/views/examples/text_example.cc

Forgot to mark this one fixed.