Regression: Context menu doesn't appear for partially selected text and cut, copy options remains disabled after selecting text via context menu.
Reported by
vku...@etouch.net,
May 9 2018
|
||||
Issue descriptionChrome Version: 68.0.3425.0 (Official Build)Revision ba3555398bfb463aa9a8f2e99c983708cfe845f7-refs/branch-heads/3425@{#1} (32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS) & Mac OS X(10.12.6,10.13.1,10.13.5) What steps will reproduce the problem? (1)Launch chrome and navigate to http://foersom.com/net/HowTo/data/OoPdfFormExample.pdf (2)Enter any text for e.g 'test' in name field or any field (3)Right click on text field > click 'select all' option from context menu such that text get selected. (4)Now again right click on selected text and observe the context menu. (5)Also select some part of text i.e 'st' and right on it,observe. Actual: 1.Cut and copy option remains disabled after selecting text via context menu(i.e after step 3 & 4) 2.Context menu doesn't appear after right clicking on partially selected text. Expected: 1.Cut and copy option should be enabled after selecting text via context menu(i.e after step 3 & 5) 2.Context menu should appear after right clicking on partially selected text. This is a regression issue broken in 'M68' and below is the manual regression range Good Build: 68.0.3399.0(Revision:551555) Bad Build: 68.0.3400.0(Revision:551875)
,
May 9 2018
Note: Issue is seen on other PDF file as mentioned below: 1. http://www.thewebjockeys.com/TheWebJockeys/Fillable_PDF_Sample_from_TheWebJockeys_vC5.pdf 2. http://www.royale-marketing.com/wp-content/uploads/seating_areas/sample_pdf.pdf
,
May 9 2018
Adding release blocker label for this issue.Please reduce priority or remove if not the case. Thank You!
,
May 9 2018
,
May 10 2018
,
May 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4e6981032b824d7178167d82eaaf1bd627c0766 commit f4e6981032b824d7178167d82eaaf1bd627c0766 Author: Lei Zhang <thestig@chromium.org> Date: Sat May 12 18:00:57 2018 Synthesize a key up event in PepperPluginInstanceImpl::SelectAll(). Currently, it only synthesizes a key char event, which is insufficient for the PDF plugin to produce the proper response. With the additional key up event, the PDF plugin will react correctly to keep the selected text state synchronized between the plugin and the renderer. BUG= 841196 Change-Id: I331562d2f39facc9affdeac98d85306c09d56130 Reviewed-on: https://chromium-review.googlesource.com/1053164 Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#558137} [modify] https://crrev.com/f4e6981032b824d7178167d82eaaf1bd627c0766/content/renderer/pepper/pepper_plugin_instance_impl.cc
,
May 14 2018
Update : Retested above issue on Windows (7,8,8.1,10),Linux(14.04 LTS) and Mac(10.12.6,10.13.1,10.13.5) OS using latest Canary #68.0.3430.0 and issue is fixed.Kindly review the attached screen-cast. Thank you!
,
May 14 2018
Thank you for reporting the bug and verifying the fix. |
||||
►
Sign in to add a comment |
||||
Comment 1 by vku...@etouch.net
, May 9 2018Owner: thestig@chromium.org
Status: Assigned (was: Unconfirmed)