Incorrect usage of the echo path gain in the AEC3 nonlinear mode |
||||||
Issue descriptionThe estimated reported echo path gain in AEC3 was incorrectly always set to one.
,
May 11 2018
An incorrect issue was specified in the WebRTC CL that addressed this issue. The CL addressing this issue was: https://webrtc-review.googlesource.com/c/src/+/75510 (Correcting the usage of the estimated echo path gain in AEC3). That CL was landed on May 9, 2018.
,
May 11 2018
We would like to merge this into M67. The CL addresses a problem for VoIP setups with fairly nolinear echo path where the estimated echo path gain was incorrectly discarded. The CL we would like to merge is: -https://webrtc-review.googlesource.com/c/src/+/75510 (Correcting the usage of the estimated echo path gain in AEC3) The CL has been tested both in Canary and in offline testing and works well. The merge is safe in the sense that the code affected is beneath an experimental flag.
,
May 11 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 11 2018
Same comment apply here for M67 merge request - https://bugs.chromium.org/p/chromium/issues/detail?id=841193#c5.
,
May 11 2018
Approving merge to M67 branch 3396 based on comment - https://bugs.chromium.org/p/chromium/issues/detail?id=841193#c6.
,
May 13 2018
This CL has been merged. The merging CL was -https://webrtc-review.googlesource.com/c/src/+/76323
,
May 13 2018
,
May 13 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by peah@chromium.org
, May 9 2018