New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841187 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Incorrect usage of the echo path gain in the AEC3 nonlinear mode

Project Member Reported by peah@chromium.org, May 9 2018

Issue description

The estimated reported echo path gain in AEC3 was incorrectly always set to one. 
 

Comment 1 by peah@chromium.org, May 9 2018

Summary: Incorrect usage of the echo path gain in the AEC3 nonlinear mode (was: Correcting the usage of the echo path gain in the AEC3 nonlinear mode)

Comment 2 by peah@chromium.org, May 11 2018

An incorrect issue was specified in the WebRTC CL that addressed this issue. 

The CL addressing this issue was:
https://webrtc-review.googlesource.com/c/src/+/75510 (Correcting the usage of the estimated echo path gain in AEC3).

That CL was landed on May 9, 2018.

Comment 3 by peah@chromium.org, May 11 2018

Cc: gustaf@chromium.org huib@chromium.org hlundin@chromium.org
Labels: Merge-Request-67
We would like to merge this into M67. 

The CL addresses a problem for VoIP setups with fairly nolinear echo path where the estimated echo path gain was incorrectly discarded.

The CL we would like to merge is:
-https://webrtc-review.googlesource.com/c/src/+/75510 (Correcting the usage of the estimated echo path gain in AEC3)

The CL has been tested both in Canary and in offline testing and works well.

The merge is safe in the sense that the code affected is beneath an experimental flag. 
Project Member

Comment 4 by sheriffbot@chromium.org, May 11 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, May 11 2018

Same comment apply here for M67 merge request - https://bugs.chromium.org/p/chromium/issues/detail?id=841193#c5.

Comment 6 by gov...@chromium.org, May 11 2018

Labels: -Merge-Review-67 Merge-Approved-67
Approving merge to M67 branch 3396 based on comment - https://bugs.chromium.org/p/chromium/issues/detail?id=841193#c6.

Comment 7 by peah@chromium.org, May 13 2018

This CL has been merged.
The merging CL was
-https://webrtc-review.googlesource.com/c/src/+/76323

Comment 8 by peah@chromium.org, May 13 2018

Labels: -Merge-Approved-67 merge-merged-67 M-67 Merge-Merged

Comment 9 by peah@chromium.org, May 13 2018

Status: Fixed (was: Assigned)

Sign in to add a comment